Repository navigation
[NO QA] ci: run iOS Sentry size analysis on macOS - #102691
Merged
Merged
Conversation
rlinoz
marked this pull request as ready for review
September 30, 2026 20:08
melvin-bot
Bot
requested review from
parasharrajat
and removed request for
a team
September 30, 2026 20:09
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Beamanator
approved these changes
Oct 1, 2026
Contributor
|
thanks sir! |
73 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.5.1-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.1-9 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Run the iOS Sentry size-analysis upload on an Apple Silicon macOS runner, since
sentry-clidoes not support IPA uploads on Linux. Use the existing smaller macOS runner and upstream checkout, with a 20-minute timeout to allow dependency installation on a cache miss.Print the captured CLI diagnostics before returning a failed upload's original exit code. Keep uploads non-blocking and leave the Android runner unchanged.
Fixed Issues
$ #99083
PROPOSAL: #99083 (comment)
Tests
Offline tests
N/A: CI-only change; no app offline behavior changes.
QA Steps
Once deployed verify size analysis for ios start showing up in sentry.
https://expensify.sentry.io/settings/projects/app/mobile-builds/
PR Author Checklist
App/UI-only checklist items are not applicable to this CI-only change and are left unchecked.
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A: CI-only change.
Android: mWeb Chrome
N/A: CI-only change.
iOS: Native
N/A: CI-only change.
iOS: mWeb Safari
N/A: CI-only change.
MacOS: Chrome / Safari
N/A: CI-only change.