Skip to content

refactor: remove unsafe assertions from attachment previews and receipts - #102992

Merged
blimpich merged 9 commits into
Expensify:mainfrom
KJ21-ENG:seatbelt-v2/883f486a-b1ab-4492-8c9a-e6c2da2dfe92
Nov 17, 2026
Merged

blimpich merged 9 commits into
Expensify:mainfrom
KJ21-ENG:seatbelt-v2/883f486a-b1ab-4492-8c9a-e6c2da2dfe92

Conversation

@KJ21-ENG

@KJ21-ENG KJ21-ENG commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Remove the unsafe as string assertions from the attachment viewer.

  • ImageView and Lightbox now take a URL or a static image asset (string | number). A static asset is passed to the image as is, instead of as {uri: 42}, which cannot load.
  • AttachmentView only opens the PDF viewer for a string source, and only shows ImageView for a URL or a static asset. It uses the fallback image only when it is a URL.

Behavior change: an attachment whose source is an image object, not a URL or asset, now shows the default attachment view instead of an image that could not load. A PDF whose source is not a URL no longer opens the PDF viewer.

The image and avatar typing moved to #103173, and the receipt drop and file validation moved to #103963, so each file is changed by one PR.

Changed files
  • src/components/Attachments/AttachmentView/AttachmentViewImage/index.tsx
  • src/components/Attachments/AttachmentView/index.tsx
  • src/components/ImageView/index.tsx
  • src/components/ImageView/types.ts
  • src/components/Lightbox/index.tsx
  • tests/unit/ImageViewSourceTest.tsx

Fixed Issues

$ #94739
PROPOSAL: #94739 (comment)

Tests

Use a signed-in test account with a chat you can write in.

C01 Image viewer

Precondition: a recognizable JPEG on the device.

  1. Attach the JPEG in the chat and send it.
  2. Open the sent image.
  3. Verify that the image shows upright and in proportion, with no spinner left on screen.
  4. Close the image and open it again.
  5. Verify that the same image shows again.

C02 PDF and image switching

Precondition: a PDF with readable text, sent in the same chat as the C01 image.

  1. Open the sent PDF.
  2. Verify that the PDF text is readable.
  3. Use the viewer arrows to switch to the image and back to the PDF. On Android and iOS, tap the attachment if the arrows are hidden, or swipe.
  4. Verify that each step shows the right attachment.

ImageViewSourceTest checks that a static image asset reaches the image unchanged, and that a URL is still wrapped as {uri}.

  • Verify that no errors appear in the JS console

Offline tests

C04 Local preview and reconnect

Setup: Open the JPEG’s local attachment preview before sending.

  1. Disconnect the network. Verify the local image remains visible.
  2. Reconnect and send the attachment.
  3. Open the posted image. Verify the correct content loads.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screenshots/Videos (7)

C01 desktop

PR-102992-C01-D.mp4

C01 phone-sized

PR-102992-C01-M.mp4

C02 desktop

PR-102992-C02-D.mp4

C02 phone-sized

PR-102992-C02-M.mp4

C04 desktop

PR-102992-C04-D.mp4

C04 phone-sized part 1

PR-102992-C04-M-part1.mp4

C04 phone-sized part 2

PR-102992-C04-M-part2.mp4

…ndaries

Seatbelt-Operation: run3-sign-487afbb7-ef00-4b92-ad0e-0b753237cc33
Seatbelt-Operation: run3-sign-ci-repair-76d2aedb-0961-4c6b-93e0-3b145163ae39
@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...ments/AttachmentView/AttachmentViewImage/index.tsx 93.75% <ø> (ø)
src/components/ImageView/index.tsx 82.47% <100.00%> (ø)
src/components/Lightbox/index.tsx 82.99% <100.00%> (+0.11%) ⬆️
...rc/components/Attachments/AttachmentView/index.tsx 50.56% <75.00%> (ø)
... and 19 files with indirect coverage changes

Seatbelt-Operation: remaining-102992-oneoff-sign-9c981f06-2963-45f2-b2d2-084f0586522e
@KJ21-ENG KJ21-ENG changed the title Remove unsafe assertions from attachment previews and receipt handling refactor: remove unsafe assertions from attachment previews and receipts Oct 19, 2026
Seatbelt-Operation: main-20261030-102992-sign-605530c5-46a1-4957-9de5-c17610d69fb4
Address review patterns before review. The image and file-upload changes are left to Expensify#103173 and
Expensify#103963, which own those files. ImageView and Lightbox take a URL or a static image asset, so a
numeric asset is passed to the image as is instead of as {uri: number}. AttachmentView only opens
the PDF viewer and ImageView for sources they can show. The 1,051-line render test is replaced by
one focused test for the static asset case.
KJ21-ENG added a commit to KJ21-ENG/App that referenced this pull request Nov 11, 2026
Take the Avatar, ReceiptImage and attachment-state changes that Expensify#102992 also made, so the image
typing lives in one PR. Reuse the Avatar style type instead of repeating it, and keep the existing
error for an image without a source. Drop the BaseImage test, which only covered a type change.
@KJ21-ENG
KJ21-ENG marked this pull request as ready for review November 11, 2026 13:29
@KJ21-ENG
KJ21-ENG requested review from a team as code owners November 11, 2026 13:29
@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and situchan and removed request for a team November 11, 2026 13:29
@melvin-bot

melvin-bot Bot commented Nov 11, 2026

Copy link
Copy Markdown

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team November 11, 2026 13:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T13:47:52.002009Z 7f291ef Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@KJ21-ENG

KJ21-ENG commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor Author

@situchan Could you please review this PR when you get a chance? Thanks!

…View props

ImageView renders Lightbox, so Lightbox should not take its uri type from ImageView. Both
components use string | number directly.
@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

No product review needed.

Seatbelt-Operation: reviewer-followup-20261115-102992-sign-5c638cb5-3430-426e-84a0-98b3d62c5b20

Copy link
Copy Markdown
Contributor Author

@situchan, could you please review this PR again? Merged main at d9d8c4e40ad7 in ce605069db93.

@situchan

situchan commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov

@melvin-bot
melvin-bot Bot requested a review from blimpich November 17, 2026 05:12
@blimpich
blimpich merged commit 34cdb55 into Expensify:main Nov 17, 2026
37 of 39 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.5.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR fixes attachment rendering and handles unsupported source types without adding a feature, changing a documented workflow, or making an existing article inaccurate.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants