Skip to content

refactor: remove unsafe assertions from report header, business summary, backTo cleanup and tags page - #103170

Merged
blimpich merged 9 commits into
Expensify:mainfrom
KJ21-ENG:seatbelt-v2/fresh-20261006-3-81455935
Nov 19, 2026
Merged

blimpich merged 9 commits into
Expensify:mainfrom
KJ21-ENG:seatbelt-v2/fresh-20261006-3-81455935

Conversation

@KJ21-ENG

@KJ21-ENG KJ21-ENG commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Remove unsafe as casts from the report header actions, the non-USD business summary, the stale backTo cleanup and the workspace tags page.

  • MoneyReportHeaderActions: the primary action is looked up in CONST.REPORT.PRIMARY_ACTIONS. The dropdown ref keeps its real RefObject<... | null> type, so MoneyReportHeaderSecondaryActions accepts that type.
  • Confirmation (non-USD business info): country, state and province names are read through string-keyed views of the code maps, without casts.
  • cleanStaleReportActionBackToParam: routes are walked with a small RouteView type that matches both full and partial navigation states. backTo is read with an in check, because each screen has its own params.
  • WorkspaceTagsPage: the selection update reads only single-level tags. Multi-level tag rows cannot be selected (see isSelectionEnabled), so the removed multi-level branch never ran. getPendingAction reads pendingAction without a cast; the formatter joins that ternary onto one line.

No behavior change.

Changed files
  • src/components/MoneyReportHeaderActions/MoneyReportHeaderSecondaryActions.tsx
  • src/components/MoneyReportHeaderActions/index.tsx
  • src/pages/ReimbursementAccount/NonUSD/BusinessInfo/subSteps/Confirmation.tsx
  • src/pages/inbox/cleanStaleReportActionBackToParam.ts
  • src/pages/workspace/tags/WorkspaceTagsPage.tsx

Fixed Issues

$ #94739
PROPOSAL: #94739 (comment)

Tests

C01 Selected single-level tag rename and deletion

Precondition: Web only (Chrome or Safari, desktop or mobile browser), because the case needs two browser tabs. Signed in as a workspace admin. The workspace has single-level tags Alpha and Beta. Open Workspaces, select the workspace, then Tags, in two browser tabs.

  1. In the first tab, select Alpha. On a wide layout, check its checkbox. On a narrow layout, long press Alpha and choose Select.
  2. In the second tab, rename Alpha to Alpha renamed.
  3. Verify that Alpha renamed stays selected in the first tab.
  4. In the second tab, delete Alpha renamed.
  5. Verify that the selection clears in the first tab and Beta is still listed.

C02 Multi-level tag list

Precondition: Signed in as an admin of a Control workspace with two independent multi-level tag lists, each with two enabled tags. To create them, open Workspaces, select the workspace, open Tags, choose More > Import spreadsheet, pick Multi-level tags, upload a CSV with two tag columns and check These are independent tags.

  1. Open Workspaces, select the workspace, then Tags.
  2. Verify that both lists show in order and have no selection checkbox.
  3. Open the first list and turn off one tag. Go back.
  4. Verify that both lists are still shown without an error.
  5. Open the first list again.
  6. Verify that the tag is still off.

C03 Report actions, selection and layout

Precondition: A report with at least two expenses that you can edit.

  1. Open the report and open More.
  2. Verify that report actions are shown and Keep this one is not shown.
  3. Select an expense. On a wide layout, check its checkbox. On a narrow layout, long press the expense and choose Select.
  4. Verify that the selection actions show and do not overlap the header.
  5. Clear the selection and open More again.
  6. Verify that the report actions work.

C04 Deleted linked action and safe Back

Precondition: Web only (Chrome or Safari, desktop or mobile browser), because the case needs two browser tabs. A report with one expense whose preview is in its parent chat. Two browser tabs signed in to the same account.

  1. In the first tab, open the message menu on the expense preview and choose Copy link. On a wide layout, right-click the preview. On a narrow layout, long press it.
  2. Open that link in the first tab, then open the report.
  3. In the second tab, delete the expense.
  4. In the first tab, press the back arrow at the top of the report.
  5. Verify that the parent chat opens.

C06 Non-USD business info summary

Precondition: Signed in as an admin of a workspace whose default currency is CAD. In Workflows, turn on Payments and choose Add bank account. Continue to the business info step.

  1. Fill the business info with a Canadian company incorporated in a province, and continue to the confirmation page.
  2. Verify that the incorporation location shows the province name and the country name.
  3. Edit the company so it is incorporated in a country outside the US and Canada.
  4. Verify that the incorporation location shows only the country name.

No new tests are added, because the casts are removed without a behavior change. The existing cleanStaleReportActionBackToParamTest, WorkspaceTagsTest, MoneyReportHeaderActionsPlacementTest and MoneyReportHeaderSelectionModeTest suites cover the changed code.

Offline tests

C05 Multi-level pending feedback and reconnect

Precondition: The workspace from C02, loaded while online.

  1. Go offline.
  2. Open the first list, turn off one tag and go back.
  3. Verify that the first list row is shown greyed out as pending.
  4. Go online.
  5. Verify that the change is kept and the row is no longer greyed out.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screenshots/Videos (9)

C01 desktop

103170-c01d.mp4

C02 desktop

PR-103170-C02-D.mp4

C02 phone-sized

PR-103170-C02-M.mp4

C03 desktop and phone-sized

PR-103170-C03-DM.mp4

C04 desktop

PR-103170-C04-D.mp4

C04 phone-sized

PR-103170-C04-M.mp4

C05 desktop

PR-103170-C05-D.mp4

C05 phone-sized

PR-103170-C05-M.mp4

C06 desktop

103170-C06-desktop.mp4

… navigation

Seatbelt-Operation: fresh-81455935-sign-292d2ecd-a99e-4fb7-ace8-e412313bdd9f
Seatbelt-Operation: empty-81455935-sign-54ee0768-e8ae-4838-9a65-6ac5b12efd07
Seatbelt-Operation: 55691ed8-0690-4024-b3f1-b6921b0018d4
@KJ21-ENG KJ21-ENG changed the title Remove unsafe type assertions from report, bank, navigation, and tag flows [WIP] refactor: narrow report, bank-summary, navigation, and tag types Oct 23, 2026
Seatbelt-Operation: main-20261030-103170-sign-2ae4dc35-cf05-4c44-8a9d-2ffbe58e0cdc
@KJ21-ENG KJ21-ENG changed the title [WIP] refactor: narrow report, bank-summary, navigation, and tag types refactor: narrow report, bank-summary, navigation, and tag types Oct 30, 2026
Resolve the WorkspaceTagsPage conflict from main's file and drop a branch that never runs. Remove
the new test files, which did not cover changed behaviour.
@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...eaderActions/MoneyReportHeaderSecondaryActions.tsx 0.38% <ø> (ø)
...c/pages/inbox/cleanStaleReportActionBackToParam.ts 100.00% <100.00%> (ø)
src/components/MoneyReportHeaderActions/index.tsx 0.00% <0.00%> (ø)
...ount/NonUSD/BusinessInfo/subSteps/Confirmation.tsx 0.00% <0.00%> (ø)
src/pages/workspace/tags/WorkspaceTagsPage.tsx 79.63% <36.36%> (+2.46%) ⬆️
... and 13 files with indirect coverage changes

@KJ21-ENG KJ21-ENG changed the title refactor: narrow report, bank-summary, navigation, and tag types refactor: remove unsafe assertions from report header, business summary, backTo cleanup and tags page Nov 12, 2026
@KJ21-ENG
KJ21-ENG marked this pull request as ready for review November 17, 2026 17:58
@KJ21-ENG
KJ21-ENG requested review from a team as code owners November 17, 2026 17:58
@expensify-chore-bot
expensify-chore-bot Bot requested review from joekaufmanexpensify and situchan and removed request for a team November 17, 2026 17:58
@expensify-chore-bot

Copy link
Copy Markdown

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T18:17:44.339469Z 78e3563 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@expensify-chore-bot
expensify-chore-bot Bot removed the request for review from a team November 17, 2026 17:59
@KJ21-ENG

KJ21-ENG commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor Author

@situchan, could you please review this PR? Merged main at 2e2d83966f90 in 78e35634aaf6.

@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

No product review needed.

@joekaufmanexpensify
joekaufmanexpensify removed their request for review November 17, 2026 22:07
@situchan

situchan commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
test1.mov
test2.mov
test3.mov
test4.mov

@melvin-bot
melvin-bot Bot requested a review from blimpich November 19, 2026 19:38
@blimpich
blimpich merged commit b5f86eb into Expensify:main Nov 19, 2026
37 of 39 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.5.52-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR removes unsafe type assertions without changing user-facing behavior, introducing features, renaming UI elements, or removing beta gates.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants