Skip to content

refactor: remove unsafe assertions from expense, receipt, inbox and empty list components - #103225

Merged
blimpich merged 8 commits into
Expensify:mainfrom
KJ21-ENG:seatbelt-v2/fresh-20261006-10-da435e5d
Nov 19, 2026
Merged

blimpich merged 8 commits into
Expensify:mainfrom
KJ21-ENG:seatbelt-v2/fresh-20261006-10-da435e5d

Conversation

@KJ21-ENG

@KJ21-ENG KJ21-ENG commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Remove four unsafe as casts from expense, receipt, inbox and empty list components.

  • DistanceRequestRenderItem: the waypoint description key is typed as the two real translation keys (start or stop), so translate() needs no as TranslationPaths.
  • EReceiptWithSizeCalculation: the translateZ0 style type now says its transform is a string, which both platform files already set. The as string is gone.
  • EmptySelectionListContent: the CREATE/SUBMIT check compares the string directly, so the as ContentType type guard is gone.
  • LHNEmptyState: useEmptyLHNIllustration is typed to return icon props, which it always does. The as BlockingViewProps is gone. BlockingView now exports BlockingViewIconProps instead of BlockingViewProps, which nothing else used.

No behavior change.

Changed files
  • src/components/BlockingViews/BlockingView.tsx
  • src/components/DistanceRequest/DistanceRequestRenderItem.tsx
  • src/components/EReceiptWithSizeCalculation.tsx
  • src/components/EmptySelectionListContent.tsx
  • src/components/LHNOptionsList/LHNEmptyState.tsx
  • src/components/LHNOptionsList/useEmptyLHNIllustration/types.ts
  • src/styles/utils/translateZ0/type.ts

Fixed Issues

$ #94739
PROPOSAL: #94739 (comment)

Tests

C01 Per diem receipt preview

Precondition: Web on a desktop browser, because the case needs hover and a resizable window. This case does not apply to Android, iOS or narrow layouts. A Control workspace with Per diem turned on in More features, and at least one per diem rate added with Per diem > Import spreadsheet. One per diem expense on that workspace, created with + > Create expense > Per diem.

  1. Open Spend > Expenses and find the per diem expense.
  2. Hover the expense's receipt cell.
  3. Verify that the generated per diem receipt preview is fully visible, with no clipping, distortion or thin edge line.
  4. Resize the window and hover the receipt cell again.
  5. Verify that the preview stays proportional.

C02 Empty Inbox

Precondition: An account with no unread chats and no to-dos.

  1. Open Inbox, then the Unread tab.
  2. Verify that the fireworks illustration, "No unread chats" and "See all chats" appear.
  3. Press "See all chats".
  4. Verify that the All tab is selected.
  5. Open the To-dos tab.
  6. Verify that the fireworks illustration, "No to-dos" and "See all chats" appear.

C03 Distance waypoint labels

Precondition: None.

  1. Press + > Track distance and open the Map tab.
  2. Verify that the first waypoint is labelled "Start" and the last is labelled "Stop".
  3. Press Add stop and enter three addresses.
  4. Verify that the first waypoint is "Start" and the other two are "Stop".

C04 Empty participant list

Precondition: Signed in.

  1. Press + > Create expense > Manual, enter an amount, then press the Choose recipient row.
  2. In the search box, type a name that matches nobody, for example qqzzxx.
  3. Verify that the list shows the "Submit an expense, refer your team" illustration and text.

No new tests are added, because no behavior changes. tests/ui/LHNItemsPresence.tsx, tests/unit/SidebarLinksTest.tsx and tests/ui/IOURequestStepDistanceTest.tsx render the changed components.

Offline tests

N/A. The change only affects local rendering, with no network, persistence or retry behavior.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screenshots/Videos (5)

C01 desktop

103225-C01-desktop.mp4

C02 desktop

PR-103225-C02-D.mp4

C02 phone-sized

PR-103225-C02-M.mp4

C03 desktop

103225-C04-desktop.mp4

C04 desktop

103225-C05-desktop.mp4

Seatbelt-Operation: e1844e21-3236-4a4c-9ca8-f6a46fbbce19
@melvin-bot

melvin-bot Bot commented Oct 6, 2026

Copy link
Copy Markdown

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@KJ21-ENG KJ21-ENG changed the title Clean up unsafe type assertions in expense and inbox components [WIP] Clean up unsafe type assertions in expense and inbox components Oct 23, 2026
Seatbelt-Operation: main-20261030-103225-sign-c9c98d63-51c8-4a34-82a5-a109799115cc
@KJ21-ENG KJ21-ENG changed the title [WIP] Clean up unsafe type assertions in expense and inbox components Clean up unsafe type assertions in expense and inbox components Oct 30, 2026
Resolve the DistanceRequestRenderItem conflict. Type translateZ0 and the empty state icon at their
source, and remove the new test files, including an impossible malformed-input case.
@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/BlockingViews/BlockingView.tsx 97.61% <ø> (ø)
src/components/EReceiptWithSizeCalculation.tsx 77.77% <100.00%> (+72.22%) ⬆️
src/components/LHNOptionsList/LHNEmptyState.tsx 74.46% <100.00%> (ø)
...ents/DistanceRequest/DistanceRequestRenderItem.tsx 91.42% <75.00%> (ø)
src/components/EmptySelectionListContent.tsx 0.00% <0.00%> (-5.27%) ⬇️
... and 15 files with indirect coverage changes

@KJ21-ENG KJ21-ENG changed the title Clean up unsafe type assertions in expense and inbox components refactor: remove unsafe assertions from expense, inbox and text input components Nov 12, 2026
@KJ21-ENG KJ21-ENG changed the title refactor: remove unsafe assertions from expense, inbox and text input components refactor: remove unsafe assertions from expense, receipt, inbox and empty list components Nov 17, 2026
@KJ21-ENG
KJ21-ENG marked this pull request as ready for review November 17, 2026 17:59
@KJ21-ENG
KJ21-ENG requested review from a team as code owners November 17, 2026 17:59
@expensify-chore-bot
expensify-chore-bot Bot requested review from situchan and removed request for a team November 17, 2026 17:59
@expensify-chore-bot

Copy link
Copy Markdown

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@expensify-chore-bot
expensify-chore-bot Bot requested review from trjExpensify and removed request for a team November 17, 2026 17:59
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T18:16:22.863823Z abcb0a9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@KJ21-ENG

KJ21-ENG commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor Author

@situchan, could you please review this PR? Merged main at 2e2d83966f90 in abcb0a9ca540.

main already removed the TextInputMeasurement cast, so this PR no longer changes that file. The description and tests are updated.

@trjExpensify

Copy link
Copy Markdown
Contributor

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

@trjExpensify
trjExpensify removed their request for review November 18, 2026 01:22
@situchan

situchan commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
test1.mov
test2.mov

@melvin-bot
melvin-bot Bot requested a review from blimpich November 19, 2026 18:07
@blimpich
blimpich merged commit 79d0036 into Expensify:main Nov 19, 2026
37 of 39 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.5.52-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR only refactors TypeScript types and removes unsafe assertions, without changing user-facing behavior, labels, workflows, or beta availability.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants