Repository navigation
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Reset columns buttonReset columns button
…ble-columns-reset # Conflicts: # src/components/Table/Table.tsx # src/components/Table/TableContext.tsx
Reset columns buttonReset columns button
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ReviewThe change looks correct and is ready to merge. I found no blocking bugs. CI is green except What I checked
Optional suggestion
|
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@Expensify/design I think this one is potentially confusing with the existing "Reset columns" button that exists in the columns menu. 🤔 If we're planning to add a "Reset" for all display options in the popover, I wonder if this is required? There will be this shortcut as well on the table: #103354 |
|
What if we just changed the name to be "Reset column sizes"? That feels more clear to me. I'm not exactly sure what you mean by your comment, but double-clicking to reset a column would indeed reset its size - but I guess you would have to double-click every single column you adjusted to go back to the starting point, which doesn't seem ideal. |
I like this idea 🤷 |
We plan to add a "Reset" button in the |
|
Do others do this. I'm aware the double-click on header which I like, and I see the point of reseting across the board but it just feels a bit weird to have this option so quickly out of the gate!? Another option could be adding it to the freeze menu thing we're doing but that's quickly filling up |
I'd be super down to just consolidate here - this button would reset the visible columns as well as their sizes. That seems like a very simple approach.
Oh that's a good shout. Totally agree, it's getting long, but it does seem quite appropriate there. And I guess we'd only show the row if the column was actually resized, so maybe it won't impact a majority of the cases. |
👀 Is it already a thing, or is it just being worked on at the moment? I can put the button there if you think it's the right place, but to me it feels super intuitive to have that reset in the "Display" pill |
|
I'm aligned with Shawn and Jon here - happy to consolidate or eventually add that option to the Column Context Menu™
Agree with your point about conditionally showing it. Also, another point for the more compact context menu items 🙃😁 |
|
Nice, that works for me - down to start with the simple approach of resetting all. |
|
Great! I'll leave the PR in draft until the Freeze menu is implemented then |
|
@war-in I'll ping you in the freeze cols issue once we get it created! |
|
Agree - that looks great! I'm totally onboard starting with just a reset all since you can reset a single column size with a double-click 👍 |
Reset columns buttonReset columns button
|
Closing in favor of #106711, which moves the reset into the column heading menu (Spend first, built on the shared column resize controller so other tables can reuse it). |

Explanation of Change
Adds a "Reset columns" action to the table Display menu, shown only once a column of that table was resized. It drops that table's entry from the
tableColumnWidthsOnyx key, so columns go back to content-sized widths. The Display button now also shows for resized tables with no sortable columns.Fixed Issues
$
PROPOSAL:
Tests
resizableTableColumnsbeta enabled, go to Workspaces > pick a workspace > MembersresizableTableColumnsbeta enabled, widen the "Member" column on a workspace's Members pageOffline tests
resizableTableColumnsbeta enabled, widen the "Member" column on a workspace's Members pageQA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari