Only remove the old export staging directory on iOS by NicolasBonet · Pull Request #103623 · Expensify/App

NicolasBonet · 2026-10-09T17:04:22Z

Explanation of Change

A month after shipping, the MoveFilesOutOfDocuments migration still logs removed the old export staging directory about 100-190 times a day (~1,100 times for ~690 users in the last 8 days), with no downward trend. About 95% of those come from Android, often several times a day for the same user on the same app version.

The cleanup removes ${RNFS.DocumentDirectoryPath}/Expensify. On iOS that is the old Documents/Expensify export staging folder, as intended. On Android, DocumentDirectoryPath is the app's internal files/ directory, and files/Expensify is where the native share intent handler stages files shared into the app (android/app/src/main/java/com/expensify/chat/utils/FileUtils.kt). So on every launch after a share, the migration deleted the staged file, including on a cold-start share where it can run before the share screen reads it. This is one of the causes discussed in #101425.

This change makes the export staging cleanup iOS-only. The other cleanups (attachment cache move, attachment record paths, stale Onyx dump) are unchanged on both platforms.

Fixed Issues

$ #96531 (comment)
PROPOSAL: N/A

Tests

On Android, sign out, then share an image from the gallery to Expensify
Sign in and confirm the share flow still has the image (the file under files/Expensify is not deleted on launch)
Kill and relaunch the app and verify the logs do not contain MoveFilesOutOfDocuments removed the old export staging directory
On iOS, create Documents/Expensify (e.g. via the Files app or by installing an old build and cancelling a CSV export share sheet), relaunch, and verify the folder is removed and the log line appears once

Android emulator results (HybridApp dev build, cold-start share from Google Photos while signed out)

	Before (main)	After (this PR)
Shared image staged at `files/Expensify/share-test.png`	Yes	Yes
`MoveFilesOutOfDocuments removed the old export staging directory` logged	Yes	No
Staged image after startup migrations	Deleted (~20s after the share), while `shareActionHandler` prefs still point at it	Kept
After another cold relaunch without sharing	n/a	Still kept, nothing logged

Before:

t+2s: ls: files/Expensify: No such file or directory
t+3s: share-test.png
...
t+20s: share-test.png
t+21s: ls: files/Expensify: No such file or directory

shareObject: {"content":"/data/user/0/org.me.mobiexpensifyg.dev/files/Expensify/share-test.png","mimeType":"image/png"}

12:38:02.177 I FileUtils: Internal storage directory removed successfully.
12:38:18.199 D ReactNativeJS: [Migrate Onyx] start
12:38:21.868 D ReactNativeJS: [Migrate Onyx] MoveFilesOutOfDocuments removed the old export staging directory
12:38:22.016 D ReactNativeJS: [Migrate Onyx] finished in 3819ms

After:

12:39:25.810 I FileUtils: Internal storage directory removed successfully.
12:40:16.948 D ReactNativeJS: [Migrate Onyx] start
12:40:18.187 D ReactNativeJS: [Migrate Onyx] finished in 1243ms

$ ls -la files/Expensify
-rw------- 1 u0_a228 u0_a228  178 2026-10-09 12:39 share-test.png

shareObject: {"content":"/data/user/0/org.me.mobiexpensifyg.dev/files/Expensify/share-test.png","mimeType":"image/png"}

(FileUtils: Internal storage directory removed is the native share handler clearing previous shares before staging the new file, which is expected.)

Verify that no errors appear in the JS console

Offline tests

N/A, this only runs once at startup and does not depend on the network.

QA Steps

Same as tests (1-3) on Android.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Cold-start share of a receipt image from Google Photos into the app (signed in):

Before (main): the startup migration deletes the staged image, so the share falls back to text and only the Share tab is offered. The message is the internal file path.

before-android-share.mp4

After (this PR): the staged image survives startup, the Submit tab is offered and the receipt shows on the confirmation page.

after-android-share.mp4

On Android, filesDir/Expensify is where the native share intent handler stages files shared into the app, so the cleanup was deleting them.

chatgpt-codex-connector · 2026-10-09T18:52:57Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-09T19:02:59.054370Z	`ed5d979`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

melvin-bot · 2026-10-09T18:53:19Z

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed5d979879

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-09T19:02:56Z

        expect(mockRNFS.unlink).toHaveBeenCalledWith(OLD_EXPORT_STAGING_DIR);
    });

+    it('keeps the Android share staging directory, which uses the same path as the old iOS export staging directory', async () => {


Document the new test's Given/When/Then phases

This newly added test omits the required literal // Given, // When, and // Then comments explaining why its setup, action, and assertion are necessary. Add those three sections so the test complies with the repository's documented testing convention.

AGENTS.md reference: AGENTS.md:L3-L3

Useful? React with 👍 / 👎.

…rt-staging-cleanup

joekaufmanexpensify

Good for product

carlosmiceli · 2026-10-12T19:32:35Z

@NicolasBonet jest test fialing 🙇

…rt-staging-cleanup

github-actions · 2026-10-12T20:27:23Z

🚧 NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-12T20:30:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-12T20:32:32Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103623.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-bf148dd-c15d05c-5c638d8f68d6e750514f8eba0077b3344b1bf8dc/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-bf148dd-c15d05c-38a28dcade59cbbd6782a0c68326f5d9af88b6e5/index.html

Web 🕸️
https://103623.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-13T10:20:20Z

🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.5.8-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-13T10:24:11Z

No help site update needed. This is a bug fix inside a startup migration: on Android it stops deleting files that are shared into the app, so sharing now works the way you'd expect. No article sentence is now wrong, and nothing new is visible to users.

view run

OSBotify · 2026-10-14T12:59:49Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.8-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Only remove the old export staging directory on iOS

ed5d979

On Android, filesDir/Expensify is where the native share intent handler stages files shared into the app, so the cleanup was deleting them.

melvin-bot Bot assigned NicolasBonet Oct 9, 2026

NicolasBonet mentioned this pull request Oct 9, 2026

Stop exposing app data to the iOS Files app #96531

Merged

38 tasks done

NicolasBonet marked this pull request as ready for review October 9, 2026 18:52

NicolasBonet requested review from a team as code owners October 9, 2026 18:52

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team October 9, 2026 18:52

melvin-bot Bot requested review from carlosmiceli and removed request for a team October 9, 2026 18:53

chatgpt-codex-connector Bot reviewed Oct 9, 2026

View reviewed changes

NicolasBonet added 3 commits October 12, 2026 10:48

Merge remote-tracking branch 'origin/main' into nicolas-ios-only-expo…

9ce9686

…rt-staging-cleanup

Document Given/When/Then for the Android share staging test

4efacef

Merge remote-tracking branch 'origin/main' into nicolas-ios-only-expo…

0373478

…rt-staging-cleanup

joekaufmanexpensify approved these changes Oct 12, 2026

View reviewed changes

carlosmiceli approved these changes Oct 12, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into nicolas-ios-only-expo…

06b1112

…rt-staging-cleanup

NicolasBonet merged commit bf148dd into main Oct 12, 2026
41 checks passed

NicolasBonet deleted the nicolas-ios-only-export-staging-cleanup branch October 12, 2026 20:26

OSBotify mentioned this pull request Oct 13, 2026

Deploy Checklist: New Expensify 2026-10-13 #103843

Closed

Pujan92 mentioned this pull request Oct 16, 2026

[Due for payment 2026-10-27] [$175] Native share - File size too large error is not displayed #103662

Closed

1 of 7 tasks

MelvinBot mentioned this pull request Oct 16, 2026

Use a platform shim for the iOS-only export staging cleanup #104268

Merged

1 of 38 tasks

Navigation Menu

Repository navigation

Only remove the old export staging directory on iOS - #103623

Only remove the old export staging directory on iOS#103623
NicolasBonet merged 5 commits into
mainfrom
nicolas-ios-only-export-staging-cleanup

NicolasBonet commented Oct 9, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Oct 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Oct 9, 2026

Uh oh!

joekaufmanexpensify left a comment

Uh oh!

carlosmiceli commented Oct 12, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

OSBotify commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

OSBotify commented Oct 13, 2026

Uh oh!

MelvinBot commented Oct 13, 2026

Uh oh!

OSBotify commented Oct 14, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

NicolasBonet commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

melvin-bot Bot commented Oct 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

carlosmiceli commented Oct 12, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

OSBotify commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

OSBotify commented Oct 13, 2026

Uh oh!

MelvinBot commented Oct 13, 2026

Uh oh!

OSBotify commented Oct 14, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NicolasBonet commented Oct 9, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 9, 2026 •

edited

Loading