Repository navigation
Bump react-native-wallet to 0.1.41 - #103625
Conversation
Use the published wallet fix for retrying enrollment after canceling the Download Wallet prompt. Align npm and iOS lockfiles and pin the Mobile-Expensify submodule to its matching wallet lockfile update. Refs: #102403
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
🚧 francoisl has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…act-native-wallet-0-1-41
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The changes make sense! @dmkt9 could you review? |
…ative-wallet-0-1-41 # Conflicts: # package-lock.json # package.json
|
(Fixed the conflict) |
|
🚧 francoisl has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Changes work good! IMG_3087.MP4IMG_3089.MP4 |
|
Thanks @ZhenjaHorbach ! Could you take over the review here? Since we haven't heard from @dmkt9 since last week. |
|
Sorry for the delay. I've asked @ZhenjaHorbach to help me record some videos, but I'm also fine with @ZhenjaHorbach taking over the final review |
|
Just checked changes between react-native-wallet 0.1.22 and react-native-wallet 0.1.41 @francoisl @MariaHCD |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-10-22.14.42.11.mp4Android: mWeb ChromeiOS: HybridAppIMG_3087.MP4IMG_3089.MP4iOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 MariaHCD has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@francoisl @MariaHCD |
|
🚧 MariaHCD has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Looks like the issue is the MOBILE-EXPENSIFY link in the PR description |
@MelvinBot |
|
Done. I renamed the line in the PR description to:
The build only matches the exact |
|
I will re-run the build 👍🏼 |
|
@MariaHCD |
|
@ZhenjaHorbach do we still need MOBILE_EXPENSIFY_MAIN to be set to true? |
Nah |
|
🚧 MariaHCD has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
hooray! |
|
LGTM! |
Thanks @ZhenjaHorbach! I agree with you, could be an improvement to prioritize the input that is set explicitly when triggering the run. I created an issue here: #104731 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 MariaHCD has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.5.20-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.20-5 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Bump
@expensify/react-native-walletfrom0.1.22to0.1.41to include the merged Apple Wallet cancellation-and-retry fix.The fix clears stale enrollment controllers, to allows users to retry after canceling the Download Wallet prompt without leaving the button loading indefinitely.
Fixed Issues
$ #102403
PROPOSAL: #102403 (comment)
Related Mobile-Expensify PR (already merged): https://github.com/Expensify/Mobile-Expensify/pull/14176
Tests
Same as QA
QA Steps
iOS only
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: Native
See #102403 (comment)