Skip to content

Bump react-native-wallet to 0.1.41 - #103625

Merged
MariaHCD merged 4 commits into
mainfrom
francois-bump-react-native-wallet-0-1-41
Oct 22, 2026
Merged

MariaHCD merged 4 commits into
mainfrom
francois-bump-react-native-wallet-0-1-41

Conversation

@francoisl

@francoisl francoisl commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Bump @expensify/react-native-wallet from 0.1.22 to 0.1.41 to include the merged Apple Wallet cancellation-and-retry fix.

The fix clears stale enrollment controllers, to allows users to retry after canceling the Download Wallet prompt without leaving the button loading indefinitely.

Fixed Issues

$ #102403
PROPOSAL: #102403 (comment)

Related Mobile-Expensify PR (already merged): https://github.com/Expensify/Mobile-Expensify/pull/14176

Tests

Same as QA

  • Verify that no errors appear in the JS console

QA Steps

iOS only

  1. Install the build on a physical iPhone.
  2. Sign in to an account with an assigned virtual card.
  3. Remove the Wallet app from the iPhone.
  4. Open Account > Wallet.
  5. Select the virtual card.
  6. Tap Add to Apple Wallet.
  7. Cancel the Download Wallet prompt.
  8. Confirm the button stops loading.
  9. Tap Add to Apple Wallet again.
  10. Confirm the Download Wallet prompt reappears.
  11. Cancel the prompt again.
  12. Confirm the button stops loading.
  13. Reinstall Wallet.
  14. Add the virtual card to Apple Wallet.
  15. Confirm normal card provisioning completes successfully.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

iOS: Native

See #102403 (comment)

Use the published wallet fix for retrying enrollment after canceling the
Download Wallet prompt. Align npm and iOS lockfiles and pin the
Mobile-Expensify submodule to its matching wallet lockfile update.

Refs: #102403
@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 7 files with indirect coverage changes

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

🚧 francoisl has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@francoisl

This comment has been minimized.

@francoisl
francoisl requested a review from dmkt9 October 9, 2026 21:27
@francoisl
francoisl marked this pull request as ready for review October 9, 2026 21:27
@francoisl
francoisl requested a review from a team as a code owner October 9, 2026 21:27
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T21:31:50.673996Z 848acbc Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from MariaHCD and removed request for a team October 9, 2026 21:27
@melvin-bot

melvin-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

@MariaHCD Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MariaHCD

Copy link
Copy Markdown
Contributor

The changes make sense! @dmkt9 could you review?

@JakubKorytko JakubKorytko mentioned this pull request Oct 12, 2026
36 tasks done
…ative-wallet-0-1-41

# Conflicts:
#	package-lock.json
#	package.json
@francoisl

Copy link
Copy Markdown
Contributor Author

(Fixed the conflict)

@github-actions

Copy link
Copy Markdown
Contributor

🚧 francoisl has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@ZhenjaHorbach

ZhenjaHorbach commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Changes work good!

IMG_3087.MP4
IMG_3089.MP4

@MariaHCD

Copy link
Copy Markdown
Contributor

Thanks @ZhenjaHorbach ! Could you take over the review here? Since we haven't heard from @dmkt9 since last week.

@MariaHCD
MariaHCD requested review from ZhenjaHorbach and removed request for dmkt9 October 20, 2026 08:45
@dmkt9

dmkt9 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Sorry for the delay. I've asked @ZhenjaHorbach to help me record some videos, but I'm also fine with @ZhenjaHorbach taking over the final review

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Just checked changes between react-native-wallet 0.1.22 and react-native-wallet 0.1.41
And we have a few major changes on Android also

@francoisl @MariaHCD
Can we run builds for Android also?

@ZhenjaHorbach

ZhenjaHorbach commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
2026-10-22.14.42.11.mp4
Android: mWeb Chrome
iOS: HybridApp
IMG_3087.MP4
IMG_3089.MP4
iOS: mWeb Safari
MacOS: Chrome / Safari

@github-actions

Copy link
Copy Markdown
Contributor

🚧 MariaHCD has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

@francoisl @MariaHCD
Can we try to run builds with MOBILE_EXPENSIFY_MAIN: true ?

@github-actions

Copy link
Copy Markdown
Contributor

🚧 MariaHCD has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Looks like the issue is the MOBILE-EXPENSIFY link in the PR description
It points to an already merged PR, so the build uses an outdated Mobile-Expensify commit (compileSdk 36)
I will try to remove this to fix the build

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Looks like the issue is the MOBILE-EXPENSIFY link in the PR description It points to an already merged PR, so the build uses an outdated Mobile-Expensify commit (compileSdk 36) I will try to remove this to fix the build

@MelvinBot
Remove this link from the PR description or rename it

@MelvinBot

Copy link
Copy Markdown
Contributor

Done. I renamed the line in the PR description to:

Related Mobile-Expensify PR (already merged): https://github.com/Expensify/Mobile-Expensify/pull/14176

The build only matches the exact MOBILE-EXPENSIFY: <url> prefix (resolveBuildRefs.yml:109). New builds will now use the commit pinned by the App submodule. The rest of the description is unchanged. Re-run the build to pick it up.

@MariaHCD

Copy link
Copy Markdown
Contributor

I will re-run the build 👍🏼

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

@MariaHCD
Let's try again 😁

@MariaHCD

Copy link
Copy Markdown
Contributor

@ZhenjaHorbach do we still need MOBILE_EXPENSIFY_MAIN to be set to true?

@ZhenjaHorbach

ZhenjaHorbach commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

@ZhenjaHorbach do we still need MOBILE_EXPENSIFY_MAIN to be set to true?

Nah
Now the pipeline will use MOBILE_EXPENSIFY main in any case!

@github-actions

Copy link
Copy Markdown
Contributor

🚧 MariaHCD has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

hooray!
But this looks like a bug
Why is the PR description given higher priority than the MOBILE_EXPENSIFY_MAIN input?
The input is set explicitly when triggering the run, so I'd expect it to win 😁

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

LGTM!

@MariaHCD

Copy link
Copy Markdown
Contributor

But this looks like a bug
Why is the PR description given higher priority than the MOBILE_EXPENSIFY_MAIN input?
The input is set explicitly when triggering the run, so I'd expect it to win 😁

Thanks @ZhenjaHorbach! I agree with you, could be an improvement to prioritize the input that is set explicitly when triggering the run. I created an issue here: #104731

@MariaHCD
MariaHCD merged commit 65997b7 into main Oct 22, 2026
51 of 53 checks passed
@MariaHCD
MariaHCD deleted the francois-bump-react-native-wallet-0-1-41 branch October 22, 2026 13:12
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 MariaHCD has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.5.20-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.20-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants