Repository navigation
[NoQA] Mock fetch in CategoryTagPickerAutoFocusTest - #103806
Merged
Merged
Conversation
CategoryPicker and TagPicker send GetPolicyCategories and OpenPolicyTagsPage reads on mount. Without a fetch mock, those reads reach Expo's fetch polyfill, which throws "Request is not defined" under Jest. The read is fire-and-forget, so the rejection is unhandled and fails whichever test is running when it lands. That made this test flaky on main.
francoisl
force-pushed
the
francois-fix-jest
branch
from
October 12, 2026 17:59
cc233af to
a30fcd1
Compare
Merged
38 of 40 tasks
francoisl
marked this pull request as ready for review
October 12, 2026 18:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
No C+ review needed, thanks. |
JS00001
approved these changes
Oct 12, 2026
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
45 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/francoisl in version: 9.5.8-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.8-5 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Mock
fetchinCategoryTagPickerAutoFocusTest. The category and tag pickers send an API request on mount, and without a mock that request throwsRequest is not definedunder Jest, which is currently failingtest (job 3)onmainand on most PRs.According to Opus:
Why it started today
Fixed Issues
$ #103800
Tests
Make sure automated tests pass
QA Steps
No QA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari