Repository navigation
Go straight to the Concierge step when copying workspace settings offline - #103812
Conversation
…line Offline, the CopyPolicySettings request is only queued, so the progress modal's spinner could never finish. Open the modal on the Concierge notification step instead and queue CopyPolicySettings_Notify after the copy, the same as choosing "Let me know when it's done". Co-authored-by: Qichen Zhu <QichenZhu@users.noreply.github.com>
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
| // Step 4: drive currentStep on the COPY_POLICY_SETTINGS key itself. | ||
| // Success intentionally omits this key — the backend transitions the bulk policy | ||
| // copy NVP state to complete, which the UI uses to show the completion modal. | ||
| // Offline, the copy is only queued, so skip the spinner and go straight to the Concierge notification step. |
There was a problem hiding this comment.
"Queued" doesn't explain why we skip the spinner. What matters is that the request is not processed while offline.
There was a problem hiding this comment.
Updated in 29391e1. The comment now gives the real reason:
// Offline, the server can't process the copy until we reconnect, so the spinner would never finish.
// Skip it and go straight to the Concierge notification step.src/libs/actions/Policy/CopyPolicySettings.ts:554-555
There was a problem hiding this comment.
@MelvinBot, the comment is still inaccurate. Don't blame the server.
There was a problem hiding this comment.
Updated in ddb4dd6. The comment now says the request isn't processed while offline:
// Offline, the copy request isn't processed until we reconnect, so the spinner would keep loading.
// Skip it and go straight to the Concierge notification step.src/libs/actions/Policy/CopyPolicySettings.ts:554-555
I made the same fix to the matching test comment in tests/actions/CopyPolicySettingsTest.ts:728.
|
🤖 Web test steps verification results: Copying settings while offline now goes straight to "Concierge will let you know" instead of an endless "Copy in progress..." spinner. Dismiss works, the copy finishes once you're back online, and the online flow still shows "Copy in progress..." first. The tester couldn't read the JS console on web, so step 8 is unverified.
|
Co-authored-by: Qichen Zhu <QichenZhu@users.noreply.github.com>
|
The failing Analysis: Thread report drafts explicitly through the split-transaction update flow merged into Evidence:
Next step: Once someone fixes The other failing checks ( |
Co-authored-by: Qichen Zhu <QichenZhu@users.noreply.github.com>
|
Nothing has changed since my last check, so I still didn't push a fix. The
Next step: Ask The other two failures, |
|
I still didn't push a fix. The The latest run on Thread report drafts explicitly through the split-transaction update flow introduced the break. It is still the latest commit on Next step: Ask
|
|
I still didn't push a fix. Nothing has changed since my first comment.
The fix belongs in a separate PR to |
|
@MelvinBot please merge |
…flineConciergeStep Co-authored-by: Qichen Zhu <QichenZhu@users.noreply.github.com>
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I merged The PR's diff against The Tests and QA sections in the PR body still need your test steps before review. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
good for product
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.9-0 🚀
|
|
No help site update needed. This PR fixes an offline-only loading spinner when you copy workspace settings. The Copy Workspace Settings article doesn't describe the progress modal or offline behavior, and its statement that Concierge confirms when the copy completes is still accurate. |
|
@QichenZhu could you provide the QA steps? |
|
@kavimuru sure.
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.9-4 🚀
Bundle Size Analysis (Sentry): |


















Explanation of Change
When you copy workspace settings while offline, the
CopyPolicySettingsrequest is only queued. The "Copy in progress..." modal waits for the server to setnvp_bulkPolicyCopySettingstocompleteorfailed, which can't happen offline, so the spinner loaded indefinitely.Following Design's direction on the issue, an offline copy now goes straight to the "Concierge will let you know" step:
CopyPolicySettingsConfirmPagepassesisOfflinefromuseNetwork()tocopyPolicySettings.buildCopyPolicySettingsDatasets the optimisticcurrentSteptocompletewhen offline. Online, it staysloading.copyPolicySettingsqueuesCopyPolicySettings_Notifyright after the copy request when offline. This is what "Let me know when it's done" already does, and the sequential queue sends it after the copy request once you reconnect.Online behavior, the optimistic target-workspace updates, and
failureDataare unchanged.Fixed Issues
$ #103297
PROPOSAL: #103297 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari