Repository navigation
Fix content hidden in landscape on Add existing expense, per diem time, and import spreadsheet - #104003
Conversation
…pe on Add existing expense Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…hoose file stay reachable in landscape Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid1.movandroid2.movandroid3.movAndroid: mWeb ChromeiOS: HybridAppios.mp4iOS: mWeb SafariMacOS: Chrome / Safari |
|
Bug: on iOS, footer button bounces when close keyboard. ios-bug.mp4@MelvinBot does this happen in other similar pages? |
|
Yes, it should happen on the similar pages too. Why it bounces (landscape): If the video is portrait: the PR changes nothing there. Both helpers only act in landscape. The fixed footer rising and falling with the keyboard is existing behavior on Possible shared fix (not tested on iOS): in the hook, return Other users of the same patternThese also use
To confirm on a device, dismiss the keyboard in landscape on the approver selection page on |
|
Agree. I reproduced the same behavior on other pages. Out of scope |
|
@Krishna2323 lint is failing |
…ing-expense-landscape-keyboard
|
@JS00001 can you please re-run the failing test? it passes locally |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.10-0 🚀
|
|
No help site update is needed. This PR only fixes the layout so content scrolls and stays visible in landscape mode, which is how users already expect the app to work, and no article sentence becomes incorrect. |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.12-0 🚀
|
|
No help site update is needed. This PR only fixes layout in landscape mode on existing screens, such as making content scroll and keeping inputs visible above the keyboard. It doesn't change any feature names, labels, steps, or workflows that an article describes. |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.12-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixes content that gets hidden or cut off in landscape mode on three screens:
CollapsibleHeaderOnKeyboard) and the footer moves into the list while the keyboard is open in landscape (useShouldFooterBeInsideList). This is the same patternApproverSelectionListandPolicyCommuterExclusionsPageuse.TimePickeris now wrapped in aScrollView, matchingSetTimePage.ScrollView.Fixed Issues
$ #102021
$ #102802
$ #102915
PROPOSAL: N/A
Tests
Add existing expense
Per diem time
Import spreadsheet
Offline tests
Same as tests. These are layout-only changes.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_chrome.mp4
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web_chrome.mp4