Skip to content

Remove Onyx.connect() key ONYXKEYS.COLLECTION.REPORT_ACTIONS in src/libs/OptionsListUtils.ts - part 7 - #104326

Merged
grgia merged 19 commits into
Expensify:mainfrom
truph01:fix/66381-part-7
Nov 13, 2026
Merged

grgia merged 19 commits into
Expensify:mainfrom
truph01:fix/66381-part-7

Conversation

@truph01

@truph01 truph01 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Part of removing the Onyx.connectWithoutView() for ONYXKEYS.COLLECTION.REPORT_ACTIONS (moved from OptionsListUtils into ReportAlternateTextUtils). This PR removes the deprecatedCachedOneTransactionThreadReportIDs usage from the following flows by threading transactionThreadIDs from useSortedReportActionsData() (RAM_ONLY_SORTED_REPORT_ACTIONS) down to resolveLastActionContext:

- resolveLastActionContext -> getAlternateText
- resolveLastActionContext -> getAlternateText -> createOption -> getReportOption
- resolveLastActionContext -> getAlternateText -> createOption -> getReportOption -> getMoneyRequestParticipantOptions
- resolveLastActionContext -> getAlternateText -> createOption -> getReportOption -> buildReportParticipants -> submitCreateWithReport -> submitCreateAmount -> submitAmount
- resolveLastActionContext -> getAlternateText -> createOption -> getReportDisplayOption
- resolveLastActionContext -> getAlternateText -> createOption -> getPolicyExpenseReportOption
- resolveLastActionContext -> getAlternateText -> createOption -> getPolicyExpenseReportOption -> formatSectionsFromSearchTerm
- resolveLastActionContext -> getAlternateText -> createOption -> processReport -> createFilteredOptionList
- resolveLastActionContext -> getAlternateText -> createOption -> buildFullOption -> buildPersonalDetailsOptions -> createFilteredOptionList
- resolveLastActionContext -> getAlternateText -> createOption -> createOptionFromReport
- resolveLastActionContext -> getAlternateText -> createOption -> getUserToInviteOption
- resolveLastActionContext -> getAlternateText -> createOption -> getUserToInviteOption -> filterUserToInvite -> getValidOptions
- resolveLastActionContext -> getAlternateText -> createOption -> getUserToInviteOption -> filterUserToInvite -> getValidOptions -> getSearchOptions
- resolveLastActionContext -> getAlternateText -> createOption -> getUserToInviteOption -> filterUserToInvite -> filterOptions -> filterAndOrderOptions
- resolveLastActionContext -> getAlternateText -> prepareReportOptionsForDisplay -> getValidOptions
- resolveLastActionContext -> getAlternateText -> prepareReportOptionsForDisplay -> getValidOptions -> getSearchOptions

Fixed Issues

$ #66381
PROPOSAL:

Tests

  1. Open the Search router (Cmd+K) with an empty query, and check that the row's preview shows the thread comment with the commenter's name.
  2. Type a query that returns that report from the server (it goes through the SearchAutocompleteList server results), and check the same preview.
  3. Share a file into the app, open the destination picker, and check the same preview there.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include ""[No QA].""

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline tests section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English and follows the appropriate capitalization guidelines.
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used
  • If the PR modifies the UI:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced where applicable.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-10-19.at.11.10.50.mov
Screen.Recording.2026-11-10.at.17.00.39.mov

@truph01
truph01 requested review from a team as code owners October 19, 2026 04:07
@melvin-bot
melvin-bot Bot requested review from DylanDylann and removed request for a team October 19, 2026 04:07
@melvin-bot

melvin-bot Bot commented Oct 19, 2026

Copy link
Copy Markdown

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from dylanexpensify and removed request for a team October 19, 2026 04:07
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T08:49:55.154665Z 1e1abd1 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread src/libs/OptionsListUtils/index.ts Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce120e4267

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/OptionsListUtils/index.ts Resolved

@dylanexpensify dylanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product input not needed

@DylanDylann

Copy link
Copy Markdown
Contributor

Waiting for part 6

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
.../components/Search/FilterComponents/InSelector.tsx 91.89% <ø> (ø)
src/components/Search/SearchAutocompleteList.tsx 91.09% <ø> (ø)
src/libs/OptionsListUtils/index.ts 92.48% <ø> (ø)
src/libs/ReportAlternateTextUtils.ts 92.84% <100.00%> (-0.01%) ⬇️
... and 7 files with indirect coverage changes

@DylanDylann

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 1e1abd1d3b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@DylanDylann

Copy link
Copy Markdown
Contributor

@truph01 The steps check LHN rows, but the LHN doesn't go through this change. SidebarUtils calls getReportAlternateText directly. resolveLastActionContext is only called from OptionsListUtils.getAlternateText, which builds the Search and option-list previews. Could we test the preview line where it's actually built, using a one-transaction expense report whose newest activity is a comment in its transaction thread?

  1. Open the Search router (Cmd+K) with an empty query, and check that the row's preview shows the thread comment with the commenter's name.
  2. Type a query that returns that report from the server (it goes through the SearchAutocompleteList server results), and check the same preview.
  3. Share a file into the app, open the destination picker, and check the same preview there.

Comment thread tests/unit/OptionsListUtilsTest.tsx Outdated
const result = getAlternateText(option, {showChatPreviewLine: true}, buildConfig({transactionThreadIDs: {}}));

// Then the thread comment is not used, because the thread ID is no longer read from a module-level cache
expect(result).not.toContain('thread comment');

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expect(result).not.toContain('thread comment') passes for almost any wrong output: an empty string, the wrong actor prefix, or a fallback like "No activity yet". Could we assert the exact string we expect?

The Then comment ("because the thread ID is no longer read from a module-level cache") is also only half true for this call. getAlternateText passes the same oneTransactionThreadReportID to getReportAlternateText, which still does oneTransactionThreadReportID ?? deprecatedCachedOneTransactionThreadReportIDs[report.reportID]. In this fixture the cache holds '9301', because the reports are set before the actions are merged. So lastAction is parent-only while the message logic still treats the report as one-transaction. That mix is expected until the next part removes the second fallback, but the test should pin the exact output and say which path no longer reads the cache:

// Then the last action comes from the parent report only, because resolveLastActionContext no longer falls back to the module-level cache
expect(result).toBe('<exact expected text>');

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Now asserting the exact output, and the Then comment names resolveLastActionContext as the path that no longer reads the cache. The remaining fallback goes in the next part.

@truph01

truph01 commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

@truph01 The steps check LHN rows, but the LHN doesn't go through this change. SidebarUtils calls getReportAlternateText directly. resolveLastActionContext is only called from OptionsListUtils.getAlternateText, which builds the Search and option-list previews. Could we test the preview line where it's actually built, using a one-transaction expense report whose newest activity is a comment in its transaction thread?

  1. Open the Search router (Cmd+K) with an empty query, and check that the row's preview shows the thread comment with the commenter's name.
  2. Type a query that returns that report from the server (it goes through the SearchAutocompleteList server results), and check the same preview.
  3. Share a file into the app, open the destination picker, and check the same preview there.

@DylanDylann I replaced the Tests section with your Search router, server-results and share-destination steps.

@DylanDylann

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-11-12.at.16.17.14.mov

Comment thread tests/unit/OptionsListUtilsTest.tsx Resolved
@truph01

truph01 commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@DylanDylann All good now!

@melvin-bot
melvin-bot Bot requested a review from grgia November 13, 2026 07:35
@grgia
grgia merged commit 6db8f2c into Expensify:main Nov 13, 2026
37 of 39 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/grgia in version: 9.5.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR refactors how existing search and selection previews retrieve transaction-thread data, without adding a user-facing workflow or making any existing article inaccurate.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants