Repository navigation
Add Pay via ABA option - #104460
Add Pay via ABA option#104460
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
644059b to
fc213e6
Compare
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@arosiclair All yours, I think! |
|
🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.5.41-0 🚀
|
|
Deploy Blocker #107211 was identified to be related to this PR. |
|
This PR failing because of the issue #107211 |
|
@jponikarchuk It looks like you haven't selected the admin's AU bank account as the Default Business Bank Account here (see step 6):
(Sorry, I know the instructions are a bit convoluted for this 😅 ) |
|
@jjcoffee Thanks. It works fine now |
|
This PR failing because of the regression issue #107302 |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |



Explanation of Change
This PR adds a "Pay via ABA" option for admins on AUD workspaces. Choosing the option calls a new BE command which generates an ABA file and marks the reports as paid. If a report has held expenses, we show the usual popup to ask if all expenses should be paid or only unheld and pass that option to BE.
Pay via ABA shows for workspace admins when the workspace’s currency is AUD and has an open AU withdrawal account. It is disabled offline (since we need to be online to download the file), so there is no optimistic data. It shows in all the usual places you can pay:
To work out whether a workspace has an AU withdrawal account (and thus if we should show the ABA option), the app loads it with a new
OpenPaymentMethodscommand when the payment options open (for an AUD workspace only).We also add support for a new flag
isForABA, which indicates accounts that are only for paying via ABA. These are hidden from the business bank account options, because Expensify can’t pay from them directly. This depends on an upcoming backend change, but since nothing has that flag we can safely push it now.Fixed Issues
$ #104144
PROPOSAL: N/A
Tests
Offline tests
Follow the setup in QA steps and have at least one expense from the employee with an AUD bank account.
QA Steps
Setup
globalReimbursementsbeta (follow up to step 4 to check this).globalReimbursementsbeta and cannot use this account. You can try following the alternative steps below instead.762-133, account number01234567, Bank User Identification Number1122, and company nameABA Company(or anything). Accept the terms and submit.762133and account number01234560. Set the bank name toCommonwealth Bankand address to1 George Street, Sydney. You can enter any (sane) details for the account holder. When/if you get the message that the details may be wrong just resubmit the form.Alternative steps for adding an account via Dev Tools:
iframe_withdrawalAccount.POLICY_IDwith the AUD workspace's ID and press enter.Single report
ABA_Report_<reportID>.abadownloads, and that the report shows as paid.Held expenses
Pay via ABAshows up underPaythere.Bulk pay
Pay via ABAis listed.Pay via ABA.ABA_Report_Bulk_<today's date>.abadownloads, that it has a line for each employee, and that both reports show as paid.Pay via ABAdoesn't show as an option.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-app.mov
Android: mWeb Chrome
android-chrome.mov
iOS: Native
ios-app.mov
iOS: mWeb Safari
ios-safari.mov
MacOS: Chrome / Safari
Single report
Screen.Recording.2026-10-22.at.16.59.56.mov
Held expense
Screen.Recording.2026-10-22.at.17.07.40.mov
Search/bulk selection
Screen.Recording.2026-10-22.at.17.12.26.mov