Repository navigation
Add labels to Home Insights widget charts - #104466
luacmartins merged 6 commits into
Conversation
…-insights-chart-labels # Conflicts: # src/components/Charts/BarChart/VerticalBarChartContent.tsx
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 682c5dc296
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
JmillsExpensify
left a comment
There was a problem hiding this comment.
Looks solid to me. Tested really well. Let's address Danny's comments though.
|
@truph01 @dannymcclain all yours |
|
Just need that updated pie/label placement and it's good to go from my perspective! Just a screenshot to review will be fine. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-10-21.at.10.56.27.movAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-10-21.at.10.47.46.mov |
dc3c938
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.5.16-0 🚀
|
|
No help site update is needed: this PR adds name labels and a legend to the Home Insights charts, which is a visual improvement, and no existing article says the charts lack labels or that you must hover to identify a bar or slice. What I checked
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.5.18-0 🚀
|
|
No help site update needed: the Insights articles already describe the bars and donut slices without saying names appear only on hover, so adding labels and a legend makes no existing sentence incorrect. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.18-1 🚀
Bundle Size Analysis (Sentry): |



Explanation of Change
Insightswidget drew its charts without labels, so users had to hover each bar or donut slice to find out what it was.Top spenders,Top merchants,Top categories) now draw each item's name beneath its bar, horizontal and centered, wrapping to two lines with an ellipsis past the second line. The full name stays in the tooltip.Top categoriesdonut gets a legend (color dot plus name, largest slice first) that sits beside the donut when the card is wide enough and stacks beneath it on narrow screens, updating as the card resizes.Fixed Issues
$ #104266
PROPOSAL:
Tests
Offline tests
QA Steps
Insightswidget.Top merchants(orTop categories/Top spenders) in bar view and verify each bar has its name centered beneath it, horizontal, wrapping to two lines with an ellipsis for long names, and that hovering a bar shows the full name.Top categoriesdonut and verify a legend appears (color dot plus category name, largest first) beside the donut on a wide window and stacked beneath it on a narrow window, with the total still centered in the donut.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-10-20.at.16.34.31.mov