Skip to content

Fix web update refresh delays with network-first navigation - #104520

Merged
tylerkaraszewski merged 13 commits into
mainfrom
deetergp/fix-web-update-refresh
Nov 4, 2026
Merged

tylerkaraszewski merged 13 commits into
mainfrom
deetergp/fix-web-update-refresh

Conversation

@deetergp

@deetergp deetergp commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Clicking Refresh page can leave users waiting while the browser downloads an update in the background. This change lets the page reload without waiting for that download to finish.

During an upgrade, the browser waits for the latest app instead of showing the outdated version again after three seconds. Normal page loads can still use the saved app when the connection is slow or unavailable.

The Refresh button also shows that it is working.

The code now lists five packages it uses directly. Those same package versions were already installed as part of the existing build tools.

This change does not address delays in the other error-recovery or Clear cache and restart actions.

Fixed Issues

$ #100437
PROPOSAL:

Tests

Manual testing pending. Local steps (button behavior only; development mode disables the background worker):

  1. Run npm run web from App/.
  2. Open https://dev.new.expensify.com:8082/ in Chrome.
  3. Open the browser's developer console.
  4. Run Onyx.set('updateRequired', true).
  5. Click Refresh page on the Update Required screen.
  6. Verify the app reloads successfully and appUpdateRequired is removed from the address bar.
Screen.Recording.2026-10-28.at.6.17.17.PM.mov
  • Verify that no errors appear in the JS console

Offline tests

  1. Open the deployed test build in Chrome while online.
  2. Wait for activated in Developer Tools > Application > Service Workers.
  3. Select Offline in the Network tab.
  4. Reload the page.
  5. Verify the saved app opens.
  6. Restore connectivity.
  7. Complete the upgrade refresh in QA steps 3–6.
  8. Repeat steps 3–6 to confirm offline refresh still works after upgrading.

QA Steps

Test build URL pending. Use a build with the Onyx console utility enabled.

  1. Open the test build in Windows Chrome.
  2. Wait for activated in Developer Tools > Application > Service Workers.
  3. Open the Console tab.
  4. Run Onyx.set('updateRequired', true).
  5. Click Refresh page.
  6. Verify the app reloads successfully and appUpdateRequired is removed from the address bar.
  7. Select Slow 3G in the Network tab.
  8. Repeat steps 3–6 to verify a slow upgrade does not return to Update Required after three seconds.
  9. Restore connectivity.
  10. Perform the Offline tests.
  11. Repeat on macOS Safari, iOS Safari, and Android Chrome using their developer tools.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

AI Tests

  • Passed: 64 targeted tests; typecheck, changed-file lint, spelling, formatting, and staging build.
  • Passed in automated Chrome/WebKit checks: upgrades taking over three seconds, blocked worker installation, offline fallback, redirects, and URL marker cleanup.
  • Pending: manual testing on the deployed build, high-traffic account testing, real Safari/mobile/PWA checks, and recordings. Local full-repository lint timed out; changed-file lint passed.

Screenshots/Videos

Android: Native

N/A — the changed upgrade and worker code runs on web.

Android: mWeb Chrome

Manual testing and recording pending.

iOS: Native

N/A — the changed upgrade and worker code runs on web.

iOS: mWeb Safari

Manual testing and recording pending.

MacOS: Chrome / Safari

Manual testing and recording pending.

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/AppUpdateURL.ts 100.00% <100.00%> (ø)
src/libs/actions/AppUpdate/updateApp/index.ts 100.00% <100.00%> (+100.00%) ⬆️
src/libs/actions/Session/clearCache/index.ts 0.00% <ø> (ø)
src/libs/actions/UpdateRequired/index.ts 100.00% <100.00%> (ø)
src/setup/platformSetup/index.ts 33.33% <80.00%> (+33.33%) ⬆️
src/pages/ErrorPage/UpdateRequiredView/index.tsx 0.00% <0.00%> (ø)
... and 385 files with indirect coverage changes

@deetergp

deetergp commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor Author

CI triage:

  • Fixed the PR-caused Knip failure in aa0d47b0355: declare web/service-worker.ts as a build entry point in knip.json. Knip now follows its imports instead of reporting the worker and all five Workbox dependencies as unused. Local before/after reports resolve all six findings with zero new findings; formatting and diff checks pass.
  • All eight Jest shards, Bun tests, Storybook tests, typecheck, ESLint, formatting, compiler compliance, and spellcheck passed on the previous head.
  • The Android Release build and iOS Release build fail during AWS remote-cache access with InvalidAccessKeyId: The AWS Access Key Id you provided does not exist in our records. These fail before compilation and need the CI remote-cache credentials corrected.
  • The independent approval check reports zero independent approvals and requires one eligible reviewer.

The Knip rerun now passes in CI. The PR remains a draft.

@deetergp

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T10:21:25.105434Z 73fabf6 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 6ded96fe40

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@deetergp
deetergp marked this pull request as ready for review October 28, 2026 22:06
@deetergp
deetergp requested review from a team as code owners October 28, 2026 22:06
@melvin-bot
melvin-bot Bot requested review from bernhardoj and removed request for a team October 28, 2026 22:06
@melvin-bot

melvin-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from garrettmknight and removed request for a team October 28, 2026 22:06
@deetergp

Copy link
Copy Markdown
Contributor Author

@MelvinBot review this

@MelvinBot

This comment has been minimized.

@deetergp

Copy link
Copy Markdown
Contributor Author

Ready for review

@deetergp
deetergp requested review from a team and removed request for bernhardoj October 29, 2026 01:20
@melvin-bot
melvin-bot Bot requested review from bernhardoj and removed request for a team October 29, 2026 01:20
@melvin-bot

melvin-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@deetergp

deetergp commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

You’re right—that added an unnecessary wait to normal page loads.

I’ve changed it so normal visits open the saved app immediately. Only required updates wait for the latest app from the server. Offline access still works.

I tested this in Chrome and WebKit. Normal visits made no HTML request, and slow updates and offline reloads passed.

The changes are pushed. The test build needs rebuilding before you can check this version.

@bernhardoj

Copy link
Copy Markdown
Contributor

@deetergp can you help rebuild the adhoc?

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

🚧 deetergp has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

Comment thread src/setup/platformSetup/index.ts Resolved
Comment thread tests/unit/serviceWorkerTest.ts Resolved
@bernhardoj

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 73fabf617f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🚧 deetergp has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@deetergp

deetergp commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Updated! New ad hoc built.

@bernhardoj bernhardoj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think good from me!

@melvin-bot
melvin-bot Bot requested a review from tylerkaraszewski November 4, 2026 03:00
@melvin-bot

melvin-bot Bot commented Nov 4, 2026

Copy link
Copy Markdown

@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@tylerkaraszewski

tylerkaraszewski commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@tylerkaraszewski
tylerkaraszewski merged commit aaa564f into main Nov 4, 2026
56 of 59 checks passed
@tylerkaraszewski
tylerkaraszewski deleted the deetergp/fix-web-update-refresh branch November 4, 2026 20:54
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🚧 tylerkaraszewski has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@OSBotify

OSBotify commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Nov 6, 2026
93 tasks done
@OSBotify

OSBotify commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 9.5.33-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.5.33-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants