Repository navigation
Fix web update refresh delays with network-first navigation - #104520
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
CI triage:
The Knip rerun now passes in CI. The PR remains a draft. |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@MelvinBot review this |
This comment has been minimized.
This comment has been minimized.
|
Ready for review |
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
…te-refresh # Conflicts: # config/eslint/eslint.config.mjs
|
You’re right—that added an unnecessary wait to normal page loads. I’ve changed it so normal visits open the saved app immediately. Only required updates wait for the latest app from the server. Offline access still works. I tested this in Chrome and WebKit. Normal visits made no HTML request, and slow updates and offline reloads passed. The changes are pushed. The test build needs rebuilding before you can check this version. |
|
@deetergp can you help rebuild the adhoc? |
|
🚧 deetergp has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
🚧 deetergp has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Updated! New ad hoc built. |
bernhardoj
left a comment
There was a problem hiding this comment.
I think good from me!
|
@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 tylerkaraszewski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 9.5.33-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.5.33-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Clicking Refresh page can leave users waiting while the browser downloads an update in the background. This change lets the page reload without waiting for that download to finish.
During an upgrade, the browser waits for the latest app instead of showing the outdated version again after three seconds. Normal page loads can still use the saved app when the connection is slow or unavailable.
The Refresh button also shows that it is working.
The code now lists five packages it uses directly. Those same package versions were already installed as part of the existing build tools.
This change does not address delays in the other error-recovery or Clear cache and restart actions.
Fixed Issues
$ #100437
PROPOSAL:
Tests
Manual testing pending. Local steps (button behavior only; development mode disables the background worker):
npm run webfromApp/.https://dev.new.expensify.com:8082/in Chrome.Onyx.set('updateRequired', true).appUpdateRequiredis removed from the address bar.Screen.Recording.2026-10-28.at.6.17.17.PM.mov
Offline tests
QA Steps
Test build URL pending. Use a build with the
Onyxconsole utility enabled.Onyx.set('updateRequired', true).appUpdateRequiredis removed from the address bar.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.AI Tests
Screenshots/Videos
Android: Native
N/A — the changed upgrade and worker code runs on web.
Android: mWeb Chrome
Manual testing and recording pending.
iOS: Native
N/A — the changed upgrade and worker code runs on web.
iOS: mWeb Safari
Manual testing and recording pending.
MacOS: Chrome / Safari
Manual testing and recording pending.