Repository navigation
[Payment due @situchan] Remove victory-native tickCount patch #104659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
roryabraham
merged 26 commits into
Expensify:main
from
s77rt:victory-native-remove-tickCount-patch
Oct 26, 2026
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
a3a7941
fallback tickCount to number of tickValues
s77rt b3c2c02
remove tickCount patch
s77rt 5c46dad
clean up
s77rt efa838b
fix declaration
s77rt 9aa3b76
compensate for padding
s77rt 6bef6ad
fix axisSIze line height
s77rt 5b49826
guard on tickCount
s77rt b757f35
add axis sizes to padding resolver
s77rt c7be0d8
fix overwriting padding
s77rt 811aa94
lint and add comment
s77rt 8e0dc5f
compute lineheight same as victory-native does
s77rt 7cf90da
update golden
s77rt 81e5979
Revert "update golden"
s77rt 964a7c0
Reapply "update golden"
s77rt da138fc
Merge branch 'main' into victory-native-remove-tickCount-patch
s77rt 47c059a
fix typo
s77rt 4ac1006
take axis size into account when computing dynamic height
s77rt 98cb2ef
Merge branch 'main' into victory-native-remove-tickCount-patch
s77rt 8eb0aba
Revert "Reapply "update golden""
s77rt cb95071
fallback tickCount to 0
s77rt 5d576c9
always shrink the left padding - as in main
s77rt d3b4793
apply padding shrink clamp on horizontal charts only
s77rt 31668e1
copy padding
s77rt a16aa25
compute dynamic height using design padding
s77rt 82ac01b
differentiate between left and right axis shrink guard
s77rt 11b8ebe
lint
s77rt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 0 additions & 13 deletions
13
patches/victory-native/victory-native+42.0.1+002+tickCount-4121.patch
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.