Repository navigation
[Payment due @marufsharifi] Warn before saving an agent rule that RuleBot can't carry out #104807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f474cb5
feat(rules): warn before saving an agent rule that RuleBot cannot do
yuwenmemon eada752
refactor(rules): run the agent rule check without the describeRule beta
yuwenmemon 7b65576
chore(rules): merge main and share the offline Try this instead guard
yuwenmemon ad0ad01
fix(rules): stop an agent rule check when the admin edits the text
yuwenmemon 920828c
fix(rules): keep the agent rule check across Write tab switches
yuwenmemon 6a23f67
chore(rules): merge main and use the Use suggestion row on agent rules
yuwenmemon 4cf9558
fix(rules): clear a stale check after reload and block Enter on hidde…
yuwenmemon da048a7
fix(rules): check an edited fallback draft after a reload
yuwenmemon 0cf3e67
Merge remote-tracking branch 'origin/main' into yuwen-683438-agentRul…
yuwenmemon b4fad8e
fix(rules): hide agent rule delete during the save check
yuwenmemon daf3e06
Merge remote-tracking branch 'origin/main' into yuwen-683438-agentRul…
yuwenmemon 219cbed
fix(rules): announce the agent rule check and warning to screen readers
yuwenmemon bb824cd
Merge remote-tracking branch 'origin/main' into yuwen-683438-agentRul…
yuwenmemon 9ff54cd
Merge remote-tracking branch 'origin/main' into yuwen-683438-agentRul…
yuwenmemon 00246e4
Merge remote-tracking branch 'origin/main' into yuwen-683438-agentRul…
yuwenmemon c0a9eeb
fix(rules): stop the agent rule check when the discard prompt opens
yuwenmemon fcabb07
refactor(rules): drop displayName from ImpossibleRuleNotice
yuwenmemon 560f1d2
Merge remote-tracking branch 'origin/main' into yuwen-683438-agentRul…
yuwenmemon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a
finallyDatavalue as well that clears isLoading?