Repository navigation
[No QA] Docs updates for E/A#104518 Rename Travel Invoicing labels in Campfire and DualEntry articles - #104887
Conversation
…fire and DualEntry articles Co-authored-by: Benjamin Limpich <blimpich@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://12ca329b.helpdot.pages.dev ⚡️ Updated articles: |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
HelpDot Documentation ReviewOverall AssessmentThis PR is a targeted terminology rename, updating the deprecated UI label "Travel Invoicing" to "Consolidated Travel Billing" across two accounting connection articles (Campfire and DualEntry). The change aligns the help articles with the current app UI (per PR E/A#104518) and with Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.41-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
[NO QA] Use Consolidated Travel Billing in Campfire and DualEntry settings renamed three Campfire and DualEntry settings from "Travel Invoicing" to "Consolidated Travel Billing". The help articles still named the old labels, so readers looking for them in the app wouldn't find them.
Incorrect sentences:
Configure-Campfire.md: "Sync Travel Invoicing settlements – Create Travel Invoicing settlement payments in Campfire. Choose a Travel Invoicing settlement account and a Travel Invoicing payable account."Configure-DualEntry.md: "Sync Travel Invoicing settlements – Automatically sync Travel Invoicing settlement payments to DualEntry.", plus the Travel Invoicing settlement account and Travel Invoicing payable account bullets.What changed: the app now shows Sync Consolidated Travel Billing settlements, Consolidated Travel Billing settlement account, and Consolidated Travel Billing payable account. This PR updates every old mention in both articles, including the FAQ answers. The new labels match
src/languages/en.tsand the existing Rillet article.@blimpich, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #104518
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari