Skip to content

[No QA] Docs updates for E/A#104518 Rename Travel Invoicing labels in Campfire and DualEntry articles - #104887

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-campfireDualEntryTravelBillingDocs
Nov 17, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-campfireDualEntryTravelBillingDocs

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

[NO QA] Use Consolidated Travel Billing in Campfire and DualEntry settings renamed three Campfire and DualEntry settings from "Travel Invoicing" to "Consolidated Travel Billing". The help articles still named the old labels, so readers looking for them in the app wouldn't find them.

Incorrect sentences:

  • Configure-Campfire.md: "Sync Travel Invoicing settlements – Create Travel Invoicing settlement payments in Campfire. Choose a Travel Invoicing settlement account and a Travel Invoicing payable account."
  • Configure-DualEntry.md: "Sync Travel Invoicing settlements – Automatically sync Travel Invoicing settlement payments to DualEntry.", plus the Travel Invoicing settlement account and Travel Invoicing payable account bullets.

What changed: the app now shows Sync Consolidated Travel Billing settlements, Consolidated Travel Billing settlement account, and Consolidated Travel Billing payable account. This PR updates every old mention in both articles, including the FAQ answers. The new labels match src/languages/en.ts and the existing Rillet article.

@blimpich, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Fixed Issues

$ #104518
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

…fire and DualEntry articles

Co-authored-by: Benjamin Limpich <blimpich@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Oct 23, 2026
@MelvinBot
MelvinBot requested a review from a team October 23, 2026 17:22
@github-actions github-actions Bot changed the title Docs updates for E/A#104518 Rename Travel Invoicing labels in Campfire and DualEntry articles [No QA] Docs updates for E/A#104518 Rename Travel Invoicing labels in Campfire and DualEntry articles Oct 23, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

@stephanieelliott
stephanieelliott marked this pull request as ready for review November 16, 2026 23:45
@stephanieelliott
stephanieelliott self-requested a review as a code owner November 16, 2026 23:46
@expensify-chore-bot

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @joekaufmanexpensify

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-17T00:46:55.923074Z
We couldn’t complete this review. Comment @codex review to try again.
c20e6e1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@expensify-chore-bot
expensify-chore-bot Bot requested review from joekaufmanexpensify and removed request for a team November 16, 2026 23:46
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR is a targeted terminology rename, updating the deprecated UI label "Travel Invoicing" to "Consolidated Travel Billing" across two accounting connection articles (Campfire and DualEntry). The change aligns the help articles with the current app UI (per PR E/A#104518) and with src/languages/en.ts. The scope is narrow: 6 modified lines total, all within existing advanced-settings bullets and FAQ answers. No structural, heading, or metadata changes are introduced. The diff does exactly what it claims and nothing more.

Scores Summary

  • Readability: 9/10 - The renamed bullets and FAQ sentences remain clear, parallel, and well-formatted. Sentence structure and scannability are unchanged and strong.
  • AI Readiness: 9/10 - The new label is a full, UI-exact feature name used consistently, which improves retrieval precision for the current terminology. The changed lines sit under existing task-based headings with proper hierarchy; nothing in the diff degrades AI readiness.
  • Style Compliance: 10/10 - UI labels are bolded and matched exactly to the app and to en.ts. The new wording is consistent with the already-shipped terminology in the Rillet, Xero, NetSuite, QuickBooks, and Sage Intacct articles, making the help site internally consistent.

Key Findings

  • The rename is applied completely within both files, including the advanced-settings bullets and the "Do I need a bill payment or settlement account?" FAQ answers. No stale "Travel Invoicing" references remain in the changed sections.
  • The new labels ("Sync Consolidated Travel Billing settlements", "Consolidated Travel Billing settlement account", "Consolidated Travel Billing payable account") match the capitalization and bolding conventions and are consistent with the existing fleet of connection articles.
  • The change correctly preserves the surrounding conditional phrasing ("This option only appears when Consolidated Travel Billing is turned on"), which still reads naturally after the swap.
  • No governance violations were introduced by the diff. All changes are label-for-label substitutions in prose, not navigation steps, so cross-linking and navigation rules are unaffected.

Recommendations

  • No blocking issues. The diff is ready from a documentation-quality standpoint.
  • Optional (outside diff scope, do not block): consider whether either article should link to the Consolidated Travel Billing enablement article (as the Rillet/Xero/NetSuite articles do) for reader context on the dependency. This is a nice-to-have, not a requirement, and is unrelated to the rename.

Files Reviewed

  • docs/articles/new-expensify/connections/campfire/Configure-Campfire.md - 2 lines changed; clean label rename, compliant.
  • docs/articles/new-expensify/connections/dualentry/Configure-DualEntry.md - 4 lines changed; clean label rename, compliant.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
stephanieelliott merged commit 7b91850 into main Nov 17, 2026
24 of 25 checks passed
@stephanieelliott
stephanieelliott deleted the claude-campfireDualEntryTravelBillingDocs branch November 17, 2026 00:08
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants