Skip to content

Move Shift+Tab to the previous magic code slot instead of leaving the input - #104955

Merged
NikkiWines merged 4 commits into
mainfrom
claude-magicCodeShiftTabPreviousSlot
Nov 10, 2026
Merged

NikkiWines merged 4 commits into
mainfrom
claude-magicCodeShiftTabPreviousSlot

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

On web, Shift+Tab from a middle magic code slot now moves to the previous slot. Before this change, focus jumped to the footer language selector.

Why it broke: focus-trap listens for keydown on document in the capture phase. The magic code input is one hidden TextInput behind all 6 slots, and it is the first tabbable node in the screen's trap. So focus-trap wraps Shift+Tab to the last tabbable node before React's onKeyPress runs. By then onBlur has already cleared focusedIndex, and the Tab branch in onKeyPress does nothing.

What changed in ValidateCodeInput.tsx:

  • A web-only keydown listener on window in the capture phase. It runs before focus-trap's document listener. It is guarded by typeof document === 'undefined', like the paste listener.
  • It handles only a plain Tab or Shift+Tab (no Alt, Ctrl, or Meta), and only while this hidden input is focused. It checks isFocused(), and on web it also requires document.activeElement to be the input.
  • When the next slot is within 0 .. maxLength - 1, it calls preventDefault() and stopPropagation(), updates a focusedIndexRef, and then calls setInputAndIndex. preventDefault() alone is not enough, because focus-trap's checkKeyNav ignores defaultPrevented. The ref keeps key repeat from applying the same move twice before React re-renders.
  • Shift+Tab on slot 1 and Tab on the last slot are not stopped, so they still leave the field as they do today.
  • The onKeyPress Tab branch is unchanged, so hardware-keyboard Tab on iOS and Android still works. On web, in-range Tab never reaches it.
  • The paste handler's isFocused() check moved into a small isInputFocused helper, so both listeners use it.

Tests: I added tests/ui/ValidateCodeInputTest.tsx. It dispatches native KeyboardEvents that pass through the window capture phase, plus a document capture listener that stands in for focus-trap. The events are dispatched on document.body instead of window: an event dispatched on window never reaches document, so the test could not show that focus-trap is skipped. The tests cover:

  • Shift+Tab and Tab from a middle slot, with the enter digit N of 6 announcement.
  • No preventDefault at slot 1 and at the last slot.
  • Tab while the input is not focused.
  • Key repeat before a re-render.
  • ArrowLeft, ArrowRight, Backspace, and digit entry.

The in-range and key-repeat tests fail on main and pass with this change.

AI tests run locally: the new test passed (7 of 7). npm run typecheck, npm run lint-changed (my files), npm run spell-changed, the React Compiler compliance check, and oxfmt also passed. The Android emulator was unreachable during this run, so I have no device verification yet.

Fixed Issues

$ #104839
PROPOSAL: #104839 (comment)

Tests

Web only. This issue does not apply to mobile platforms.

  1. Sign out and open the magic-code screen.
  2. Focus the code input. Slot 1 is focused.
  3. Press ArrowRight twice, then Shift+Tab.
  4. Verify focus moves to slot 2.
  5. Press Tab.
  6. Verify focus moves to slot 3.
  7. Press ArrowLeft until slot 1 is focused, then press Shift+Tab.
  8. Verify focus leaves the input.
  9. Focus the input again, move to the last slot, and press Tab.
  10. Verify focus leaves the input for the next control.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Web only. This issue does not apply to mobile platforms.

Follow steps 1–10 in the Tests section on the web staging environment.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

… input

Co-authored-by: Roji Philip <rojiphil@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team October 26, 2026 03:35
@melvin-bot melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Oct 26, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch because I don't have push access to your fork.

To take ownership of this branch and push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-magicCodeShiftTabPreviousSlot
git checkout -b claude-magicCodeShiftTabPreviousSlot upstream/claude-magicCodeShiftTabPreviousSlot
git push -u origin claude-magicCodeShiftTabPreviousSlot

Then you can close this PR and open a new one from your fork.

@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/hadTabNavigation.ts 100.00% <100.00%> (+2.63%) ⬆️
src/components/ValidateCodeInput.tsx 89.96% <88.88%> (-0.12%) ⬇️
... and 1471 files with indirect coverage changes

@MelvinBot

MelvinBot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ⚠️ partial

I reached the shared 6-slot magic code input (Profile > Contact methods > New contact method) and confirmed digit entry works. I could not check the Tab, Shift+Tab, arrow key, or Backspace steps, or the JS console, because the web test tool cannot send raw key presses or read console logs. These are tool limits, not product failures.
Security code input with digits 1, 2, 3 filled into three slots

Step Status
Reach a screen with the 6-slot magic code inputProfile > Contact methods > New contact method opened a "Validate your account" screen with the 6-digit security code input. The sign-in page was not used because the test session cannot sign out and back in.
Validate your account screen with 6-slot magic code input
✅
Focus the input and use the arrow keys to focus slot 3Not run. The web test tool cannot send ArrowLeft or ArrowRight key events.
❌
Shift+Tab from slot 3 moves focus to slot 2 without leaving the inputNot run. The tool types "\t" as literal text and cannot send a Shift+Tab key event.
❌
Tab from slot 2 moves focus back to slot 3Not run. The tool cannot send a Tab key event.
❌
Shift+Tab from slot 1 leaves the input to the previous focusable elementNot run. The tool cannot send a Shift+Tab key event.
❌
Tab from slot 6 leaves the input to the next focusable elementNot run. The tool cannot send a Tab key event.
❌
Typing digits fills the slots; ArrowLeft, ArrowRight, and Backspace still workTyping "123" filled three slots with real digits through the input's change handler. ArrowLeft, ArrowRight, and Backspace were not run because they need raw key events.
Security code input with digits 1, 2, 3 filled into three slots
⚠️
No errors related to this change appear in the JS consoleNot run. The tool cannot read console logs on web. No error UI appeared during the run.
❌

The PR's Tests section is still a TODO, so these steps come from the linked issue's reproduction steps and the behavior described in the PR body. The Shift+Tab fix still needs a manual keyboard check on web.


view run · view recording

@MelvinBot

MelvinBot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Android test steps verification results: ⚠️ partial

I reached the shared 6-slot magic code input (Profile > Contact methods > New contact method) and confirmed digit entry and auto-advance work. I could not check the Tab, Shift+Tab, arrow key, or Backspace steps, because the Android test tool cannot send hardware key events. These are tool limits, not product failures.
Slot 1 filled with 1, slot 2 focused after typing a digit

Step Status
Reach a screen with the 6-slot magic code inputSettings > Account > Profile > Contact methods > New contact method opened a "Validate your account" screen with the 6-slot security code input, and the input was focused.
Validate your account screen with 6-slot magic code input, slot 1 focused
✅
Focus the input and use the arrow keys to focus slot 3Not run. The Android test tool cannot send hardware ArrowLeft or ArrowRight key events.
❌
Shift+Tab from slot 3 moves focus to slot 2 without leaving the inputNot run. The tool cannot send a hardware Shift+Tab key event.
❌
Tab from slot 2 moves focus back to slot 3Not run. The tool cannot send a hardware Tab key event.
❌
Shift+Tab from slot 1 does not jump to a wrong slotNot run. The tool cannot send a hardware Shift+Tab key event.
❌
Tab from slot 6 does not jump to a wrong slotNot run. The tool cannot send a hardware Tab key event.
❌
Typing digits fills the slots; ArrowLeft, ArrowRight, and Backspace still workTyping "1" filled slot 1 and moved focus to slot 2. ArrowLeft, ArrowRight, and Backspace were not run because they need hardware key events.
Slot 1 filled with 1, slot 2 focused after typing a digit
⚠️
No errors related to this change appear (no red box or crash)No red box or crash appeared during navigation or digit entry.
✅

The PR's Tests section is still a TODO, so these steps come from the linked issue's reproduction steps and the behavior described in the PR body. The Tab and Shift+Tab behavior still needs a manual check with a hardware keyboard on Android.


view run · view recording

@rojiphil

rojiphil commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Merge with the latest main to resolve conflicts

…TabPreviousSlot

Co-authored-by: Roji Philip <rojiphil@users.noreply.github.com>

# Conflicts:
#	src/components/ValidateCodeInput.tsx
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I merged the latest main into this branch and resolved the conflict (d993b08).

The only conflict was in src/components/ValidateCodeInput.tsx. main replaced the ComponentRef<typeof RNTextInput> cast with the shared isTextInputFocused helper and removed those imports. I dropped this PR's local isInputFocused helper and used isTextInputFocused in both the paste handler and the new Shift+Tab listener. The Shift+Tab behavior is unchanged.

I couldn't run lint, typecheck, or Jest locally in this run, so CI on the new commit is the first check.

@rojiphil

rojiphil commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Merge with the latest main

@rojiphil

rojiphil commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Tidy the tests/QA sections with the following test steps.

Please note that the issue is only applicable for web version and not on mobiles.

Steps:

  1. Sign out and open the magic-code screen.
  2. Focus the code input. Slot 1 is focused.
  3. Press ArrowRight twice, then Shift+Tab.
  4. Verify focus moves to slot 2.
  5. Press Tab.
  6. Verify focus moves to slot 3.
  7. Press ArrowLeft until slot 1 is focused, then press Shift+Tab.
  8. Verify focus leaves the input.
  9. Focus the input again, move to the last slot, and press Tab.
  10. Verify focus leaves the input for the next control.

@rojiphil

rojiphil commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Please mark the PR as ready for review

@rojiphil

rojiphil commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
104955-android-hybrid-001.mp4
Android: mWeb Chrome
104955-mweb-chrome-001.mp4
iOS: HybridApp
104955-ios-hybrid-001.mp4
iOS: mWeb Safari
104955-mweb-safari-001.mp4
MacOS: Chrome / Safari
104955-web-chrome-001.mp4

@MelvinBot
MelvinBot marked this pull request as ready for review November 6, 2026 03:41
@MelvinBot
MelvinBot requested a review from a team as a code owner November 6, 2026 03:41
@melvin-bot
melvin-bot Bot requested review from rojiphil and removed request for a team November 6, 2026 03:41
@melvin-bot

melvin-bot Bot commented Nov 6, 2026

Copy link
Copy Markdown

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from heyjennahay and removed request for a team November 6, 2026 03:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T03:47:44.316827Z d993b08 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@rojiphil

rojiphil commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Please tick the boxes in the PR Author Checklist section as I have already verified these in PR Reviewer Checklist as a co-author

@rojiphil

rojiphil commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot Address the comment at #104955 (comment)

@rojiphil rojiphil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NikkiWines Changes LGTM and works well too.
Approving for your review. Thanks

@melvin-bot
melvin-bot Bot requested a review from NikkiWines November 6, 2026 14:48

@NikkiWines NikkiWines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small thing

}

event.preventDefault();
event.stopPropagation();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When someone clicks the code field and then uses Tab to move between digits, the app doesn’t register that they’ve switched to keyboard navigation. This can affect where focus goes on the next screen. Can we make sure the app registers the Tab press before stopping the event?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. A click clears hadTabNavigation, and stopPropagation() on the window listener then hides the Tab from the document listener in hadTabNavigation.ts, so the next screen does not treat this as keyboard navigation.

The listener has to stay on window, because focus-trap registers on document in componentDidMount. @MelvinBot Let us implement to mark tab navigation before stopping the event.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Web test steps verification results: ❌ fail

Pushed 72dc821f: intercepted Tab presses now mark keyboard navigation before stopping propagation, while retaining the window listener. Browser verification was blocked by a blank page—not a demonstrated regression.
Blank web page at the blocked verification state

Step Status
Middle-slot Tab/Shift+Tab, boundary exit, and next-screen keyboard focusCould not verify because the magic-code input was unavailable.
Blank web page at the blocked verification state
Automated checks passed: all 9 component tests, including two new regression cases; typecheck; targeted lint, spelling, React Compiler, and Storybook smoke test. Full Jest timed out. Change-discovery checks lacked a merge base; formatting verification was blocked.
❌

view run

@rojiphil

Copy link
Copy Markdown
Contributor

@MelvinBot Merge with the latest main

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I couldn’t complete the merge. The shallow checkout lacks shared history with main, and both attempts to fetch more history timed out. No changes were committed or pushed.


view run

Co-authored-by: Roji Philip <rojiphil@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team as a code owner November 10, 2026 12:09
@melvin-bot
melvin-bot Bot requested review from NikkiWines and rojiphil and removed request for a team November 10, 2026 12:10
@melvin-bot

melvin-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

@rojiphil @NikkiWines One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@rojiphil

Copy link
Copy Markdown
Contributor

@MelvinBot Please fix the Oxfmt check failing check

Co-authored-by: Roji Philip <rojiphil@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Fixed and pushed 8e30ed5b—Oxfmt required a blank line between import groups.

Local formatting, lint, spelling, and all 9 component tests pass.


view run

@rojiphil rojiphil left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NikkiWines Changes for #104955 (comment) LGTM.
Approving for your review.

104955-web-chrome-003.mp4

@kacper-mikolajczak

Copy link
Copy Markdown
Contributor

Hi! We are aware Melvin tester runs are failing. Please if you could update this branch to latest main and re-run it - this should resolve the issue. If not, reach out to me directly. Thanks for your patience!

@NikkiWines NikkiWines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NikkiWines
NikkiWines merged commit 7b2f1c2 into main Nov 10, 2026
38 of 40 checks passed
@NikkiWines
NikkiWines deleted the claude-magicCodeShiftTabPreviousSlot branch November 10, 2026 16:19
@github-actions

Copy link
Copy Markdown
Contributor

🚧 NikkiWines has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.5.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No FullStory changes needed — this PR only fixes Tab/Shift+Tab focus navigation in the existing magic-code input and adds regression tests, without introducing new UI, screens, user properties, or sensitive content.


view run

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No help site update needed — this PR restores expected Tab and Shift+Tab navigation within the security code input on web; it adds no new workflow and makes no existing article inaccurate.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants