Repository navigation
[Payment due @daledah] Add Top tags to the Insights dashboard - #105096
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d619f4361d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Gonna remove my review here because Tom is heading up the product side of insights. |
|
Updated |
|
The backend intentionally excludes untagged groups, but their spend still counts toward |
…s-rhp-top-tags [Insights polish] Hook Top tags slot into the details RHP
|
What's left to get this one merged? Another review from @daledah and then final review from @aldo-expensify? |
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.5.41-0 🚀
|
|
Help site update needed — this adds a new, non-beta-gated tag-spending visualization and level-selection workflow, which belongs in the existing Insights articles. No docs PR created: live UI verification was blocked because the available account has no tagged expenses, so I couldn’t confirm the new labels and controls as required. Verification needs an account with tagged expenses and multi-level tags. |
|
Deploy Blocker #107216 was identified to be related to this PR. |
|
@luacmartins Could we please have this one validated internally due to the complex requirements involved in executing and validating the test steps? |
|
Deploy Blocker #107283 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #107325 |

Explanation of Change
Rank the top five tags at the selected level. Save the level across devices, keep dependent parents distinct, and carry the scope through Search, comparisons, CSV, Home, and Explain. Reuse the grouping menu and existing full tag-list reads. Show a donut for multiple tags and a bar for one result or comparisons.
Deploy in order: https://github.com/Expensify/Auth/pull/26302 → https://github.com/Expensify/Web-Expensify/pull/57975 → this PR. Tag Details and Biggest changes remain outside this update.
Tag-level popup telemetry follows main:
Search-FilterPopupApplySingleSelect→Insights-ControlPopupApply-TagLevel;Search-FilterPopupResetSingleSelect→Insights-ControlPopupReset-TagLevel.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/697454
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Earlier layout reference
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari