Repository navigation
Hide the approver To-do dot when the only submitted child expense is on hold - #105105
stitesExpensify merged 11 commits into
Conversation
…on hold. The attention veto was checking the chat's empty open draft, so a held submitted expense the walk had already excluded still kept the green dot.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ee2b046fe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@neerajbachani, please go through the review comments and either make the changes or reply if you disagree. Also, the workflow is failing. |
…whose transactions have not arrived.
|
@QichenZhu All three Codex comments are addressed in a07703c. Latest main is merged in eb8f9d6. PR is ready for another look, Thanks! |
|
@neerajbachani, a submitter's workspace chat has one report held by the approver and one empty report. This PR shows no badge, but staging shows an Add badge.
|
|
@QichenZhu Fixed. The empty report is a real Add action for the submitter, so a sibling expense held by the approver no longer removes that chip. Screen.Recording.2026-11-10.at.9.15.47.PM.online-video-cutter.com.mp4 |
QichenZhu
left a comment
There was a problem hiding this comment.
@neerajbachani, could you address the comments below at your earliest convenience?
| // (the chat's open draft), so checking only that id would never see the held transactions. Add is not a selected | ||
| // candidate, and the flag is already false when the submitter has an Add action. |
There was a problem hiding this comment.
Add is not a selected candidate, and the flag is already false when the submitter has an Add action.
Don't mention mistakes that were made and then fixed during this PR. Readers only need to know the final state of this PR.
There was a problem hiding this comment.
Updated, thanks
| let childTransactions: Transaction[]; | ||
| if (reportsTransactions) { | ||
| childTransactions = reportsTransactions[iouReport.reportID] ?? []; | ||
| } else { | ||
| // Callers that do not pass a transaction snapshot still resolve holds from the transaction cache. | ||
| // eslint-disable-next-line @typescript-eslint/no-deprecated | ||
| childTransactions = getReportTransactions(iouReport.reportID); | ||
| } |
There was a problem hiding this comment.
Lines 1325 to 1327 in 5a450b9
If you need to use this function, you must explicitly pass the allReportsTransactions parameter. The if/else is not needed, since it just duplicates the logic inside the util.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-native.movAndroid: mWeb Chromeandroid-web.moviOS: HybridAppios-native.moviOS: mWeb Safariios-web.movMacOS: Chrome / Safarimac-web.mov |
|
🚧 stitesExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.5.41-0 🚀
|
|
No help site update needed — this PR fixes an incorrect attention indicator for held expenses, restoring expected behavior without adding a feature or making existing help instructions incorrect. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
The preview walk already drops a fully held submitted expense, then the To-do check falls through to the chat's
iouReportID. On the approver that id is the next open report, which has no held transactions, sohasOutstandingChildRequestalone keeps the green dot with no Approve chip.getIOUReportActionWithBadgenow returnsisBlockedOnlyByHeldReportswhen nothing was selected, at least one loaded child was withheld by the hold check, and no preview was left unresolved. The existing veto ORs that flag in and still leavesiouReportIDalone. An approvable sibling still wins the badge, and an unloaded outstanding sibling still keeps the dot.Fixed Issues
$ #102525
PROPOSAL: #102525 (comment)
Tests
Preconditions:
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-11-03.at.12.19.58.AM.online-video-cutter.com.mp4
Android: mWeb Chrome
Screen.Recording.2026-11-03.at.12.27.38.AM.online-video-cutter.com.mp4
iOS: Native
Screen.Recording.2026-11-02.at.11.55.38.PM.online-video-cutter.com.mp4
iOS: mWeb Safari
Screen.Recording.2026-11-02.at.11.58.48.PM.online-video-cutter.com.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-10-01.at.2.28.16.PM.online-video-cutter.com.mp4