Skip to content

[CP Stg] Settle the Submit via PDF modal promise on dismiss so cleanup runs behind the fading modal - #105222

Merged
roryabraham merged 1 commit into
mainfrom
claude-resolvePDFModalOnDismiss
Oct 28, 2026
Merged

roryabraham merged 1 commit into
mainfrom
claude-resolvePDFModalOnDismiss

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

When you cancel Submit via PDF, the app stops the green "Submitting" animation and retracts the report. Decouple the file download modal from report and Expensify Card logic moved that cleanup to after the modal finished hiding. The header then swapped the animated button for the Submit dropdown on a clear screen. The spinner's exit animation kept it visible beside the new button for about 250ms.

This PR adds an optional shouldResolveOnDismiss prop to FileDownloadModalWrapper (default false). When it's true, handleClose calls resolveModal with the dismiss action right after it hides the modal. Callers then run their cleanup while the modal fades out, so the overlay hides the button swap again. closeModal stays in handleModalHide, so the modal still leaves the stack only after it has finished hiding. closeModal already handles a promise that resolveModal has settled.

ReportPDFDownloadModal passes shouldResolveOnDismiss. ExpensifyCardStatementPDFDownloadModal is unchanged and keeps the after-hide timing.

Fixed Issues

$ #105206
PROPOSAL: #105206 (comment)

Tests

Precondition: Complete onboarding with "Submit expenses to my employer".

  1. Go to the workspace chat.
  2. Create an expense.
  3. Open the expense.
  4. Click the Submit dropdown button.
  5. Click Submit via PDF.
  6. Quickly click outside the Generate PDF modal to dismiss it.
  7. Verify the green loading button disappears and is replaced by the Submit button, and the two buttons are never shown together.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

AI Tests

  • Passed: npm run lint-changed, npm run typecheck, npm run spell-changed, react-compiler-compliance-check check on both changed components.
  • Passed: Jest suites FileDownloadModalWrapperTest, useReportPDFDownloadModalTest, useExpensifyCardStatementPDFDownloadModalTest, useSearchBulkActionsDownloadPDFTest. I added two wrapper tests for shouldResolveOnDismiss and updated the hook test to expect resolution on dismiss.
  • Not run: the full Jest suite and Storybook smoke test. The repo has no prettier npm script. react-compiler-compliance-check check-changed couldn't find the base branch in this environment, so I checked the files directly.
  • Web verification didn't run: the test browser session loaded a blank page before onboarding, so the flow still needs a manual check.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

…hind the fading modal

Co-authored-by: daledah <daledah@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team October 28, 2026 04:30
@melvin-bot melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Oct 28, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-resolvePDFModalOnDismiss
git checkout -b claude-resolvePDFModalOnDismiss upstream/claude-resolvePDFModalOnDismiss
git push -u origin claude-resolvePDFModalOnDismiss

Then you can close this PR and open a new one from your fork.

@MelvinBot

MelvinBot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ⚠️ partial

The PR's Tests section is still a TODO, so I followed the repro steps from the linked issue. Steps 1–5 pass. Step 6 is the dismiss timing check that this PR fixes, and I couldn't run it. In the dev environment, the PDF finished generating almost at once. The browser then opened an unreachable download URL (www.expensify.com.dev) in the same window, and the test session ended. A second attempt couldn't get back into the app, because the tester isn't allowed to reload a session. You still need to check the dismiss behavior by hand.
Browser error page after Submit via PDF navigated away

Step Status
1. Go to the workspace chatOpened the #admins room for the new "Melvin Tester's Workspace" (Submit-type workspace).
Workspace chat open
✅
2. Create a manual expenseCreated a $25.00 expense ("Test Merchant") for Melvin Tester's Workspace. The "Expense added" toast appeared.
✅
3. Open the expense report; the header shows the Submit dropdownThe header showed the green Submit split button with a caret.
Expense report header with Submit split button
✅
4. Open the Submit dropdown; "Submit via PDF" is listedThe dropdown listed "Submit" and "Submit via PDF".
Submit dropdown with Submit via PDF option
✅
5. Click "Submit via PDF"; the Generate PDF modal appearsThe "Generate PDF — Please wait while we generate the PDF." modal appeared with a Cancel button. By the next snapshot, the header already read "Submitted" because the PDF finished almost at once.
✅
6. Click outside to dismiss the modal; the loading button and Submit button never show togetherNot run. Right after the modal appeared, the whole window opened an unreachable download URL (DNS_PROBE_FINISHED_NXDOMAIN on www.expensify.com.dev). This dev-environment download behavior ended the session before the dismiss click.
Browser error page after Submit via PDF navigated away
❌
7. The report stays unsubmitted and the console shows no errorsNot checked, because the app was no longer loaded after step 6.
❌

view run · view recording

@daledah

daledah commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari
web.mov

@daledah

daledah commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot i've completed my checklist, please complete the author checklist and fill the Test + QA Steps section

@daledah

daledah commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot please open this PR

@MelvinBot

MelvinBot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Android test steps verification results: ⚠️ partial

Steps 1–3 pass, but "Submit via PDF" never appeared, so steps 4–7 (the dismiss timing this PR fixes) couldn't run. The test account was already onboarded and had no workspace, so the tester created a regular one. The app only offers "Submit via PDF" on a Submit-type workspace (ReportPrimaryActionUtils.ts:591-593). That type comes from choosing "Submit expenses to my employer" during onboarding. You still need to check the dismiss behavior on Android by hand, with an account onboarded that way.
Submit button with no dropdown caret

Step Status
1. Go to the workspace chatNo workspace existed, so the tester created "Tester's Workspace" and opened its chat, "Tester's expenses".
Workspace chat Tester's expenses open
✅
2. Create a manual expense in the workspace chatCreated manual expenses (for example, "Fourth Merchant" for $20.00). Each one made a new Draft expense report in the chat.
✅
3. Open the expense report; the header shows the Submit buttonThe Draft report header showed a green Submit button next to More.
Draft expense report header showing the Submit button
✅
4. Open the Submit dropdown; "Submit via PDF" is listedThe Submit button had no caret. Tapping it submitted the report right away, or showed the "Missing category" prompt. The More menu had no "Submit via PDF" option either. The tester tried 4 Draft reports. This matches the code: the workspace wasn't Submit-type.
Submit button with no dropdown caret
❌
5. Tap "Submit via PDF"; the Generate PDF modal appears with the green loading buttonNot run, because the option wasn't available (see step 4).
❌
6. Dismiss the modal right away; the loading button and Submit button never show togetherNot run, because the Generate PDF modal never opened.
❌
7. After the dismiss, the report is still unsubmittedNot run, for the same reason.
❌

view run · view recording

@MelvinBot
MelvinBot marked this pull request as ready for review October 28, 2026 05:02
@MelvinBot
MelvinBot requested a review from a team as a code owner October 28, 2026 05:02
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 I marked this PR as ready for review.

The Tests and QA Steps sections still have their TODO placeholders. I can't write those for you because they record manual tests a person ran. Please add your steps before the reviewer starts.


view run

@melvin-bot
melvin-bot Bot requested review from daledah and removed request for a team October 28, 2026 05:02
@melvin-bot

melvin-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown

@daledah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team October 28, 2026 05:02
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T05:05:15.832482Z b426aea Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@daledah

daledah commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot please add the test steps as this issue #105206

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I added the test steps from Green loading button&Submit button are shown together briefly after dismissing download modal to the PR's Tests section. QA Steps now says "Same as tests."

Steps 1–6 copy the issue's repro, starting from the workspace chat. Step 7 checks that the green loading button is replaced by the Submit button, and the two never show together. I left the Offline tests section empty.


view run

@daledah daledah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot
melvin-bot Bot requested a review from roryabraham October 28, 2026 05:26
@roryabraham
roryabraham merged commit be0b357 into main Oct 28, 2026
56 of 58 checks passed
@roryabraham
roryabraham deleted the claude-resolvePDFModalOnDismiss branch October 28, 2026 14:43
@github-actions

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

OSBotify pushed a commit that referenced this pull request Oct 28, 2026
…miss

Settle the Submit via PDF modal promise on dismiss so cleanup runs behind the fading modal

(cherry picked from commit be0b357)

(cherry-picked to staging by roryabraham)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 28, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.5.24-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No help site update is needed. This PR is a bug fix that only changes animation timing when you dismiss the Generate PDF modal, and the Submit via PDF steps in the Submit-Workspace article remain accurate.


view run

@m-natarajan

Copy link
Copy Markdown

@daledah @roryabraham @MelvinBot
Submit via PDF button is not dismissed (Step 7 of test section) when click outside the Generate PDF modal to dismiss it, even successful downloaded modal is displayed. Submit via PDF is dismissed only when tap on it and do not dismiss the Generate PDF modal.
Not sure if this is expected. Could you please clarify?

ScreenRecording_10-28-2026.17-27-30_1.MP4

@MelvinBot

MelvinBot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor Author

This is expected. The PDF had already finished before your click outside took effect. A click outside cancels Submit via PDF only while the modal still shows the "Please wait while we generate the PDF" spinner. After the PDF is ready, closing the modal any way keeps the report submitted. That includes clicking outside, the X, or Cancel.

To test step 7, click outside while the spinner is still showing. Turning on network throttling gives you more time. The green button should go away, the report should go back to draft, and the Submit button should come back.

Why
  • Clicking outside runs the same close handler as the X and Cancel buttons (BaseModal.tsx:215-225).
  • When you close the modal, it checks the PDF status. "Still generating" counts as a cancel. "Ready" or "failed" counts as done (FileDownloadModalWrapper.tsx:36).
  • Submit via PDF retracts the report and stops the animation only on a cancel (SubmitPrimaryAction.tsx:188-196).
  • A closed modal keeps the text it showed when you closed it. So if you saw the success message, the PDF was ready before the close took effect.
  • This PR only changes when the cleanup runs. It now happens while the modal fades out, not after. Whether a click outside closes the modal, and what it does to the report, is the same as before.

I couldn't record this on web. In the test environment, the PDF finishes almost at once, and the download then leaves the app and ends the session.


view run · no recording available

@m-natarajan

Copy link
Copy Markdown

@daledah @roryabraham @MelvinBot
Submit button not coming back for step 7, Can you check the video?

Recording.3745.mp4

@MelvinBot

MelvinBot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor Author

I couldn't open the video here, so I can't confirm what it shows. I also couldn't reproduce step 7 on web, because my test workspace never showed the Submit via PDF option.

The code points to one cause: the PDF finished before your click outside took effect. A click outside retracts the report only while the "Please wait while we generate the PDF" spinner is still showing. If the PDF is ready, or generation fails, closing the modal counts as done. The report then stays submitted, so the Submit button doesn't come back. The same is true on main before this PR.

Two things in your video would confirm this:

  • Did a PDF download, or did the modal show a success or error message before it closed? If so, this is expected.
  • Was the spinner still showing when you clicked outside? If so, this is a bug. Please share the report ID and the test account email so the RetractReport request can be traced.
Why
  • Only the "generating" status counts as a cancel. Ready or failed counts as done (FileDownloadModalWrapper.tsx:36).
  • Submit via PDF stops the animation and retracts the report only on a cancel (SubmitPrimaryAction.tsx:188-196).
  • The modal downloads the PDF as soon as it's ready (FileDownloadModal.tsx:91-97). A downloaded file means you dismissed it too late.
  • On a cancel, the retract sets the report back to draft, and the Submit button comes back (ReportWorkflow.ts:729-745). This PR changes only when the modal promise settles. Settling on dismiss can't skip the cancel or settle it twice (ModalContext.tsx:99-126).
  • Not checked: whether the server rejected RetractReport. If the spinner was still showing when you dismissed, that's the next thing to check.
  • To test step 7 reliably, turn on network throttling so the spinner stays up longer.

view run · view recording

@m-natarajan

Copy link
Copy Markdown

@MelvinBot Report ID is 1113108217796186 and Account email is mnata.utest+1028rr@gmail.com, Report is still in draft status

Recording.3746.mp4

@roryabraham roryabraham changed the title Settle the Submit via PDF modal promise on dismiss so cleanup runs behind the fading modal [CP Stg] Settle the Submit via PDF modal promise on dismiss so cleanup runs behind the fading modal Oct 28, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Thanks for the details. The report being back in draft means the cancel worked. The retract ran, and so did the animation cleanup.

My best guess is that the Submit button did come back, but with the label "Submit via PDF" instead of "Submit". When you pick Submit via PDF, the app saves it as your preferred submit method for that workspace. Cancelling doesn't reset that preference. The next time the button appears, it shows the saved method. That fits your earlier comment: "Submit via PDF is dismissed only when tap on it."

Can you check whether the green button in your video reads "Submit via PDF"? If it does, this behavior is expected and was already on main before this PR. If the button is missing entirely, that's a bug, so please tell me.

Why
  • Picking Submit via PDF saves the preference before it submits (SubmitPrimaryAction.tsx:239-241). The setting is stored per workspace, and cancelling doesn't roll it back (ReportWorkflow.ts:1365-1370).
  • The dropdown starts on the saved method (SubmitPrimaryAction.tsx:245). The main button shows that option's text (ButtonWithDropdownMenu/index.tsx:107-117).
  • A cancel stops the animation and retracts the report in the same branch (SubmitPrimaryAction.tsx:188-196). A draft report therefore means the animation also stopped, and the Submit dropdown comes back.
  • This PR changes only when that cleanup runs: on dismiss instead of after the modal hides. It doesn't change the button label or the saved preference.
  • Not checked: I couldn't open your video or reach the server logs for report 1113108217796186. If the button is missing, the next step is an internal check of the report's server state.
  • Step 7 currently says the green button is "replaced by the Submit button". If this is expected, the step could say "replaced by the Submit / Submit via PDF button".

view run

@m-natarajan

Copy link
Copy Markdown

@MelvinBot reads "Submit via PDF"

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Thanks for checking. That means step 7 passes. The green "Submit via PDF" button is the Submit button coming back. It shows "Submit via PDF" because it remembers the last submit method you picked for that workspace. The report went back to draft and the loading button went away, so the cancel worked as intended.

The label behavior was already on main before this PR. This PR doesn't change it. To get the plain "Submit" label back, open the caret and choose Submit.

Why

view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.24-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.5.25-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No help site update needed. This PR fixes a brief visual overlap of the Submitting animation and the Submit button when you cancel Submit via PDF. It doesn't change any feature, label, or step that a help article describes.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.25-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants