Repository navigation
[No QA] Prevent duplicate deployment comments after cherry-picks - #105331
Conversation
Exclude PRs already present in the prior release's divergent history. Use the current staging tag instead of persistent CP labels to identify cherry-pick notifications.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
amyevans
left a comment
There was a problem hiding this comment.
Nice improvement, I've definitely found the extra comments a little confusing before!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.27-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.5.27-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Prevent duplicate deployment comments when an original merge commit reaches a release branch after its cherry-pick has already shipped. This caused App PR #105297 to receive a second "Cherry-picked to staging" comment.
CP Staginglabels, or older releases. Share the prior-release tag with the comment action, fetch paginated history once per repository, and preserve each PR's cherry-pick initiator even beneath an unmarked merge or submodule update.AI tests
getDeployPullRequestList.test.ts,markPullRequestsAsDeployed.test.ts,GitUtils.test.ts, andGithubUtils.test.ts. Coverage includes separate initiators for multiple PRs and excludes markers before staging or production release boundaries.npm run lint-changed,npm run spell-changed, scopedoxfmt --check, andnpm run typecheck -- tsconfig.bun.json.9.5.24-8-stagingand excludes it, along with five other already-released App cherry-picks, from9.5.25-0-staging. No comments or deployments were triggered.oxlintmodule. The full action-bundle verifier rebuilds two untouched bundles differently with the shared local dependencies; that unrelated generated churn is excluded. The affected bundles were rebuilt.agents sync --checkpassed from the parent workspace, where the agents configuration lives.Fixed Issues
$
Tests
Added automated tests.
Offline tests
None.
QA Steps
None.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari