Skip to content

[Payment due @gijoe0295] [CFI] Add integration contact method - #105455

Merged
Gonals merged 8 commits into
Expensify:mainfrom
hungvu193:feat-add-integration-contact-method
Nov 17, 2026
Merged

Gonals merged 8 commits into
Expensify:mainfrom
hungvu193:feat-add-integration-contact-method

Conversation

@hungvu193

@hungvu193 hungvu193 commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Add integration logins to our ContactMethod page, so user can revoke any access that they want.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/697632
PROPOSAL: N/A

Tests

  1. Login with any account that has integration login via OAuth.
  2. Go to Profile > Contact Methods
  3. Select the integration that you want to revoke > Remove
  4. Verify that you can remove that integration connection.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as QA steps.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-10-30.at.14.24.54.mov

@melvin-bot

melvin-bot Bot commented Oct 30, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/SENTRY_LABEL.ts 100.00% <ø> (ø)
src/CONST/index.ts 96.03% <ø> (ø)
src/hooks/useAccountIndicatorChecks.ts 100.00% <100.00%> (ø)
src/libs/UserUtils.ts 86.23% <100.00%> (+2.19%) ⬆️
...c/pages/settings/Security/DeviceManagementPage.tsx 0.00% <ø> (ø)
src/selectors/Credentials.ts 100.00% <100.00%> (ø)
...ofile/Contacts/DynamicContactMethodDetailsPage.tsx 60.99% <80.00%> (+0.40%) ⬆️
src/pages/settings/Profile/ProfilePage.tsx 94.67% <75.00%> (-0.51%) ⬇️
...c/pages/settings/useInitialSettingsPageMenuData.ts 87.59% <80.00%> (-0.38%) ⬇️
...ngs/Profile/Contacts/DynamicContactMethodsPage.tsx 78.72% <57.14%> (-3.78%) ⬇️
... and 1 more
... and 7 files with indirect coverage changes

@hungvu193 hungvu193 changed the title Add integration contact method [CFI] Add integration contact method Oct 30, 2026
@hungvu193 hungvu193 changed the title [CFI] Add integration contact method [Hold][CFI] Add integration contact method Oct 30, 2026
@hungvu193
hungvu193 marked this pull request as ready for review November 5, 2026 03:27
@hungvu193
hungvu193 requested review from a team as code owners November 5, 2026 03:27
@melvin-bot
melvin-bot Bot requested review from gijoe0295 and removed request for a team November 5, 2026 03:27
@melvin-bot

melvin-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

@gijoe0295 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team November 5, 2026 03:27
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-05T04:28:34.929954Z
We couldn’t complete this review. Comment @codex review to try again.
b510652 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hungvu193

Copy link
Copy Markdown
Contributor Author

Hi @gijoe0295, are you able to login via integration? cc @trjExpensify I'm not sure if C+ are able to login via integration?

@hungvu193 hungvu193 changed the title [Hold][CFI] Add integration contact method [CFI] Add integration contact method Nov 5, 2026
@gijoe0295

gijoe0295 commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Yes I can't test the flow end-to-end but I can mock the data and review behavior changes. Then Tom can help with QAing. @hungvu193 I'd love if you provided the ONYXKEYS.LOGINS list.

Comment thread src/libs/UserUtils.ts Resolved

@gijoe0295 gijoe0295 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor polishes

@gijoe0295

gijoe0295 commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-11-13.at.23.35.06.mov
Android: mWeb Chrome
iOS: HybridApp
Screen.Recording.2026-11-05.at.23.30.59.mov
iOS: mWeb Safari
Screen.Recording.2026-11-05.at.23.20.26.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-05.at.23.19.16.mov
Screen.Recording.2026-11-09.at.23.43.12.mov

@trjExpensify

Copy link
Copy Markdown
Contributor

Hi @gijoe0295, are you able to login via integration? cc @trjExpensify I'm not sure if C+ are able to login via integration?

I think you can create an IS login for your account. You need to visit this page and generate one: https://www.expensify.com/tools/integrations/

For context, it's how you use our IS API: https://integrations.expensify.com/Integration-Server/doc/#authentication

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these IS OAuth logins come with Integrations label because you mocked the data? For example, for a partner integration using OAuth that will read partnerName? Only the generic partnerUserID and partnerUserSecret will have the header Integrations?

Image

@gijoe0295

Copy link
Copy Markdown
Contributor

For example, for a partner integration using OAuth that will read partnerName? Only the generic partnerUserID and partnerUserSecret will have the header Integrations?

From code changes, yes. We display partnerName if any then generic Integrations which covers the standard partnerUserID + partnerUserSecret login.

@gijoe0295

Copy link
Copy Markdown
Contributor

I created an IS login and re-tested well:

Screen.Recording.2026-11-09.at.23.43.12.mov

@trjExpensify

Copy link
Copy Markdown
Contributor

Cool, thanks for testing.

@hungvu193

Copy link
Copy Markdown
Contributor Author

Catching up from OOO, I'll work on this today

@hungvu193
hungvu193 requested a review from gijoe0295 November 10, 2026 02:57
@hungvu193
hungvu193 force-pushed the feat-add-integration-contact-method branch from 17a086b to 400db5d Compare November 10, 2026 04:50
@hungvu193

Copy link
Copy Markdown
Contributor Author

@MelvinBot Merge main

Co-authored-by: Hans Vu <hungvu193@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor

Merged main into this PR and pushed 558829b. Resolved one conflict while preserving integration-login error handling.

Validation remains incomplete: local lint, typecheck, and targeted tests were blocked by missing dependencies; the compiler check also hit a configuration error.


view run

@gijoe0295 gijoe0295 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checklist #105455 (comment)

@gijoe0295

Copy link
Copy Markdown
Contributor

NAB: Should we show the IS contact method in the Contact methods push row here?

Screenshot 2026-11-13 at 23 25 23

cc @trjExpensify

@melvin-bot
melvin-bot Bot requested a review from Gonals November 13, 2026 16:37
@melvin-bot

melvin-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot changed the title [CFI] Add integration contact method [Payment due @gijoe0295] [CFI] Add integration contact method Nov 13, 2026
@melvin-bot

melvin-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

🎯 @gijoe0295, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/697632.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@trjExpensify

Copy link
Copy Markdown
Contributor

NAB: Should we show the IS contact method in the Contact methods push row here?

Screenshot 2026-11-13 at 23 25 23 cc @trjExpensify

No 👍

@Gonals
Gonals merged commit 84b8220 into Expensify:main Nov 17, 2026
41 of 43 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 Gonals has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@m-natarajan

Copy link
Copy Markdown

@hungvu193 @trjExpensify @Gonals @MelvinBot Is this one internal, Applause don't have credentials for integration login via OAuth.

@MelvinBot

Copy link
Copy Markdown
Contributor

The OAuth-specific end-to-end test needs an internal tester with access to a connected account, given Applause’s credential blocker.

Applause can still test the generic Integration Server login: trjExpensify shared how to generate one, and gijoe0295 confirmed testing it successfully. That covers the generic integration flow, but does not replace OAuth-specific verification.


view run

@trjExpensify

Copy link
Copy Markdown
Contributor

@m-natarajan can you do normal IS per the instructions above?

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Gonals in version: 9.5.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Help site update needed — this adds a new, ungated workflow for revoking API access. Created a draft help site PR with a one-sentence update, labeled HelpDot and assigned to MelvinBot.

@MelvinBot, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run · no recording available

@m-natarajan

Copy link
Copy Markdown

@trjExpensify Created partnerUserID and partnerUserSecret. How to proceed further?

@trjExpensify

Copy link
Copy Markdown
Contributor
  1. Go to NewDot
  2. Go to Account > Profile > Contact Methods
  3. Verify you see the integration log-in there
  4. Click it
  5. Verify you have an option to revoke it
  6. Revoke it
  7. Verify that's successful and the log-in is deleted from your account

@m-natarajan

Copy link
Copy Markdown

Yep, It worked. I was in production before and don't see the integration login there. Passed in Staging. Thanks

Recording.3834.mp4

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@melvin-bot

melvin-bot Bot commented Nov 18, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #107322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants