Repository navigation
[Payment due @gijoe0295] [CFI] Add integration contact method - #105455
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@gijoe0295 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Hi @gijoe0295, are you able to login via integration? cc @trjExpensify I'm not sure if C+ are able to login via integration? |
|
Yes I can't test the flow end-to-end but I can mock the data and review behavior changes. Then Tom can help with QAing. @hungvu193 I'd love if you provided the |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-11-13.at.23.35.06.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-11-05.at.23.30.59.moviOS: mWeb SafariScreen.Recording.2026-11-05.at.23.20.26.movMacOS: Chrome / SafariScreen.Recording.2026-11-05.at.23.19.16.movScreen.Recording.2026-11-09.at.23.43.12.mov |
I think you can create an IS login for your account. You need to visit this page and generate one: https://www.expensify.com/tools/integrations/ For context, it's how you use our IS API: https://integrations.expensify.com/Integration-Server/doc/#authentication |
From code changes, yes. We display |
|
I created an IS login and re-tested well: Screen.Recording.2026-11-09.at.23.43.12.mov |
|
Cool, thanks for testing. |
|
Catching up from OOO, I'll work on this today |
17a086b to
400db5d
Compare
|
@MelvinBot Merge main |
Co-authored-by: Hans Vu <hungvu193@users.noreply.github.com>
|
🎯 @gijoe0295, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
No 👍 |
|
🚧 Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@hungvu193 @trjExpensify @Gonals @MelvinBot Is this one internal, Applause don't have credentials for integration login via OAuth. |
|
The OAuth-specific end-to-end test needs an internal tester with access to a connected account, given Applause’s credential blocker. Applause can still test the generic Integration Server login: |
|
@m-natarajan can you do normal IS per the instructions above? |
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.5.41-0 🚀
|
|
Help site update needed — this adds a new, ungated workflow for revoking API access. Created a draft help site PR with a one-sentence update, labeled @MelvinBot, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR view run · no recording available |
|
@trjExpensify Created partnerUserID and partnerUserSecret. How to proceed further? |
|
|
Yep, It worked. I was in production before and don't see the integration login there. Passed in Staging. Thanks Recording.3834.mp4 |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #107322 |



Explanation of Change
Add integration logins to our ContactMethod page, so user can revoke any access that they want.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/697632
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as QA steps.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-10-30.at.14.24.54.mov