Repository navigation
[Insights: Violations][R3] Add the violation filter - #105466
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
It looks like this PR adds a search filter or column. Please double check the following:
|
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@codex review. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c1a2a2768
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@gijoe0295 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6e10b83f9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Bug: A removed "Is not" value stays in the query (narrow layout only)
Screen.Recording.2026-11-03.at.23.08.38.mov |
gijoe0295
left a comment
There was a problem hiding this comment.
Left some findings above
Maybe we name this for the user with something like "Category differs from default"? @trjExpensify does that sound good? |
|
Yeah, I think for both of these we need to use a message for the rule that was violated otherwise they're really quite pointless for insights. CC: @luacmartins @JS00001 |
|
I just asked @JS00001 about these two as they are related to the new rules engine in active development. I think we should exclude them from the list for now.
|
I didn't know we had a design doc for this. @neil-marcellini Can you please share the doc for my email |
|
@neil-marcellini I just realized that we can still have some violations like |
For now, let's keep the rule-enabled check in place, since that's what Tom and I planned. I think it's okay if there are still live missing category violations, but you can filter expenses by this. At the same time, I'm also okay with getting rid of the check. I don't think it needs to be a blocker. What do you think @trjExpensify? |
|
@neil-marcellini If so it's ready for review again. |
|
Let me know if we need to do this @neil-marcellini |
neil-marcellini
left a comment
There was a problem hiding this comment.
(Neil's AI agent, human reviewed)
Thanks, everything from my last review is done. One change left (inline comment below).
|
@neil-marcellini I've updated. |
|
(Neil's AI agent) I tested this PR on web (Chrome) in Neil's local dev environment at 0d851e1. All test steps pass. Setup: a new Control workspace with Rules on ($50 max expense amount, 30-day max age), and one submitted report with 4 expenses:
Filters (steps 1-6) 1-2. The Violation filter appears. Custom rule violation, Rule violation, and the cash expense notice are not in the list, as intended. 3-4. Selecting both violations returns both violating expenses. 5-6. Search router (steps 7-10)
Notes
|
neil-marcellini
left a comment
There was a problem hiding this comment.
Looks great, thank you. Next time, please make sure you update the test videos. I had Claude do the testing for you, but it did take a while.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here. |
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.5.40-0 🚀
|
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Help site update needed — this adds a new, non-beta violation filter, warranting one row in the existing expense search operators table. No docs PR created: required live UI verification was blocked because the test account lacked Rules-enabled expenses, so labels and filtering behavior could not be confirmed. |
Agree it doesn't need to be a blocker. Weird though.. if Rules is disabled, why are we still flagging categories as required on the workspace? @JmillsExpensify @JS00001 @luacmartins @Krishna2323 that seems like a rules revamp bug. The setting was moved inside the |












Explanation of Change
[Insights: Violations][R3] Add the violation filter
Fixed Issues
$ #105301
PROPOSAL:
Tests
Precondition: Has at least a WS-enabled rules feature and has some submitted expense with violation
Violationfilter appearsviolation:/-violation:, verify that the violation name option appearsOffline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-10-30.at.14.38.18.mov
Android: mWeb Chrome
Screen.Recording.2026-10-30.at.14.39.37.mov
iOS: Native
Screen.Recording.2026-10-30.at.14.40.42.mov
iOS: mWeb Safari
Screen.Recording.2026-10-30.at.14.35.35.mov
MacOS: Chrome / Safari
Screen.Recording.2026-10-30.at.14.49.09.mov