Skip to content

fix: App crashes when opening a transaction from a report preview after restarting the app - #105472

Merged
mountiny merged 4 commits into
Expensify:mainfrom
dmkt9:fix/105394
Nov 19, 2026
Merged

mountiny merged 4 commits into
Expensify:mainfrom
dmkt9:fix/105394

Conversation

@dmkt9

@dmkt9 dmkt9 commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Rspack 2.1.3 drops optional chaining guards from member accesses following inlined require() calls, causing native crashes when imported refs are null.

Enable SWC’s transform-optional-chaining in the native loader to convert optional chains into explicit null checks before Rspack processes them. This fixes affected call sites globally while preserving lazy imports.

Fixed Issues

$ #105394
PROPOSAL:

Tests

Same as QA Steps

  • Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

  1. Open the Android app.
  2. Navigate to a workspace chat containing a report preview.
  3. Fully close the app.
  4. Reopen the app and, within about 2 seconds, tap the report preview card or its View button.
  5. Verify the report opens and the app doesn't crash.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

android.hybrid.mp4

@dmkt9
dmkt9 requested review from a team as code owners October 30, 2026 09:40
@melvin-bot
melvin-bot Bot requested review from marufsharifi and removed request for a team October 30, 2026 09:40
@melvin-bot

melvin-bot Bot commented Oct 30, 2026

Copy link
Copy Markdown

@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested a review from garrettmknight October 30, 2026 09:40
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T09:56:09.796321Z d75188c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot removed the request for review from a team October 30, 2026 09:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d75188c27f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@marufsharifi

marufsharifi commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-11-04.at.7.18.27.PM.mov
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@marufsharifi

Copy link
Copy Markdown
Contributor

@dmkt9, the main flow doesn't work.

Screen_Recording_20261030_155025_Expensify.mp4

@marufsharifi

Copy link
Copy Markdown
Contributor

@dmkt9, could you please add me to the conversation where you have been asked to open a PR for this? I'm a bit confused and would appreciate some additional context. Thanks!

@dmkt9

dmkt9 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

@dmkt9, the main flow doesn't work.

@marufsharifi I'm not sure. You're using the production app in the video, right?

@mountiny Could you please trigger an ad-hoc build for this PR?

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@marufsharifi

Copy link
Copy Markdown
Contributor

@dmkt9, Gentle bump. thanks.

@dmkt9

dmkt9 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

@dmkt9, Gentle bump. thanks.

@marufsharifi you mean this one, right? https://expensify.slack.com/archives/C049HHMV9SM/p1793250635523749

@marufsharifi

Copy link
Copy Markdown
Contributor

@dmkt9, could you please merge the main. thanks.

@marufsharifi

Copy link
Copy Markdown
Contributor

@dmkt9, the bug seems to be fixed on latest main. it is not reproducible for me anymore. could you please check again. thanks.

Screen.Recording.2026-11-04.at.7.35.27.PM.mov

@mountiny

mountiny commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

@marufsharifi we can also monitor sentry if that is the case

@dmkt9

dmkt9 commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

@dmkt9, the bug seems to be fixed on latest main. it is not reproducible for me anymore. could you please check again. thanks.

@marufsharifi Commit bc5e11d made openTransactionFromPreview async, so the error no longer directly causes a crash. However, the error still exists.

We can apply this patch to verify it:

onPreviewPressed={() => {
    openTransactionFromPreview(item).catch((error: unknown) => {
        console.error('openTransactionFromPreview failed', error);
    });
}}

@mountiny Since the fix is quite simple, I still suggest we merge this PR. What do you think?

@mountiny

mountiny commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Hmm so what is the user impact now? Not sure if we need to make any changes if there are no console errors or user facing issues

@marufsharifi

Copy link
Copy Markdown
Contributor

@dmkt9, could you please check: #105472 (comment). thanks.

@dmkt9

dmkt9 commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Hmm so what is the user impact now? Not sure if we need to make any changes if there are no console errors or user facing issues

@mountiny @marufsharifi I am no longer able to reproduce the bug on production

@mountiny

Copy link
Copy Markdown
Contributor

@dmkt9 @marufsharifi can you check if this is still reported in Sentry?

@dmkt9

dmkt9 commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

@dmkt9 @marufsharifi can you check if this is still reported in Sentry?

@mountiny I just saw the crash reported again on Sentry. The root cause is the same, but this time it occurs in openReportFromPreview instead of openTransactionFromPreview. Both use contextMenuRef.current?.isContextMenuOpening, but openReportFromPreview is not an async function.

Our PR patches both places.

const openReportFromPreview = () => {
if (!iouReportID || contextMenuRef.current?.isContextMenuOpening) {
return;
}

@garrettmknight
garrettmknight removed their request for review November 11, 2026 17:34
@mountiny

Copy link
Copy Markdown
Contributor

ok, let move ahead with this pr then

@mkhutornyi

Copy link
Copy Markdown
Contributor

QA steps miss the path that still crashes

On main, openTransactionFromPreview is async, so tapping a transaction no longer crashes. The live crash is in openReportFromPreview, and only before the context menu mounts.

Update QA steps to:

  1. Open the Android app.
  2. Navigate to a workspace chat containing a report preview.
  3. Fully close the app.
  4. Reopen the app and, within about 2 seconds, tap the report preview card or its View button.
  5. Verify the report opens and the app doesn't crash.

@mkhutornyi

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
test1.mov
test2.mov
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@mkhutornyi

Copy link
Copy Markdown
Contributor

Root cause: rspack drops ?. after inlined require() on native

Sentry APP-NHA throws Cannot read property 'isContextMenuOpening' of null at index.tsx:179:29, right after a ReportPreview-Card tap. It happens on iOS too, not only Android. That line already has ?., so the source can't throw this:

if (!iouReportID || contextMenuRef.current?.isContextMenuOpening) {

The ref is null until the lazy context menu mounts (idle callback, up to 2s). The ?. is lost in the native build:

  1. OXC + React Compiler keep contextMenuRef.current?.isContextMenuOpening.
  2. Our inline-requires loader turns it into require("…/ReportActionContextMenu").contextMenuRef.current?.isContextMenuOpening.
    plugins: [inlineInteropRequiresPlugin, inlineRequiresPlugin],
  3. rspack (2.1.3) rewrites the whole require(x).a.b.c chain and drops the optional flag: __webpack_require__(833).U.current.isContextMenuOpening.

A two-file rspack fixture confirms it. require(x).a.b?.c, require(x).a?.b and require(x).a.b?.[k] all throw on null. The same code with an ESM import keeps ?., so web is fine. Native moved to Re.Pack when Metro was removed on Oct 14, which matches first seen in 9.5.18.

About this PR: the local variable works because it ends the require() chain at .current, so the following ?. survives. The comment's explanation (the ref changes during hydration) is wrong, so it should name the real cause.

Wider impact: about 35 named-import optional chains in src lose their null guard on native, e.g. emojiPickerRef.current?., navigationRef?., and contextMenuRef.current?. in AddReactionBubble and QuickEmojiReactions. Each one can crash once its value is null.

Possible Global Fix: handle it once in the build, in the inline-requires loader or with an rspack fix, and report it upstream to rspack, instead of patching call sites.

@mkhutornyi mkhutornyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root cause seems to be in rspack but as long as the fix works, I won't block on this.
We can consider global fix as followup.

@melvin-bot
melvin-bot Bot requested a review from mountiny November 18, 2026 01:10
@dmkt9

dmkt9 commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

@mkhutornyi Thanks for the detailed review. I've switched to using transform-optional-chaining to fix that bug.

@mkhutornyi

Copy link
Copy Markdown
Contributor

Perfect, thanks.

@mountiny all yours

@mountiny

Copy link
Copy Markdown
Contributor

I ran the adhoc for testing

@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@IuliiaHerets

Copy link
Copy Markdown

Regression was completed

No issues were found

@mountiny
mountiny merged commit 5f9b33c into Expensify:main Nov 19, 2026
19 of 20 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.52-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants