Fix Ask Concierge New chat and history link bugs by rushatgabhane · Pull Request #105584 · Expensify/App

rushatgabhane · 2026-11-02T00:42:06Z

Explanation of Change

Concierge threads opened in the Help panel now show the New chat button, and it reopens the panel on a fresh Concierge chat.

When the Concierge chat is already open in the right-hand panel, tapping the thread's header link now jumps to the question in the chat history instead of showing the welcome screen.

When a Concierge thread open in the Help panel disappears after the app reloads its data, the Help panel now goes back to the Concierge chat instead of showing "Hmm... it's not here" and moving the main page to Concierge.

Fixed Issues

$ #105481
$ #105423
$ #105512
$ #105438
$ #105702
PROPOSAL:

Tests

Open Concierge and send a message.
In the thread, open the Help panel and send a message to Concierge.
Verify the thread in the Help panel shows the New chat button.
Click New chat and verify the Help panel shows a new Concierge chat.
Send a task to Concierge with [] task.
Go to Spend > Expenses, filter by Type > Task, and open the task.
Click New chat, send a message to Concierge, then click the header subtitle link.
Verify the Concierge chat history opens on your message, not the welcome screen.
Go to Settings > Preferences and set Priority mode to #focus.
Go to Spend, open the Help panel, ask Concierge a question, and read the reply.
Verify the page stays on Spend and the Help panel shows Concierge, not "Hmm... it's not here".

Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…tory open from the RHP subtitle link

melvin-bot · 2026-11-02T00:42:18Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-11-02T00:42:20Z

Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-11T15:18:46.847985Z	`f45bf24`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

codecov · 2026-11-02T00:45:30Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/pages/inbox/HeaderView.tsx	`96.71% <83.33%> (-0.33%)`	⬇️
src/pages/inbox/ReportNavigateAwayHandler.tsx	`78.01% <85.71%> (-0.35%)`	⬇️
src/components/ParentNavigationSubtitle.tsx	`66.41% <0.00%> (-1.01%)`	⬇️
... and 13 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 954dd05a4e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mkhutornyi · 2026-11-10T17:35:12Z

Please let me know when this followup PR is ready

…k-fixes # Conflicts: # src/pages/inbox/HeaderView.tsx

rushatgabhane · 2026-11-11T15:06:03Z

@mkhutornyi this is ready for your review

mkhutornyi · 2026-11-11T18:10:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

105423.mov

105481.mov

mkhutornyi · 2026-11-11T19:00:54Z

#105512, #105438 are still reproducible. I know there's no code changes in this PR but reporting them since you added these issues to Fixed Issues section

105512-bug.mov

105438-bug.mov

Show New chat in Concierge threads in the Help panel and keep the his…

954dd05

…tory open from the RHP subtitle link

rushatgabhane requested review from a team as code owners November 2, 2026 00:42

melvin-bot Bot requested review from mkhutornyi and removed request for a team November 2, 2026 00:42

melvin-bot Bot requested review from heyjennahay and removed request for a team November 2, 2026 00:42

melvin-bot Bot assigned rushatgabhane Nov 2, 2026

rushatgabhane marked this pull request as draft November 2, 2026 00:46

chatgpt-codex-connector Bot reviewed Nov 2, 2026

View reviewed changes

Comment thread src/pages/inbox/HeaderView.tsx Resolved

rushatgabhane mentioned this pull request Nov 11, 2026

Ask Concierge: one question, one thread #94503

Open

rushatgabhane added 2 commits November 11, 2026 13:54

Keep the main pane in place when the side panel's report is deleted

016864a

Merge remote-tracking branch 'upstream/main' into rushat/concierge-as…

f45bf24

…k-fixes # Conflicts: # src/pages/inbox/HeaderView.tsx

rushatgabhane marked this pull request as ready for review November 11, 2026 15:00

rushatgabhane mentioned this pull request Nov 11, 2026

Ask Concierge: use the same experience in the Concierge side panel and remove side panel special cases #105497

Open

Navigation Menu

Repository navigation

Fix Ask Concierge New chat and history link bugs - #105584

Fix Ask Concierge New chat and history link bugs#105584
rushatgabhane wants to merge 3 commits into
Expensify:mainfrom
rushatgabhane:rushat/concierge-ask-fixes

rushatgabhane commented Nov 2, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Nov 2, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 2, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Nov 2, 2026 •

edited by github-actions Bot

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

mkhutornyi commented Nov 10, 2026

Uh oh!

rushatgabhane commented Nov 11, 2026

Uh oh!

mkhutornyi commented Nov 11, 2026 •

edited

Loading

Uh oh!

mkhutornyi commented Nov 11, 2026 •

edited

Loading

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

rushatgabhane commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 2, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Nov 2, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

mkhutornyi commented Nov 10, 2026

Uh oh!

rushatgabhane commented Nov 11, 2026

Uh oh!

mkhutornyi commented Nov 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mkhutornyi commented Nov 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rushatgabhane commented Nov 2, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Nov 2, 2026 •

edited

Loading

codecov Bot commented Nov 2, 2026 •

edited by github-actions Bot

Loading

mkhutornyi commented Nov 11, 2026 •

edited

Loading

mkhutornyi commented Nov 11, 2026 •

edited

Loading