Repository navigation
104416 workspace chat trip preview shows bookings and their status - #105648
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
…-bookings # Conflicts: # src/libs/TripReservationUtils.ts
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9556826935
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@suneox can you merge main ? there are conflicts. also please fix the codex comments on |
…-bookings # Conflicts: # src/CONST/index.ts # src/components/ReportActionItem/TripRoomPreview.tsx
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 stitesExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.5.40-0 🚀
|
Explanation of Change
Behind the
travelApprovalbeta, the workspace chat's trip preview now lists the trip's bookings instead of its flight legs, as described in the design doc (Release 3, steps 7 and 11). Bookings are what approvers decide on, so the preview shows the same units the trip room and approvals use.Fixed Issues
$ #104416
PROPOSAL:
Tests
Setup: sign in as a user with Expensify Travel trips and turn on the
travelApprovalbeta in Troubleshoot → Beta overrides (it's explicit-only). Until the backend sends approval data, set it on a trip room from the console:Onyx.merge('reportNameValuePairs_<tripRoomReportID>', {tripData: {bookingApprovalState: {'<pnrID>': {status: 'outstanding', approvalType: 'SOFT_APPROVAL', approvalID: '1', approverAccountIDs: [<accountID>]}}}}).PASSIVE_APPROVAL. Verify it has no badge.Offline tests
Same as tests. Review only opens the trip room, so it stays enabled offline, like View.
QA Steps
Enable the
travelApprovalbeta for the account.Test case 1
Test case 2
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Approver
Member
Automation
One booking, no approval dataApprover with an outstanding booking: badge and Review
Someone else on the trip: badge and View
Approved, rejected and canceled badges; no badge for passive




Four bookings
Beta off: unchanged preview