[NOQA] Split receipt capture time into camera and file write by OlimpiaZurek · Pull Request #105754 · Expensify/App

OlimpiaZurek · 2026-11-03T12:17:01Z

Explanation of Change

ManualReceiptCapture measures one block: the camera taking the receipt and the file being written to disk. Since VisionCamera v5, every iOS scan takes a full photo, and iOS capture p95 went from ~210ms to ~630ms. We can't tell from the span whether that time is in the camera or in the file write, and the possible fixes are different for each.

This PR records the two parts separately and adds them to the span:

capture_duration_ms: from the capture call until the camera returns the image (capturePhoto or takeSnapshot)
save_duration_ms: writing that image to disk (saveToFileAsync), not counting the folder creation before it, so photos and snapshots measure the same work

Both capture paths report them: full photos (iOS, Android flash and landscape) and Android snapshots. Nothing changes for the user, and the span starts and ends in the same place.

Both values are measured from JS and rounded to whole milliseconds, so they also include any delay before the JS thread handles the result. That's enough to tell camera time from file time.

Fixed Issues

$ #105823
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

OlimpiaZurek · 2026-11-03T12:24:06Z

@codex review

OlimpiaZurek · 2026-11-03T12:24:15Z

@MelvinBot review

chatgpt-codex-connector · 2026-11-03T12:24:19Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-04T12:15:00.791790Z	`8b1bbad`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

MelvinBot · 2026-11-03T12:26:54Z

Review

The change looks correct and safe. The span still starts and ends in the same place, and the other capturePhotoToPath callers ignore the new fields. CI is green. I found no blocking bugs. Three things are worth a look before merge:

save_duration_ms also counts the folder mkdir on the photo path. saveStartedAt is set before preparePath() runs RNFS.mkdir, so the value is the mkdir round trip plus saveToFileAsync. The PR description says it covers saveToFileAsync only. The snapshot path never calls mkdir, so its save_duration_ms measures different work than the photo path. You can fix this in one of two ways:
- Start the save timer after preparePath resolves.
- Run preparePath before or alongside capturePhoto, which also takes the mkdir off the capture's critical path.
src/libs/cameraCapture/index.ts:36-38
Both timers run on the JS thread. Each one ends when a .then callback runs, not when the native call finishes. If the JS thread is busy right after the tap (haptics, blink), capture_duration_ms grows even though the camera was not slower. This is fine for a first split. Keep it in mind if the numbers don't add up to the native-side picture.
Nits
- The values are sub-millisecond floats (for example, 612.348291). Consider Math.round so Sentry shows clean numbers. index.ts:46-47
- In the tests, nowSpy.mockRestore() runs at the end of each test body, so a failed assertion skips it. The performance.now mock then leaks into later tests (jest.config.js does not set restoreMocks). Move the restore into afterEach or a try/finally. cameraCaptureTest.ts:60, :107
- The PR body still has an empty $ link, empty PROPOSAL:, and the QA TODO. Fill them in, or add [No QA] to the title.

I did not run a web test. This change only touches the native camera path, so a web build can't exercise it.

view run

chatgpt-codex-connector · 2026-11-03T12:38:11Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 747de61ceb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-11-04T11:55:47Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JmillsExpensify

No product review required.

bernhardoj · 2026-11-05T04:53:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

log.mp4

mountiny

Thanks @OlimpiaZurek @bernhardoj

OSBotify · 2026-11-06T00:44:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-11-06T00:51:48Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-11-06T01:06:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #105754 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-25a0815b-934ae34-7789623c811941d390ce0e718863ebe055e4aa7f/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-25a0815b-934ae34-328050423887df590cbf6db20b895cc1b70c1b2d/index.html

Web 🕸️
https://105754.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-11-06T09:10:54Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-11-07T20:57:42Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.5.33-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Split receipt capture time into camera and file write

747de61

melvin-bot Bot assigned OlimpiaZurek Nov 3, 2026

OlimpiaZurek mentioned this pull request Nov 3, 2026

[Metrics] ManualShutterToConfirmation - Optimize "Confirm details" page rendering after receipt capture #83503

Open

mountiny mentioned this pull request Nov 3, 2026

[Due for payment 2026-11-14] [NOQA] Split receipt capture time into camera and file write #105823

Open

Exclude folder creation from the save timer and round capture timings

8b1bbad

OlimpiaZurek marked this pull request as ready for review November 4, 2026 11:55

OlimpiaZurek requested review from a team as code owners November 4, 2026 11:55

melvin-bot Bot requested review from JmillsExpensify and bernhardoj and removed request for a team November 4, 2026 11:55

melvin-bot Bot removed the request for review from a team November 4, 2026 11:55

JmillsExpensify reviewed Nov 4, 2026

View reviewed changes

bernhardoj approved these changes Nov 5, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny November 5, 2026 07:44

mountiny approved these changes Nov 6, 2026

View reviewed changes

mountiny merged commit 25a0815 into Expensify:main Nov 6, 2026
43 of 47 checks passed

OSBotify mentioned this pull request Nov 6, 2026

Deploy Checklist: New Expensify 2026-11-06 #106177

Closed

93 tasks done

Conversation

OlimpiaZurek commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

OlimpiaZurek commented Nov 3, 2026

Uh oh!

OlimpiaZurek commented Nov 3, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

MelvinBot commented Nov 3, 2026

Review

Uh oh!

chatgpt-codex-connector Bot commented Nov 3, 2026

Uh oh!

melvin-bot Bot commented Nov 4, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Nov 6, 2026

Uh oh!

github-actions Bot commented Nov 6, 2026

Uh oh!

github-actions Bot commented Nov 6, 2026

Uh oh!

OSBotify commented Nov 6, 2026

Uh oh!

OSBotify commented Nov 7, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

OlimpiaZurek commented Nov 3, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Nov 3, 2026 •

edited

Loading

bernhardoj commented Nov 5, 2026 •

edited

Loading