perf: Turn off virtual device fusion for iOS receipt captures by OlimpiaZurek · Pull Request #105768 · Expensify/App

OlimpiaZurek · 2026-11-03T14:08:58Z

Explanation of Change

Since VisionCamera v5, every iOS scan takes a full photo, because v5 has no snapshot on iOS. iOS receipt capture p95 went from ~210ms to ~630ms. Most of the slow captures are on iPhone 15 Pro and newer (p95 ~700–830ms, against ~310–370ms on iPhone 14 / 15), and photo resolution doesn't explain it.

We capture with a virtual camera (wide + ultra-wide). VisionCamera only sets isAutoVirtualDeviceFusionEnabled when enableVirtualDeviceFusion is passed, so AVFoundation's default applies: on. With fusion on, iOS can merge frames from several lenses into one photo, which is extra work a flat receipt doesn't need.

This PR turns fusion off on iOS:

captureReceipt/index.ios.ts: enableVirtualDeviceFusion: false on every receipt capture
platformConfig/index.ios.ts: the same field in preparedPhotoSettings, so the plain portrait scan still matches the prepared settings and uses iOS's faster prepared path

Lens switching (for example macro on Pro iPhones) works as before. Android isn't changed.

Fixed Issues

$ #105825
PROPOSAL:

Tests

iOS only:

Scan a receipt in normal light, in dim light and close up. Verify each photo is sharp and readable when zoomed in, and SmartScan reads it correctly.
Scan with flash on and in landscape. Verify the flash fires and the photo shows upright.
Verify a plain scan makes no shutter sound, and a flash scan does unless the phone is muted.
Scan 3 receipts with multi-scan and submit. Verify all 3 expenses are created.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

OlimpiaZurek · 2026-11-03T14:10:23Z

@codex review

OlimpiaZurek · 2026-11-03T14:10:35Z

@MelvinBot review

chatgpt-codex-connector · 2026-11-03T14:10:42Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-04T14:33:02.447599Z	`7393b67`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

MelvinBot · 2026-11-03T14:14:20Z

Review

This looks good to merge. I found no correctness issues. CI passes, including unit tests and typecheck.

These parts check out:

The flag gets applied. In VisionCamera 5.2.3, toAVCapturePhotoSettings sets isAutoVirtualDeviceFusionEnabled only when output.isVirtualDeviceFusionSupported is true. Single-lens iPhones ignore it without an error.
The prepared settings still match. The plain portrait scan sends {flashMode: 'off', enableShutterSound: false, enableVirtualDeviceFusion: false}, and that is exactly what prepareSettings gets. The new test will catch it if the two drift apart.
The photo-upgrade capture isn't affected. usePhotoUpgrade.ts:152 sends the old settings without the fusion flag. That code never runs on iOS, though: shouldTakePhoto() always returns true there, so shouldUpgradeToPhoto is always false.

Suggestions (none blocking):

Show the speedup. The description gives the regression numbers but no numbers with this change. Before/after receipt-capture p95 from an iPhone 15 Pro or newer would confirm fusion caused the slowdown.
Check dim-light scans closely. Fusion can make low-light and close-up shots sharper. Test step 1 covers this. A SmartScan comparison of the same dim receipt on a Pro device would settle it.
Optional follow-up for other cameras. The iOS captures in IOURequestStepOdometerImage/index.native.tsx:211 and AttachmentCamera.tsx:173 still leave fusion on. If the speedup holds, those flat-document captures could turn it off too.

view run

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5117da3a4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-11-03T14:27:52Z

+            // Given the settings iOS prepares ahead of time, which it only reuses for an identical capture
+            const preparedSettings = cameraPlatformConfigIOS.preparedPhotoSettings?.at(0);
+
+            // When a plain portrait scan is captured


Explain why the plain capture is the test action

In the newly added prepared-settings test, this When comment only paraphrases the next captureReceiptIOS call; it never explains why that action is needed (for example, that the plain path is the one whose settings are prewarmed). Reword it to capture that rationale, since this repository requires Given/When/Then comments to explain why the test performs each step.

AGENTS.md reference: AGENTS.md:L93-L93

Useful? React with 👍 / 👎.

melvin-bot · 2026-11-04T12:20:42Z

@TaduJR Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

TaduJR · 2026-11-04T12:30:05Z

Do you need review here @mountiny ?

TaduJR · 2026-11-04T12:35:19Z

Oh i see no c+ was assigned on the issue. Continuing on review then

Its ready right @OlimpiaZurek?

OlimpiaZurek · 2026-11-04T12:40:49Z

Oh i see no c+ was assigned on the issue. Continuing on review then

Its ready right @OlimpiaZurek?

Yes, it's ready for review

TaduJR · 2026-11-04T12:41:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

TaduJR · 2026-11-04T14:14:56Z

@MelvinBot @codex review

chatgpt-codex-connector · 2026-11-04T14:33:00Z

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 7393b6735b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

TaduJR · 2026-11-04T14:53:25Z

Can we get adhoc build here @mountiny?

Thanks!

github-actions · 2026-11-05T05:17:48Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

TaduJR

LGTM!

mountiny

LGTM

OSBotify · 2026-11-06T00:57:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-11-06T01:25:59Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-11-06T01:37:25Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #105768 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c3da8ea7-934ae34-7789623c811941d390ce0e718863ebe055e4aa7f/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c3da8ea7-934ae34-328050423887df590cbf6db20b895cc1b70c1b2d/index.html

Web 🕸️
https://105768.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-11-06T09:11:00Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-11-07T20:57:48Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.5.33-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

perf: Turn off virtual device fusion for iOS receipt captures

c5117da

melvin-bot Bot assigned OlimpiaZurek Nov 3, 2026

chatgpt-codex-connector Bot reviewed Nov 3, 2026

View reviewed changes

OlimpiaZurek mentioned this pull request Nov 3, 2026

[Metrics] ManualShutterToConfirmation - Optimize "Confirm details" page rendering after receipt capture #83503

Open

mountiny mentioned this pull request Nov 3, 2026

perf: Turn off virtual device fusion for iOS receipt captures #105825

Open

Explain why the test uses a plain scan

7393b67

OlimpiaZurek marked this pull request as ready for review November 4, 2026 12:20

OlimpiaZurek requested review from a team as code owners November 4, 2026 12:20

melvin-bot Bot requested review from TaduJR and flaviadefaria and removed request for a team November 4, 2026 12:20

melvin-bot Bot removed the request for review from a team November 4, 2026 12:20

This comment has been minimized.

Sign in to view

TaduJR approved these changes Nov 5, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny November 5, 2026 11:50

mountiny approved these changes Nov 6, 2026

View reviewed changes

mountiny merged commit c3da8ea into Expensify:main Nov 6, 2026
43 of 45 checks passed

OSBotify mentioned this pull request Nov 6, 2026

Deploy Checklist: New Expensify 2026-11-06 #106177

Closed

93 tasks done

Conversation

OlimpiaZurek commented Nov 3, 2026 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

OlimpiaZurek commented Nov 3, 2026

Uh oh!

OlimpiaZurek commented Nov 3, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

MelvinBot commented Nov 3, 2026

Review

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Nov 4, 2026

Uh oh!

TaduJR commented Nov 4, 2026

Uh oh!

TaduJR commented Nov 4, 2026

Uh oh!

OlimpiaZurek commented Nov 4, 2026

Uh oh!

TaduJR commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

TaduJR commented Nov 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 4, 2026

Uh oh!

TaduJR commented Nov 4, 2026

Uh oh!

github-actions Bot commented Nov 5, 2026

Uh oh!

This comment has been minimized.

TaduJR left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Nov 6, 2026

Uh oh!

github-actions Bot commented Nov 6, 2026

Uh oh!

github-actions Bot commented Nov 6, 2026

Uh oh!

OSBotify commented Nov 6, 2026

Uh oh!

OSBotify commented Nov 7, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

OlimpiaZurek commented Nov 3, 2026 •

edited by mountiny

Loading

chatgpt-codex-connector Bot commented Nov 3, 2026 •

edited

Loading

TaduJR commented Nov 4, 2026 •

edited

Loading