Repository navigation
Fix navigation back to contact methods list after validating offline - #105791
carlosmiceli merged 3 commits into
Conversation
…method-stale-list-path
|
@codex review |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@getusha ready for review, thanks |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
|
@getusha friendly bump |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-hb.webmAndroid: mWeb Chromeandroid-11.webmiOS: HybridAppScreen.Recording.iPhone.17.Pro.13-11-2026.at.11.34.37.AM.mp4iOS: mWeb SafariScreen.Recording.iPhone.17.Pro.13-11-2026.at.11.08.33.AM.mp4MacOS: Chrome / SafariScreen.Recording.2026-11-13.at.10.43.40.AM.mov |
|
@MelvinBot @codex review |
|
No actionable findings in the navigation change or regression tests. Validation: All 31 focused unit tests passed, covering contact-method details, dynamic suffix stripping, and back-path handling. Browser behavior was not verified. |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
🚧 carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.5.40-0 🚀
|
|
No help site update needed — this PR fixes navigation after validating a contact method offline, restoring expected behavior without adding a workflow or making existing instructions incorrect. |
Explanation of Change
When a contact method is validated while the details page is covered (e.g. by the Test Preferences modal on reconnect), navigation is deferred until the page regains focus. At that moment
listPathfromuseDynamicBackPathcan still be the path of the modal that was just closed, because the rootstateevent that refreshes it lands one render afterisFocusedflips. So we calledgoBack('test-tools?backTo=...'), which replaced the RHP and left the user on a fresh details page.This PR reads the live route via
Navigation.getActiveRoute()at navigation time and strips the contact method details suffix from it, so both validation navigations always go back to the contact methods list. Added a unit test covering the refocus case.Fixed Issues
$ #104461
PROPOSAL: #104461 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
104461-android-native.mp4
Android: mWeb Chrome
104461-mweb-chrome.mp4
iOS: Native
104461-ios-native.mp4
iOS: mWeb Safari
104461-mweb.mp4
MacOS: Chrome / Safari
104461-web-chrome.mp4