Skip to content

[No QA] Docs updates for E/A#104155 Rename workspace copy option to Expense defaults - #105839

Merged
trjExpensify merged 2 commits into
mainfrom
docs-104155-expense-defaults-copy-label
Nov 11, 2026
Merged

trjExpensify merged 2 commits into
mainfrom
docs-104155-expense-defaults-copy-label

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Update the existing Duplicate Workspace article to match the renamed copy option in Support expense defaults for more than just merchants.

The incorrect item was “Merchant rules” in the instruction “Choose which data and settings to carry over. You can select from:” (article:25–35). The source PR renames the option to “Expense defaults.” Replace only that item, using the exact live-verified label and bold formatting.

AI Tests

  • Live web verification passed after saving one expense default: the feature-selection checkbox reads Expense defaults. Duplication was not completed. The initial empty-workspace check did not show this conditional option.
  • npm run lint-changed: passed; no lintable files changed.
  • npm run spell-changed: passed, no spelling issues.
  • git diff --cached --check: passed.
  • HelpDot and code-review self-checks: no violations on the changed line.
  • Markdown-only edit; application unit tests, type checks, and Docker services are not applicable. No docs routes or configuration changed.

The branch is on upstream because Melvin cannot push to the requester's fork. To take ownership, fetch docs-104155-expense-defaults-copy-label from upstream, push it to your fork, and open a replacement PR.

Fixed Issues

$ #104155
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Initial check without an expense default:

Duplicate workspace feature selection for a Control workspace

Verified after saving an expense default:

Duplicate workspace feature selection showing Expense defaults

@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team November 3, 2026 22:56
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Nov 3, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott
stephanieelliott marked this pull request as ready for review November 10, 2026 23:08
@stephanieelliott
stephanieelliott self-requested a review as a code owner November 10, 2026 23:08
@melvin-bot

melvin-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @trjExpensify

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T23:37:33.585543Z 16ae800 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team November 10, 2026 23:08
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a single, focused change to docs/articles/new-expensify/workspaces/Duplicate-Workspace.md: it renames one item in the "which data and settings to carry over" list from Merchant rules to Expense defaults. This is a UI terminology update to keep the article in sync with the product. The change is verified against the source of truth (src/languages/en.ts contains expenseDefaults: Expense defaults).

Scores Summary

  • Readability: 9/10 - The changed line is clear and consistent with the surrounding list formatting. No readability concerns introduced.
  • AI Readiness: 8/10 - Uses the full, exact feature name that matches the UI, improving semantic retrieval. The change does not affect metadata or headings, which were already in place.
  • Style Compliance: 9/10 - The new label Expense defaults matches src/languages/en.ts exactly (correct sentence case, no synonyms, no paraphrasing), satisfying the Core UI Referencing Rules.

Key Findings

  • Positive: The edit replaces the outdated label with the exact UI string from src/languages/en.ts, which is precisely what the naming conventions require.
  • Positive: Capitalization is correct (sentence case), with no quotation marks or invented synonyms.
  • Minor (pre-existing, outside this diff): The new line drops the two trailing spaces that adjacent list items have. Not blocking, but worth noting for list-rendering consistency.

Recommendations

  • No changes required for this diff. The rename is accurate and compliant.
  • Optional: Align trailing whitespace on the new line with the surrounding list items for consistent Markdown rendering.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Duplicate-Workspace.md - Approved. One-line UI label update (Merchant rules -> Expense defaults), verified against the source of truth.

Note: This PR contains a single-line change, so no additional inline comments were necessary.

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://d93c689b.helpdot.pages.dev ⚡️

Updated articles:

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@trjExpensify
trjExpensify merged commit 09121de into main Nov 11, 2026
24 of 26 checks passed
@trjExpensify
trjExpensify deleted the docs-104155-expense-defaults-copy-label branch November 11, 2026 00:18
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/trjExpensify in version: 9.5.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants