Repository navigation
[No QA] Docs updates for E/A#104155 Rename workspace copy option to Expense defaults - #105839
Conversation
Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a single, focused change to docs/articles/new-expensify/workspaces/Duplicate-Workspace.md: it renames one item in the "which data and settings to carry over" list from Merchant rules to Expense defaults. This is a UI terminology update to keep the article in sync with the product. The change is verified against the source of truth (src/languages/en.ts contains expenseDefaults: Expense defaults). Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This PR contains a single-line change, so no additional inline comments were necessary. |
|
A preview of your ExpensifyHelp changes have been deployed to https://d93c689b.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/trjExpensify in version: 9.5.36-0 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Update the existing Duplicate Workspace article to match the renamed copy option in Support expense defaults for more than just merchants.
The incorrect item was “Merchant rules” in the instruction “Choose which data and settings to carry over. You can select from:” (article:25–35). The source PR renames the option to “Expense defaults.” Replace only that item, using the exact live-verified label and bold formatting.
AI Tests
npm run lint-changed: passed; no lintable files changed.npm run spell-changed: passed, no spelling issues.git diff --cached --check: passed.The branch is on upstream because Melvin cannot push to the requester's fork. To take ownership, fetch
docs-104155-expense-defaults-copy-labelfrom upstream, push it to your fork, and open a replacement PR.Fixed Issues
$ #104155
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Initial check without an expense default:
Verified after saving an expense default:
@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.