Skip to content

Localize abbreviated month and day dates - #105866

Merged
roryabraham merged 6 commits into
Expensify:mainfrom
shubham1206agra:localize-dates-month-day
Nov 10, 2026
Merged

roryabraham merged 6 commits into
Expensify:mainfrom
shubham1206agra:localize-dates-month-day

Conversation

@shubham1206agra

@shubham1206agra shubham1206agra commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Short dates without a year were built from the hand-written date-fns pattern MMM d. The pattern fixes the US order, so other languages showed their own month name in an English shape, for example Juni 20 in German and 6月 20 in Japanese.

date-fns has no localized token for a month and day without a year, so this adds DateUtils.formatToMonthDay, which uses a cached Intl.DateTimeFormat with the app's selected language. DateUtils.formatToMonthDayWithOptionalYearInUTC keeps the existing rule of adding the year only for dates outside the current year, and keeps reading calendar dates as UTC so the day never shifts.

Language Before After
English Jun 20 Jun 20 (unchanged)
German Juni 20 20. Juni
Spanish jun 20 20 jun
Japanese 6月 20 6月20日

Places updated:

  • Search rows: expense and report dates, withdrawal dates
  • Transaction previews and split expense rows
  • Recently added expenses on Home
  • The card authorization transaction preview
  • Calendar times earlier this week (for example Jun 20 at 2:05 PM)
  • The "Last used" date on reusable distance routes, which was always English before because it was formatted without a locale

The year branch still uses CONST.DATE.MONTH_DAY_YEAR_ABBR_FORMAT, which is localized separately. CONST.DATE.MONTH_DAY_ABBR_FORMAT is left in place for now so this PR does not conflict with the other date PRs that edit neighbouring constants; a follow-up removes the unused constants.

This is one of a set of small, independent PRs that split up the date-localization work in #105846. They can merge in any order. Each one caches its own Intl.DateTimeFormat next to the function it changes; a follow-up will merge those into one shared helper.

Update: year rule reads the date in UTC

formatToMonthDayWithOptionalYearInUTC now reads the stored date's year in UTC, the timezone it is shown in, and compares it with the device's current year. It used doesDateBelongToAPastYear, which read the stored date in the device's timezone, so on a device behind UTC a January 1 date fell on December 31 and was shown with a year. The month and day tests in tests/unit/DateUtilsTest.ts cover it; the case fails with the old rule under TZ=America/Los_Angeles. This update also ports the DateCell, Last used and reused-route badge tests from #105846.

Fixed Issues

$ #98088
PROPOSAL:

Tests

  1. Create an expense dated in the current year (for example 20 June).
  2. Open Settings > Preferences > Language and select Deutsch.
  3. Open Spend > Expenses and verify the expense date reads 20. Juni.
  4. Open Home and verify the same expense in Recently added reads 20. Juni.
  5. Open the expense's report and verify the transaction preview date reads 20. Juni.
  6. Create a distance expense from a saved route and verify the "Last used" date uses the German order.
  7. Switch back to English and verify all of the above read Jun 20, the same as before.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

Same as tests.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screen.Recording.2026-11-06.at.8.21.31.PM.mov

Add DateUtils.formatToMonthDay, backed by a cached Intl.DateTimeFormat, and
formatToMonthDayWithOptionalYearInUTC, which keeps the past-year rule and reads
calendar dates as UTC. Search rows, transaction previews, recently added
expenses, split rows, the card authorization preview, calendar times this week
and the reusable route Last used date now use them, so other languages get
their own month-day order. English output is unchanged.
@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...components/Search/SearchList/ListItem/DateCell.tsx 100.00% <100.00%> (+8.33%) ⬆️
...SearchList/ListItem/WithdrawalIDListItemHeader.tsx 99.04% <100.00%> (-0.02%) ⬇️
...hList/ListItem/getExpenseReportRowDisplayValues.ts 100.00% <100.00%> (ø)
src/libs/ReusableDistanceRoutesUtils.ts 96.66% <100.00%> (+10.00%) ⬆️
src/libs/TransactionPreviewUtils.ts 85.57% <100.00%> (-0.08%) ⬇️
...ges/home/RecentlyAddedSection/RecentlyAddedRow.tsx 100.00% <100.00%> (ø)
src/pages/iou/DynamicSplitExpensePage.tsx 69.65% <100.00%> (-0.11%) ⬇️
src/pages/iou/request/step/ReuseRouteListItem.tsx 90.16% <100.00%> (+90.16%) ⬆️
...ransactionPage/AuthorizeCardTransactionPreview.tsx 0.00% <0.00%> (ø)
src/libs/DateUtils.ts 92.06% <87.50%> (+0.03%) ⬆️
... and 11 files with indirect coverage changes

formatToMonthDayWithOptionalYearInUTC shows the date in UTC, so read the date's
year in UTC too before comparing it with the device's current year. Reading it
in the device's timezone added a year to January 1 dates behind UTC. Add the
DateCell, Last used and reused-route badge tests from Expensify#105846.
A cached Intl.DateTimeFormat keeps the device timezone from when it was
created. Format local dates in UTC and copy their current local fields
instead. Dates formatted in an explicit timezone are unchanged.
@shubham1206agra
shubham1206agra marked this pull request as ready for review November 6, 2026 14:56
@shubham1206agra
shubham1206agra requested review from a team as code owners November 6, 2026 14:56
@melvin-bot
melvin-bot Bot requested review from linhvovan29546 and removed request for a team November 6, 2026 14:56
@melvin-bot

melvin-bot Bot commented Nov 6, 2026

Copy link
Copy Markdown

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from dylanexpensify and removed request for a team November 6, 2026 14:56
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T15:20:54.126549Z 6aea143 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

…h-day

# Conflicts:
#	tests/unit/DateUtilsTest.ts
dylanexpensify
dylanexpensify previously approved these changes Nov 9, 2026

@dylanexpensify dylanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a product perspective 👍

@linhvovan29546

Copy link
Copy Markdown
Contributor

Conflicts

…calize-dates-month-day

# Conflicts:
#	tests/unit/DateUtilsTest.ts
@linhvovan29546

linhvovan29546 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp Image Image Image
iOS: mWeb Safari
MacOS: Chrome / Safari Image Image Image

@roryabraham
roryabraham merged commit e238896 into Expensify:main Nov 10, 2026
37 of 41 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No FullStory changes needed — this PR only fixes localized date formatting and UTC year handling in existing UI, without adding new user interactions, screens, or sensitive content.


view run

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR fixes date formatting to follow the selected language’s conventions, restoring expected behavior without adding a workflow or making existing article instructions incorrect.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants