Repository navigation
Localize travel reservation dates - #105874
Conversation
Format reservation ranges and transport dates with a cached Intl.DateTimeFormat (weekday, month, day and an optional year) instead of hand-written EEEE, MMM d patterns, so each language uses its own order. English output is unchanged.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
A cached Intl.DateTimeFormat keeps the device timezone from when it was created. Format in UTC and copy the date's current local fields instead.
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: mWeb Safari |
|
@linhvovan29546 Resolved |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.36-0 🚀
|
|
No help site update needed — this PR fixes travel reservation dates to follow the selected language’s expected format, without adding a workflow or making existing article text incorrect. |
|
No FullStory changes needed. This PR only fixes date localization for existing travel reservations and refactors formatting helpers; it adds no new interactions, screens, user properties, or sensitive content. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀
Bundle Size Analysis (Sentry): |


Explanation of Change
Travel reservation dates used the hand-written patterns
EEEE, MMM dandEEEE, MMM d, yyyy. They fix the US order, so German showedDienstag, März 17and Japanese火曜日, 3月 17.These dates now come from a cached
Intl.DateTimeFormatin the app's selected language. Times and the translated words around them ("Departs", "at", "to") are unchanged:Places updated:
The hotel cancellation date uses a different code path and is localized in its own PR.
This is one of a set of small, independent PRs that split up the date-localization work in #105846. They can merge in any order. Each one caches its own
Intl.DateTimeFormatnext to the function it changes; a follow-up will merge those into one shared helper.Fixed Issues
$ #98088
PROPOSAL:
Tests
Abfahrt Dienstag, 17. März …and the hotel row shows its dates with the day before the month.Tuesday, Mar 17, the same as before.Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-11-07.at.8.47.17.PM.mov