Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion config/oxlint/oxlint.seatbelt.tsv
Original file line number Diff line number Diff line change
Expand Up @@ -1807,6 +1807,7 @@
"../../src/pages/workspace/categories/CategorySettingsPage.tsx" "@typescript-eslint/no-deprecated/MenuItem" 1
"../../src/pages/workspace/categories/CategorySettingsPage.tsx" "no-restricted-imports" 1
"../../src/pages/workspace/categories/DynamicCategoryApproverPage.tsx" "no-restricted-imports" 1
"../../src/pages/workspace/categories/DynamicCategoryDefaultTaxRatePage.tsx" "no-restricted-imports" 1
"../../src/pages/workspace/categories/DynamicCategoryDescriptionHintPage.tsx" "no-restricted-imports" 1
"../../src/pages/workspace/categories/DynamicCategoryFlagAmountsOverPage.tsx" "no-restricted-imports" 1
"../../src/pages/workspace/categories/DynamicCategoryRequiredFieldsPage.tsx" "no-restricted-imports" 1
Expand Down Expand Up @@ -1999,8 +2000,11 @@
"../../src/pages/workspace/rules/FlagForReviewRules/FlagForReviewRuleAmountPageBase.tsx" "@typescript-eslint/no-unnecessary-type-assertion" 1
"../../src/pages/workspace/rules/FlagForReviewRules/FlagForReviewRulePageBase.tsx" "@typescript-eslint/no-deprecated/MenuItemWithTopDescription" 1
"../../src/pages/workspace/rules/IndividualExpenseRulesSectionRevamp.tsx" "@typescript-eslint/no-deprecated/MenuItem" 1
"../../src/pages/workspace/rules/MerchantRules/ExpenseDefaultRulePageBase.tsx" "@typescript-eslint/no-deprecated/MenuItemWithTopDescription" 1
"../../src/pages/workspace/rules/MerchantRules/AddMerchantRulePage.tsx" "rulesdir/no-onyx-loading-status" 1
"../../src/pages/workspace/rules/MerchantRules/ExpenseDefaultTypePage.tsx" "@typescript-eslint/no-deprecated/MenuItem" 1
"../../src/pages/workspace/rules/MerchantRules/ImportedMerchantRulesPage.tsx" "rulesdir/no-onyx-loading-status" 1
"../../src/pages/workspace/rules/MerchantRules/MerchantRulePageBase.tsx" "@typescript-eslint/no-deprecated/MenuItemWithTopDescription" 1
"../../src/pages/workspace/rules/MerchantRules/MerchantRulePageBase.tsx" "rulesdir/no-onyx-loading-status" 1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems no longer needed

"../../src/pages/workspace/rules/MerchantTypeRules/MerchantTypeRulePageBase.tsx" "@typescript-eslint/no-deprecated/MenuItemWithTopDescription" 1
"../../src/pages/workspace/rules/RulesNewPage.tsx" "@typescript-eslint/no-deprecated/MenuItem" 1
"../../src/pages/workspace/rules/SpendRules/SpendRulePageBase.tsx" "@typescript-eslint/no-deprecated/MenuItemWithTopDescription" 1
Expand Down Expand Up @@ -2261,6 +2265,7 @@
"../../tests/ui/ComposerImperativeRefTest.tsx" "@typescript-eslint/no-deprecated/keyCode" 1
"../../tests/ui/ComposerTest.tsx" "rulesdir/no-raw-typography" 1
"../../tests/ui/DomainNameOrNotFoundWrapperTest.tsx" "@typescript-eslint/no-unsafe-member-access" 1
"../../tests/ui/DynamicCategoryDefaultTaxRatePageTest.tsx" "@typescript-eslint/no-unnecessary-type-assertion" 1
"../../tests/ui/DynamicReportDetailsPageTest.tsx" "@typescript-eslint/no-unnecessary-type-assertion" 2
"../../tests/ui/DynamicWorkspaceWorkflowsApprovalsExpensesFromPageFastEditSaveTest.tsx" "@typescript-eslint/no-unnecessary-type-assertion" 1
"../../tests/ui/DynamicWorkspaceWorkflowsApprovalsExpensesFromPageTest.tsx" "@typescript-eslint/no-unnecessary-type-assertion" 1
Expand Down
9 changes: 5 additions & 4 deletions src/CONST/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5081,11 +5081,14 @@ const CONST = {
/** Subsections of the Rules > Expense defaults table, listed in the order they render. */
EXPENSE_DEFAULTS_SECTION: {
CATEGORIES: 'categories',
TAGS: 'tags',
MERCHANTS: 'merchants',
MULTIPLE_CONDITIONS: 'multipleConditions',
MERCHANT_TYPES: 'merchantTypes',
},
/** What an expense default rule matches on, chosen before the editor opens and kept in its draft. */
EXPENSE_DEFAULT_RULE_TYPE: {
MERCHANT: 'merchant',
CATEGORY: 'category',
},
DEFAULT_REPORT_NAME_PATTERN: '{report:type} {report:startdate}',
DEFAULT_FIELD_LIST_TYPE: 'formula',
DEFAULT_FIELD_LIST_TARGET: 'expense',
Expand Down Expand Up @@ -9663,7 +9666,6 @@ const CONST = {
EXPENSE_DEFAULT: {
/** Expense fields a `Set` action can write to */
FIELD: {
AMOUNT: 'amount',
BILLABLE: 'billable',
CATEGORY: 'category',
COMMENT: 'comment',
Expand Down Expand Up @@ -10984,7 +10986,6 @@ const CONST = {
INDIVIDUAL_EXPENSES_MENU_ITEM: 'WorkspaceRules-IndividualExpensesMenuItem',
SPEND_RULE_ITEM: 'WorkspaceRules-SpendRuleItem',
MERCHANT_RULE_ITEM: 'WorkspaceRules-MerchantRuleItem',
TAG_RULE_ITEM: 'WorkspaceRules-TagRuleItem',
REQUIRE_FIELDS_RULE_ITEM: 'WorkspaceRules-RequireFieldsRuleItem',
REQUIRE_FIELDS_RULE_SAVE: 'WorkspaceRules-RequireFieldsRuleSave',
REQUIRE_FIELDS_RULE_DESCRIBE: 'WorkspaceRules-RequireFieldsRuleDescribe',
Expand Down
72 changes: 29 additions & 43 deletions src/ROUTES.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,14 +105,6 @@ const ENABLE_GLOBAL_REIMBURSEMENTS_ENTRY_SCREENS = [
SCREENS.WORKSPACE.WORKFLOWS,
] as const;

// Every step of the expense default editor is reachable from the workspace Rules flow and from category settings,
// which enters through its own dynamic route, so each step has to accept both as an entry.
const EXPENSE_DEFAULT_RULE_STEP_ENTRY_SCREENS = [
SCREENS.WORKSPACE.DYNAMIC_RULES_MERCHANT_NEW,
SCREENS.WORKSPACE.DYNAMIC_CATEGORY_TAX_RULE_NEW,
SCREENS.WORKSPACE.DYNAMIC_CATEGORY_TAX_RULE_EDIT,
] as const;

const DYNAMIC_ROUTES = {
VERIFY_ACCOUNT: {
path: 'verify-account',
Expand Down Expand Up @@ -1121,6 +1113,10 @@ const DYNAMIC_ROUTES = {
path: 'gl-code',
entryScreens: [SCREENS.WORKSPACE.DYNAMIC_CATEGORY_SETTINGS],
},
WORKSPACE_CATEGORY_DEFAULT_TAX_RATE: {
path: 'tax-rate',
entryScreens: [SCREENS.WORKSPACE.DYNAMIC_CATEGORY_SETTINGS, SCREENS.SETTINGS_CATEGORIES.DYNAMIC_SETTINGS_CATEGORY_SETTINGS],
},
WORKSPACE_CATEGORY_FLAG_AMOUNTS_OVER: {
path: 'flag-amounts',
entryScreens: [SCREENS.WORKSPACE.DYNAMIC_CATEGORY_SETTINGS, SCREENS.SETTINGS_CATEGORIES.DYNAMIC_SETTINGS_CATEGORY_SETTINGS],
Expand Down Expand Up @@ -1174,11 +1170,8 @@ const DYNAMIC_ROUTES = {
entryScreens: [SCREENS.WORKSPACE.DYNAMIC_CATEGORY_RULES_NEW],
},
WORKSPACE_CATEGORY_RULES_TAX_EDIT: {
// A category can hold more than one rule, so the row carries the rule it opens rather than letting the
// category name stand in for it.
path: 'rules/tax/:ruleID',
path: 'rules/tax',
entryScreens: [SCREENS.WORKSPACE.DYNAMIC_CATEGORY_SETTINGS, SCREENS.SETTINGS_CATEGORIES.DYNAMIC_SETTINGS_CATEGORY_SETTINGS],
getRoute: (ruleID: string) => `rules/tax/${ruleID}` as const,
},
RULES_MERCHANT_NEW_FROM_EXPENSE: {
path: 'merchant-rule/new',
Expand All @@ -1188,60 +1181,48 @@ const DYNAMIC_ROUTES = {
},
RULES_MERCHANT_MERCHANT_TO_MATCH_FROM_EXPENSE: {
path: 'rule-merchant-to-match',
entryScreens: EXPENSE_DEFAULT_RULE_STEP_ENTRY_SCREENS,
entryScreens: [SCREENS.WORKSPACE.DYNAMIC_RULES_MERCHANT_NEW],
},
RULES_MERCHANT_MATCH_TYPE_FROM_EXPENSE: {
path: 'rule-match-type',
entryScreens: [SCREENS.WORKSPACE.DYNAMIC_RULES_MERCHANT_MERCHANT_TO_MATCH],
},
RULES_MERCHANT_MERCHANT_FROM_EXPENSE: {
path: 'rule-merchant',
entryScreens: EXPENSE_DEFAULT_RULE_STEP_ENTRY_SCREENS,
entryScreens: [SCREENS.WORKSPACE.DYNAMIC_RULES_MERCHANT_NEW],
},
RULES_MERCHANT_CATEGORY_FROM_EXPENSE: {
path: 'rule-category',
entryScreens: EXPENSE_DEFAULT_RULE_STEP_ENTRY_SCREENS,
entryScreens: [SCREENS.WORKSPACE.DYNAMIC_RULES_MERCHANT_NEW],
},
RULES_MERCHANT_TAG_FROM_EXPENSE: {
path: 'rule-tag/:orderWeight',
entryScreens: EXPENSE_DEFAULT_RULE_STEP_ENTRY_SCREENS,
entryScreens: [SCREENS.WORKSPACE.DYNAMIC_RULES_MERCHANT_NEW],
getRoute: (orderWeight: number) => `rule-tag/${orderWeight}` as const,
},
RULES_MERCHANT_TAX_FROM_EXPENSE: {
path: 'rule-tax',
entryScreens: EXPENSE_DEFAULT_RULE_STEP_ENTRY_SCREENS,
entryScreens: [SCREENS.WORKSPACE.DYNAMIC_RULES_MERCHANT_NEW, SCREENS.WORKSPACE.DYNAMIC_CATEGORY_TAX_RULE_NEW, SCREENS.WORKSPACE.DYNAMIC_CATEGORY_TAX_RULE_EDIT],
},
RULES_MERCHANT_VENDOR_FROM_EXPENSE: {
path: 'rule-vendor',
entryScreens: EXPENSE_DEFAULT_RULE_STEP_ENTRY_SCREENS,
entryScreens: [SCREENS.WORKSPACE.DYNAMIC_RULES_MERCHANT_NEW],
},
RULES_MERCHANT_DESCRIPTION_FROM_EXPENSE: {
path: 'rule-description',
entryScreens: EXPENSE_DEFAULT_RULE_STEP_ENTRY_SCREENS,
entryScreens: [SCREENS.WORKSPACE.DYNAMIC_RULES_MERCHANT_NEW],
},
RULES_MERCHANT_REIMBURSABLE_FROM_EXPENSE: {
path: 'rule-reimbursable',
entryScreens: EXPENSE_DEFAULT_RULE_STEP_ENTRY_SCREENS,
entryScreens: [SCREENS.WORKSPACE.DYNAMIC_RULES_MERCHANT_NEW],
},
RULES_MERCHANT_BILLABLE_FROM_EXPENSE: {
path: 'rule-billable',
entryScreens: EXPENSE_DEFAULT_RULE_STEP_ENTRY_SCREENS,
},
RULES_MERCHANT_AMOUNT_FROM_EXPENSE: {
path: 'rule-amount',
entryScreens: EXPENSE_DEFAULT_RULE_STEP_ENTRY_SCREENS,
},
RULES_CATEGORY_TO_MATCH_FROM_EXPENSE: {
path: 'rule-category-to-match',
entryScreens: EXPENSE_DEFAULT_RULE_STEP_ENTRY_SCREENS,
},
RULES_TAG_TO_MATCH_FROM_EXPENSE: {
path: 'rule-tag-to-match',
entryScreens: EXPENSE_DEFAULT_RULE_STEP_ENTRY_SCREENS,
entryScreens: [SCREENS.WORKSPACE.DYNAMIC_RULES_MERCHANT_NEW],
},
RULES_MERCHANT_PREVIEW_MATCHES_FROM_EXPENSE: {
path: 'rule-matches',
entryScreens: EXPENSE_DEFAULT_RULE_STEP_ENTRY_SCREENS,
entryScreens: [SCREENS.WORKSPACE.DYNAMIC_RULES_MERCHANT_NEW],
},
NOTIFICATION_PREFERENCES: {
// `reportID` is intentionally carried as a distinct path param (`notificationReportID`) rather than
Expand Down Expand Up @@ -4512,6 +4493,10 @@ const ROUTES = {
route: 'workspaces/:policyID/rules/new',
getRoute: (policyID: string, categoryName?: string) => `workspaces/${policyID}/rules/new${getOptionalCategoryNameQuery(categoryName)}` as const,
},
RULES_EXPENSE_DEFAULT_TYPE: {
route: 'workspaces/:policyID/rules/expense-defaults/new',
getRoute: (policyID: string) => `workspaces/${policyID}/rules/expense-defaults/new` as const,
},
RULES_MERCHANT_NEW: {
route: 'workspaces/:policyID/rules/merchant-rules/new',
getRoute: (policyID: string, categoryName?: string) => `workspaces/${policyID}/rules/merchant-rules/new${getOptionalCategoryNameQuery(categoryName)}` as const,
Expand Down Expand Up @@ -4578,7 +4563,10 @@ const ROUTES = {
},
RULES_MERCHANT_TAX: {
route: 'workspaces/:policyID/rules/merchant-rules/:ruleID/tax',
getRoute: (policyID: string, ruleID?: string) => `workspaces/${policyID}/rules/merchant-rules/${ruleID ?? 'new'}/tax` as const,
// `categoryName` is set when editing a category tax default, which is identified by its category rather than a
// ruleID. It tells the picker to return to that editor instead of the create page.
getRoute: (policyID: string, ruleID?: string, categoryName?: string) =>
`workspaces/${policyID}/rules/merchant-rules/${ruleID ?? 'new'}/tax${getOptionalCategoryNameQuery(categoryName)}` as const,
},
RULES_MERCHANT_VENDOR: {
route: 'workspaces/:policyID/rules/merchant-rules/:ruleID/vendor',
Expand All @@ -4596,10 +4584,6 @@ const ROUTES = {
route: 'workspaces/:policyID/rules/merchant-rules/:ruleID/billable',
getRoute: (policyID: string, ruleID?: string) => `workspaces/${policyID}/rules/merchant-rules/${ruleID ?? 'new'}/billable` as const,
},
RULES_MERCHANT_AMOUNT: {
route: 'workspaces/:policyID/rules/merchant-rules/:ruleID/amount',
getRoute: (policyID: string, ruleID?: string) => `workspaces/${policyID}/rules/merchant-rules/${ruleID ?? 'new'}/amount` as const,
},
RULES_MERCHANT_EDIT: {
route: 'workspaces/:policyID/rules/merchant-rules/:ruleID',
getRoute: (policyID: string, ruleID: string) => `workspaces/${policyID}/rules/merchant-rules/${ruleID}` as const,
Expand All @@ -4610,11 +4594,13 @@ const ROUTES = {
},
RULES_CATEGORY_TO_MATCH: {
route: 'workspaces/:policyID/rules/merchant-rules/:ruleID/category-to-match',
getRoute: (policyID: string, ruleID?: string) => `workspaces/${policyID}/rules/merchant-rules/${ruleID ?? 'new'}/category-to-match` as const,
// A category tax default has no ruleID, so editing one passes its category for the way back.
getRoute: (policyID: string, ruleID?: string, categoryName?: string) =>
`workspaces/${policyID}/rules/merchant-rules/${ruleID ?? 'new'}/category-to-match${getOptionalCategoryNameQuery(categoryName)}` as const,
},
RULES_TAG_TO_MATCH: {
route: 'workspaces/:policyID/rules/merchant-rules/:ruleID/tag-to-match',
getRoute: (policyID: string, ruleID?: string) => `workspaces/${policyID}/rules/merchant-rules/${ruleID ?? 'new'}/tag-to-match` as const,
RULES_CATEGORY_TAX_EDIT: {
route: 'workspaces/:policyID/rules/category-tax-rules/edit/:categoryName',
getRoute: (policyID: string, categoryName: string) => `workspaces/${policyID}/rules/category-tax-rules/edit/${encodeURIComponent(categoryName)}` as const,
},
RULES_AGENT_NEW: {
route: 'workspaces/:policyID/rules/agent-rules/new',
Expand Down
8 changes: 3 additions & 5 deletions src/SCREENS.ts
Original file line number Diff line number Diff line change
Expand Up @@ -970,6 +970,7 @@ const SCREENS = {
DYNAMIC_CATEGORY_PAYROLL_CODE: 'Dynamic_Category_Payroll_Code',
DYNAMIC_CATEGORY_GL_CODE: 'Dynamic_Category_GL_Code',
DYNAMIC_CATEGORY_SETTINGS: 'Dynamic_Category_Settings',
DYNAMIC_CATEGORY_DEFAULT_TAX_RATE: 'Dynamic_Category_Default_Tax_Rate',
DYNAMIC_CATEGORY_FLAG_AMOUNTS_OVER: 'Dynamic_Category_Flag_Amounts_Over',
DYNAMIC_EXPENSE_LIMIT_TYPE_SELECTOR: 'Dynamic_Expense_Limit_Type_Selector',
DYNAMIC_IMPORTED_MEMBERS_ROLE: 'Dynamic_Imported_Members_Role',
Expand Down Expand Up @@ -1053,6 +1054,7 @@ const SCREENS = {
RULES_CUSTOM: 'Rules_Custom',
RULES_PROHIBITED_DEFAULT: 'Rules_Prohibited_Default',
RULES_NEW: 'Rules_New',
RULES_EXPENSE_DEFAULT_TYPE: 'Rules_Expense_Default_Type',
RULES_MERCHANT_NEW: 'Rules_Merchant_New',
RULES_MERCHANT_IMPORT: 'Rules_Merchant_Import',
RULES_MERCHANT_IMPORTED: 'Rules_Merchant_Imported',
Expand Down Expand Up @@ -1086,10 +1088,9 @@ const SCREENS = {
RULES_MERCHANT_DESCRIPTION: 'Rules_Merchant_Description',
RULES_MERCHANT_REIMBURSABLE: 'Rules_Merchant_Reimbursable',
RULES_MERCHANT_BILLABLE: 'Rules_Merchant_Billable',
RULES_MERCHANT_AMOUNT: 'Rules_Merchant_Amount',
RULES_MERCHANT_PREVIEW_MATCHES: 'Rules_Merchant_Preview_Matches',
RULES_CATEGORY_TO_MATCH: 'Rules_Category_To_Match',
RULES_TAG_TO_MATCH: 'Rules_Tag_To_Match',
RULES_CATEGORY_TAX_EDIT: 'Rules_Category_Tax_Edit',
RULES_MERCHANT_EDIT: 'Rules_Merchant_Edit',
DYNAMIC_RULES_MERCHANT_NEW: 'Dynamic_Rules_Merchant_New',
DYNAMIC_RULES_MERCHANT_MERCHANT_TO_MATCH: 'Dynamic_Rules_Merchant_Merchant_To_Match',
Expand All @@ -1102,9 +1103,6 @@ const SCREENS = {
DYNAMIC_RULES_MERCHANT_DESCRIPTION: 'Dynamic_Rules_Merchant_Description',
DYNAMIC_RULES_MERCHANT_REIMBURSABLE: 'Dynamic_Rules_Merchant_Reimbursable',
DYNAMIC_RULES_MERCHANT_BILLABLE: 'Dynamic_Rules_Merchant_Billable',
DYNAMIC_RULES_MERCHANT_AMOUNT: 'Dynamic_Rules_Merchant_Amount',
DYNAMIC_RULES_CATEGORY_TO_MATCH: 'Dynamic_Rules_Category_To_Match',
DYNAMIC_RULES_TAG_TO_MATCH: 'Dynamic_Rules_Tag_To_Match',
DYNAMIC_RULES_MERCHANT_PREVIEW_MATCHES: 'Dynamic_Rules_Merchant_Preview_Matches',
RULES_SPEND_MERCHANTS: 'Rules_Spend_Merchants',
RULES_SPEND_MERCHANT_EDIT: 'Rules_Spend_Merchant_Edit',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import {useCurrencyListActions} from '@hooks/useCurrencyList';

import {setMoneyRequestCategory, setMoneyRequestTag} from '@libs/actions/IOU/MoneyRequest';
import {insertTagIntoTransactionTagsString} from '@libs/IOUUtils';
import {getTag} from '@libs/TransactionUtils';
Expand Down Expand Up @@ -57,16 +59,17 @@ function FieldAutoSelector({
iouCategory,
isMovingTransactionFromTrackExpense,
}: FieldAutoSelectorProps) {
const {getCurrencyDecimals} = useCurrencyListActions();
// Auto select the category if there is only one enabled category and it is required
useEffect(() => {
const enabledCategories = Object.values(policyCategories ?? {}).filter((category) => category.enabled);
if (!transactionID || iouCategory || !shouldShowCategories || enabledCategories.length !== 1 || !isCategoryRequired) {
return;
}
setMoneyRequestCategory(transactionID, enabledCategories.at(0)?.name ?? '', policy, isMovingTransactionFromTrackExpense);
setMoneyRequestCategory(transactionID, enabledCategories.at(0)?.name ?? '', policy, getCurrencyDecimals, isMovingTransactionFromTrackExpense);
// Keep 'transaction' out to ensure that we auto select the option only once
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [shouldShowCategories, policyCategories, isCategoryRequired, policy?.id]);
}, [shouldShowCategories, policyCategories, isCategoryRequired, policy?.id, getCurrencyDecimals]);

// Auto select the tag if there is only one enabled tag and it is required
useEffect(() => {
Expand Down
23 changes: 5 additions & 18 deletions src/components/MoneyRequestConfirmationList/TaxController.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ function TaxController({

const previousTransactionCurrency = usePrevious(transaction?.currency);

const {defaultTaxCode, defaultTaxValue, shouldKeepCurrentTaxSelection, taxAmountInSmallestCurrencyUnits, areRulesLoading} = useTaxAmount({
const {defaultTaxCode, defaultTaxValue, shouldKeepCurrentTaxSelection, taxAmountInSmallestCurrencyUnits} = useTaxAmount({
transaction,
policy,
policyForMovingExpenses,
Expand All @@ -80,9 +80,7 @@ function TaxController({
});

useEffect(() => {
// Writing the workspace default before the rules arrive would read as a tax the user picked, and
// `shouldKeepCurrentTaxSelection` would then hold it in place once the category's rule does land.
if (!transactionID || isReadOnly || !shouldShowTax || isMovingTransactionFromTrackExpense || areRulesLoading) {
if (!transactionID || isReadOnly || !shouldShowTax || isMovingTransactionFromTrackExpense) {
return;
}

Expand All @@ -97,25 +95,14 @@ function TaxController({
taxAmount: transactionTaxAmount ?? null,
});
// trigger this useEffect also when policyID changes - the defaultTaxCode may stay the same
}, [
defaultTaxCode,
defaultTaxValue,
isMovingTransactionFromTrackExpense,
isReadOnly,
transactionID,
policyID,
shouldShowTax,
shouldKeepCurrentTaxSelection,
transactionTaxAmount,
areRulesLoading,
]);
}, [defaultTaxCode, defaultTaxValue, isMovingTransactionFromTrackExpense, isReadOnly, transactionID, policyID, shouldShowTax, shouldKeepCurrentTaxSelection, transactionTaxAmount]);

useEffect(() => {
if (!transactionID || isReadOnly || !shouldShowTax || isMovingTransactionFromTrackExpense || areRulesLoading) {
if (!transactionID || isReadOnly || !shouldShowTax || isMovingTransactionFromTrackExpense) {
return;
}
setMoneyRequestTaxAmount(transactionID, taxAmountInSmallestCurrencyUnits);
}, [transactionID, taxAmountInSmallestCurrencyUnits, isReadOnly, shouldShowTax, isMovingTransactionFromTrackExpense, areRulesLoading]);
}, [transactionID, taxAmountInSmallestCurrencyUnits, isReadOnly, shouldShowTax, isMovingTransactionFromTrackExpense]);

return null;
}
Expand Down
Loading
Loading