Repository navigation
[Payment due @Ollyws] Don't require magic code when downgrading copilot - #105894
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
💡 Codex ReviewWhen AGENTS.md reference: AGENTS.md:L7-L10 While this page is open, any unrelated AGENTS.md reference: AGENTS.md:L7-L10 When the delegate's Onyx role changes after this route is created (for example, from another client or when a queued update completes), the list correctly highlights ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Edge case, we can skip it. |
When UpdateDelegateRole fails, write a generic error to the delegate's updateDelegateRole error field so CopilotPage shows it under the copilot's row, and keep that error when the magic code page closes.
38fd0ab to
9d6584b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d6584b721
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
dylanexpensify
left a comment
There was a problem hiding this comment.
Looks good from a product perspective 👍
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp01_Android_Native.mp4Android: mWeb Chrome02_Android_Chrome.mp4iOS: HybridApp03_iOS_Native.mp4iOS: mWeb Safari04_iOS_Safari.mp4MacOS: Chrome / Safari05_MacOS_Chrome.mp4 |
|
@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🎯 @Ollyws, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
@Julesssss This is ready for your review. |
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.43-0 🚀
|
|
Help site update needed — “Confirm your selection.” should apply only when changing from Limited to Full, since Full-to-Limited changes now apply immediately. I couldn’t create the docs PR because required live-UI verification remained blocked by blank and page-not-found screens after retrying. No files were changed. view run · no recording available |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.47-0 🚀
|
|
Deploy Blocker #107514 was identified to be related to this PR. |
Looking 👀 |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #107635 |
Explanation of Change
This is a follow-up on https://github.com/Expensify/Auth/pull/25467, we remove the validateCode required for user when they downgrade copilot.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/689563
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-11-10.at.12.08.46.mov