Repository navigation
Display company card consent warnings - #105944
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…ing-app-renderer # Conflicts: # src/libs/ReportNameUtils.ts # tests/ui/ReportActionItemTest.tsx # tests/unit/ReportUtilsTest.ts
This comment has been minimized.
This comment has been minimized.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
flaviadefaria
left a comment
There was a problem hiding this comment.
From a product standpoint, this new message looks good to me.
amyevans
left a comment
There was a problem hiding this comment.
A couple quick thoughts! Also do you want to make this Internal QA or can you rewrite the steps so Applause can mock the report action?
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index cdae4b80..47e831e5 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -11381,15 +11381,15 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
}) => {
let warningTime = 'bald';
if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.TWO_WEEKS) {
- warningTime = 'in zwei Wochen';
+ warningTime = 'in two weeks';
} else if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.ONE_WEEK) {
- warningTime = 'in einer Woche';
+ warningTime = 'in one week';
}
const reconnectMessage = workspaceCompanyCardRoute
? `<a href='${workspaceCompanyCardRoute}'>Stellen Sie die Kartenverbindung wieder her, bevor die Zustimmung abläuft</a>.`
: 'Stellen Sie die Kartenverbindung wieder her, bevor die Zustimmung abläuft.';
- const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>, für Ihre ` : 'Für Ihre ';
- return `${intro}<strong>${feedName}</strong>-Kartenverbindung ist ${warningTime} eine erneute Zustimmung erforderlich. Transaktionen werden derzeit noch synchronisiert, könnten aber nicht mehr importiert werden, wenn die Zustimmung nicht erneuert wird. ${reconnectMessage}`;
+ const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>, Ihr` : 'Ihr';
+ return `${intro}Für die Kartenverbindung <strong>${feedName}</strong> ist ${warningTime} eine erneute Zustimmung erforderlich. Umsätze werden derzeit noch synchronisiert, der Import kann jedoch stoppen, wenn die Verbindung nicht erneuert wird. ${reconnectMessage}`;
},
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
`Die Plaid-Verbindung zu Ihrem Geschäftskonto ist unterbrochen. Bitte <a href='${walletRoute}'>verbinden Sie Ihr Bankkonto ${maskedAccountNumber} erneut</a>, damit Sie Ihre Expensify Karten weiterhin verwenden können.`,
diff --git a/src/languages/el.ts b/src/languages/el.ts
index c7be9fe1..807294c0 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -11581,15 +11581,15 @@ ${reportName}`,
}) => {
let warningTime = 'σύντομα';
if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.TWO_WEEKS) {
- warningTime = 'σε δύο εβδομάδες';
+ warningTime = 'in two weeks';
} else if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.ONE_WEEK) {
- warningTime = 'σε μία εβδομάδα';
+ warningTime = 'in one week';
}
const reconnectMessage = workspaceCompanyCardRoute
- ? `<a href='${workspaceCompanyCardRoute}'>Επανασυνδέστε την κάρτα πριν λήξει η συγκατάθεση</a>.`
+ ? `<a href='${workspaceCompanyCardRoute}'>Επανασυνδέστε τη σύνδεση της κάρτας πριν λήξει η συναίνεση</a>.`
: 'Επανασυνδέστε την κάρτα πριν λήξει η συγκατάθεση.';
- const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>, η σύνδεση της κάρτας ` : 'Η σύνδεση της κάρτας ';
- return `${intro}<strong>${feedName}</strong> θα χρειαστεί ανανέωση συγκατάθεσης ${warningTime}. Οι συναλλαγές εξακολουθούν να συγχρονίζονται, αλλά μπορεί να σταματήσουν να εισάγονται αν δεν ανανεωθεί η συγκατάθεση. ${reconnectMessage}`;
+ const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>, το δικό σας` : 'Το';
+ return `${intro}Η σύνδεση της κάρτας <strong>${feedName}</strong> θα χρειαστεί νέα συναίνεση ${warningTime}. Οι συναλλαγές συγχρονίζονται ακόμη τώρα, αλλά ενδέχεται να σταματήσουν να εισάγονται αν η σύνδεση δεν ανανεωθεί. ${reconnectMessage}`;
},
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
`η σύνδεση Plaid με τον επαγγελματικό σας τραπεζικό λογαριασμό έχει διακοπεί. Παρακαλούμε <a href='${walletRoute}'>συνδέστε ξανά τον τραπεζικό σας λογαριασμό ${maskedAccountNumber}</a> ώστε να μπορείτε να συνεχίσετε να χρησιμοποιείτε τις Κάρτες Expensify.`,
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 3355f3c1..2834893d 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -11269,15 +11269,15 @@ ${reportName}`,
}) => {
let warningTime = 'pronto';
if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.TWO_WEEKS) {
- warningTime = 'en dos semanas';
+ warningTime = 'in two weeks';
} else if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.ONE_WEEK) {
- warningTime = 'en una semana';
+ warningTime = 'in one week';
}
const reconnectMessage = workspaceCompanyCardRoute
? `<a href='${workspaceCompanyCardRoute}'>Vuelve a conectar la tarjeta antes de que caduque el consentimiento</a>.`
: 'Vuelve a conectar la tarjeta antes de que caduque el consentimiento.';
- const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>, la conexión de tu tarjeta ` : 'La conexión de tu tarjeta ';
- return `${intro}<strong>${feedName}</strong> necesitará renovar el consentimiento ${warningTime}. Las transacciones se siguen sincronizando, pero podrían dejar de importarse si no renuevas el consentimiento. ${reconnectMessage}`;
+ const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>, tu` : 'Tu';
+ return `${intro}La conexión de la tarjeta <strong>${feedName}</strong> necesitará un nuevo consentimiento ${warningTime}. Las transacciones siguen sincronizándose ahora, pero podrían dejar de importarse si no se renueva la conexión. ${reconnectMessage}`;
},
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
`la conexión Plaid con tu cuenta bancaria de empresa está rota. Por favor, <a href='${walletRoute}'>reconecta tu cuenta bancaria ${maskedAccountNumber}</a> para poder seguir usando tus Tarjetas Expensify.`,
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 970e4ed0..fda04d53 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -11415,15 +11415,15 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
}) => {
let warningTime = 'bientôt';
if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.TWO_WEEKS) {
- warningTime = 'dans deux semaines';
+ warningTime = 'in two weeks';
} else if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.ONE_WEEK) {
- warningTime = 'dans une semaine';
+ warningTime = 'in one week';
}
const reconnectMessage = workspaceCompanyCardRoute
- ? `<a href='${workspaceCompanyCardRoute}'>Reconnectez la carte avant l'expiration du consentement</a>.`
- : "Reconnectez la carte avant l'expiration du consentement.";
- const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>, la connexion de votre carte ` : 'La connexion de votre carte ';
- return `${intro}<strong>${feedName}</strong> devra renouveler son consentement ${warningTime}. Les transactions sont encore synchronisées, mais elles pourraient ne plus être importées si le consentement n'est pas renouvelé. ${reconnectMessage}`;
+ ? `<a href='${workspaceCompanyCardRoute}'>Reconnectez la connexion de carte avant l’expiration du consentement</a>.`
+ : 'Reconnectez la connexion de la carte avant l’expiration du consentement.';
+ const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>, votre` : 'Votre';
+ return `${intro}La connexion de la carte <strong>${feedName}</strong> nécessitera un nouveau consentement ${warningTime}. Les transactions se synchronisent toujours pour le moment, mais pourraient cesser d’être importées si la connexion n’est pas renouvelée. ${reconnectMessage}`;
},
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
`la connexion Plaid à votre compte bancaire professionnel est rompue. Veuillez <a href='${walletRoute}'>reconnecter votre compte bancaire ${maskedAccountNumber}</a> afin de pouvoir continuer à utiliser vos Cartes Expensify.`,
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 0e9d4d16..297de68b 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -11329,15 +11329,15 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
}) => {
let warningTime = 'presto';
if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.TWO_WEEKS) {
- warningTime = 'tra due settimane';
+ warningTime = 'in two weeks';
} else if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.ONE_WEEK) {
- warningTime = 'tra una settimana';
+ warningTime = 'in one week';
}
const reconnectMessage = workspaceCompanyCardRoute
- ? `<a href='${workspaceCompanyCardRoute}'>Riconnetti la carta prima della scadenza del consenso</a>.`
- : 'Riconnetti la carta prima della scadenza del consenso.';
- const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>, la connessione della tua carta ` : 'La connessione della tua carta ';
- return `${intro}<strong>${feedName}</strong> dovrà rinnovare il consenso ${warningTime}. Le transazioni vengono ancora sincronizzate, ma potrebbero smettere di essere importate se il consenso non viene rinnovato. ${reconnectMessage}`;
+ ? `<a href='${workspaceCompanyCardRoute}'>Ricollega la carta prima che il consenso scada</a>.`
+ : 'Ricollega la connessione della carta prima che il consenso scada.';
+ const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>, il tuo` : 'Il tuo';
+ return `${intro}La connessione della carta <strong>${feedName}</strong> richiederà un nuovo consenso ${warningTime}. Le transazioni si stanno ancora sincronizzando, ma potrebbero smettere di essere importate se la connessione non viene rinnovata. ${reconnectMessage}`;
},
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
`la connessione Plaid al conto bancario della tua azienda non funziona. Per favore, <a href='${walletRoute}'>ricollega il conto bancario ${maskedAccountNumber}</a> così puoi continuare a usare le tue Carte Expensify.`,
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index c7512f51..6ca86423 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -11139,15 +11139,15 @@ ${reportName}`,
}) => {
let warningTime = 'まもなく';
if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.TWO_WEEKS) {
- warningTime = '2週間後';
+ warningTime = 'in two weeks';
} else if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.ONE_WEEK) {
- warningTime = '1週間後';
+ warningTime = 'in one week';
}
const reconnectMessage = workspaceCompanyCardRoute
? `<a href='${workspaceCompanyCardRoute}'>同意の有効期限が切れる前にカード接続を再接続してください</a>。`
- : '同意の有効期限が切れる前にカード接続を再接続してください。';
- const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/> さん、` : '';
- return `${intro}<strong>${feedName}</strong>カード接続は${warningTime}に同意の更新が必要になります。取引は現在も同期されていますが、同意を更新しない場合はインポートが停止する可能性があります。${reconnectMessage}`;
+ : '同意の有効期限が切れる前にカード連携を再接続してください。';
+ const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>さん、あなたの` : 'あなたの';
+ return `${intro}<strong>${feedName}</strong> カード接続には${warningTime}に再同意が必要になります。現在も取引は同期されていますが、接続を更新しないと取引の取込が停止する可能性があります。${reconnectMessage}`;
},
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
`Plaid によるビジネス銀行口座との接続が切断されています。Expensify カードを引き続きご利用いただくために、<a href='${walletRoute}'>銀行口座 ${maskedAccountNumber} を再接続</a>してください。`,
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 61714498..91f6765d 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -11301,15 +11301,15 @@ er bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
}) => {
let warningTime = 'binnenkort';
if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.TWO_WEEKS) {
- warningTime = 'over twee weken';
+ warningTime = 'in two weeks';
} else if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.ONE_WEEK) {
- warningTime = 'over een week';
+ warningTime = 'in one week';
}
const reconnectMessage = workspaceCompanyCardRoute
? `<a href='${workspaceCompanyCardRoute}'>Verbind de kaart opnieuw voordat de toestemming verloopt</a>.`
- : 'Verbind de kaart opnieuw voordat de toestemming verloopt.';
- const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>, voor je ` : 'Voor je ';
- return `${intro}<strong>${feedName}</strong>-kaartverbinding is ${warningTime} opnieuw toestemming nodig. Transacties worden nog gesynchroniseerd, maar worden mogelijk niet meer geïmporteerd als de toestemming niet wordt vernieuwd. ${reconnectMessage}`;
+ : 'Maak de kaartverbinding opnieuw voordat de toestemming verloopt.';
+ const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>, je` : 'Je';
+ return `${intro}de kaartkoppeling van <strong>${feedName}</strong> heeft ${warningTime} opnieuw toestemming nodig. Transacties worden nu nog gesynchroniseerd, maar mogelijk niet meer geïmporteerd als de koppeling niet wordt vernieuwd. ${reconnectMessage}`;
},
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
`de Plaid-verbinding met je zakelijke bankrekening is verbroken. <a href='${walletRoute}'>Verbind je bankrekening ${maskedAccountNumber} opnieuw</a> zodat je je Expensify Kaarten kunt blijven gebruiken.`,
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index f466c43e..9aec17ed 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -11335,15 +11335,15 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
}) => {
let warningTime = 'wkrótce';
if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.TWO_WEEKS) {
- warningTime = 'za dwa tygodnie';
+ warningTime = 'in two weeks';
} else if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.ONE_WEEK) {
- warningTime = 'za tydzień';
+ warningTime = 'in one week';
}
const reconnectMessage = workspaceCompanyCardRoute
- ? `<a href='${workspaceCompanyCardRoute}'>Połącz kartę ponownie, zanim zgoda wygaśnie</a>.`
- : 'Połącz kartę ponownie, zanim zgoda wygaśnie.';
- const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>, połączenie karty ` : 'Połączenie karty ';
- return `${intro}<strong>${feedName}</strong> będzie wymagało odnowienia zgody ${warningTime}. Transakcje są nadal synchronizowane, ale mogą przestać być importowane, jeśli zgoda nie zostanie odnowiona. ${reconnectMessage}`;
+ ? `<a href='${workspaceCompanyCardRoute}'>Ponownie połącz kartę, zanim zgoda wygaśnie</a>.`
+ : 'Połącz ponownie kartę, zanim zgoda wygaśnie.';
+ const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>, twój` : 'Twój';
+ return `${intro}Połączenie karty <strong>${feedName}</strong> będzie wymagało odnowienia zgody ${warningTime}. Transakcje nadal się synchronizują, ale mogą przestać się importować, jeśli połączenie nie zostanie odnowione. ${reconnectMessage}`;
},
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
`połączenie Plaid z twoim firmowym kontem bankowym jest przerwane. Proszę, <a href='${walletRoute}'>połącz ponownie swoje konto bankowe ${maskedAccountNumber}</a>, aby móc dalej używać Kart Expensify.`,
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 86925e2f..c2eddcf1 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -11307,15 +11307,15 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
}) => {
let warningTime = 'em breve';
if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.TWO_WEEKS) {
- warningTime = 'em duas semanas';
+ warningTime = 'in two weeks';
} else if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.ONE_WEEK) {
- warningTime = 'em uma semana';
+ warningTime = 'in one week';
}
const reconnectMessage = workspaceCompanyCardRoute
- ? `<a href='${workspaceCompanyCardRoute}'>Reconecte o cartão antes que o consentimento expire</a>.`
- : 'Reconecte o cartão antes que o consentimento expire.';
- const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>, a conexão do seu cartão ` : 'A conexão do seu cartão ';
- return `${intro}<strong>${feedName}</strong> precisará renovar o consentimento ${warningTime}. As transações ainda estão sendo sincronizadas, mas podem deixar de ser importadas se o consentimento não for renovado. ${reconnectMessage}`;
+ ? `<a href='${workspaceCompanyCardRoute}'>Reconecte a conexão do cartão antes que o consentimento expire</a>.`
+ : 'Reconecte a conexão do cartão antes que o consentimento expire.';
+ const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>, seu` : 'Seu';
+ return `${intro}A conexão do cartão <strong>${feedName}</strong> vai precisar de um novo consentimento ${warningTime}. As transações ainda estão sendo sincronizadas agora, mas podem parar de ser importadas se a conexão não for renovada. ${reconnectMessage}`;
},
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
`a conexão Plaid com a sua conta bancária empresarial foi interrompida. Por favor, <a href='${walletRoute}'>reconecte sua conta bancária ${maskedAccountNumber}</a> para continuar usando seus Cartões Expensify.`,
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index e5b7cafe..2095e7a3 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -10843,15 +10843,15 @@ ${reportName}`,
workspaceCompanyCardRoute: string;
mentionedAccountID?: number;
}) => {
- let warningTime = '即将';
+ let warningTime = '很快';
if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.TWO_WEEKS) {
- warningTime = '两周后';
+ warningTime = 'in two weeks';
} else if (warningDaysBeforeExpiry === CONST.COMPANY_CARDS.CONSENT_EXPIRY_WARNING_DAYS.ONE_WEEK) {
- warningTime = '一周后';
+ warningTime = 'in one week';
}
- const reconnectMessage = workspaceCompanyCardRoute ? `<a href='${workspaceCompanyCardRoute}'>请在同意到期前重新连接卡片</a>。` : '请在同意到期前重新连接卡片。';
- const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>,您的` : '您的';
- return `${intro}<strong>${feedName}</strong>卡片连接将在${warningTime}需要重新同意。交易目前仍在同步,但如果不续订同意,交易可能会停止导入。${reconnectMessage}`;
+ const reconnectMessage = workspaceCompanyCardRoute ? `<a href='${workspaceCompanyCardRoute}'>在授权过期前重新连接该卡</a>。` : '在授权过期前重新连接此卡。';
+ const intro = mentionedAccountID ? `<mention-user accountID="${mentionedAccountID}"/>,你的` : '你的';
+ return `${intro}<strong>${feedName}</strong> 卡连接将在 ${warningTime} 需要重新授权。交易目前仍在同步,但如果不重新连接,导入可能会停止。${reconnectMessage}`;
},
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
`您与企业银行账户的 Plaid 连接已中断。请<a href='${walletRoute}'>重新连接您的银行账户 ${maskedAccountNumber}</a>,以便继续使用 Expensify 卡。`,
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
@amyevans going to with internal QA for this one 👍 |
amyevans
left a comment
There was a problem hiding this comment.
LGTM, all yours @robertjchen
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 robertjchen has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/robertjchen in version: 9.5.41-0 🚀
|
|
No help site update needed — this PR adds a self-explanatory consent-expiry reminder linking to the existing card reconnection workflow, without making any existing article incorrect. |
|
QA passed. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This PR renders the
COMPANYCARDCONSENTEXPIRINGreport action delivered before an Amex company-card consent period expires. It adds typed original-message data, localized one-week/two-week copy, the Company Cards link, and compatible room-preview, thread-title, and clipboard text. If the payload is missingpolicyID, the warning displays without a Company Cards link.Fixed Issues
https://github.com/Expensify/Expensify/issues/687058
AI Tests
Shared consent-warning threshold update:
TypeError: Cannot read properties of undefined (reading 'fileExists'); the Bun invocation was denied by the execution policy. The matrix's Prettier script is absent in this branch; Oxfmt ran successfully through the commit hook.Tests
COMPANYCARDCONSENTEXPIRINGaction in a workspace#adminsroom withfeedName,policyID, andwarningDaysBeforeExpiry: 14.warningDaysBeforeExpiry: 7and verify the copy says one week and it's threaded.Offline tests
#adminsroom containing the consent warning while online.QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari