Skip to content

[No QA] Docs updates for E/A#103323 Explain how to view report history - #105982

Merged
stephanieelliott merged 1 commit into
mainfrom
melvin-docs-reportHistory-103323
Nov 10, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
melvin-docs-reportHistory-103323

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Documents the new Report history feature introduced by Add summary to report status: select the next-step message on a workspace expense report to see completed actions and upcoming steps. This feature is not beta-gated.

Added two sentences to the existing report-status article. No existing sentence became incorrect; this update qualifies because the PR adds a new user-facing feature. No new article, section, or FAQ.

AI Tests

  • npm run lint-changed: passed; no lintable code changed.
  • npm run spell-changed: passed; no spelling issues.
  • git diff --cached --check: passed.
  • Changed-line code and HelpDot governance review: no violations.
  • Docs-only prose change; no runtime tests or docs routing/config checks apply.

🤖 Web test steps verification results: ✅ pass

Verified on dev NewDot web using a newly created workspace and empty draft expense report. No source edits.

Report history showing the completed creation action and upcoming submit and approve steps.

Step Status
Report history navigation and exact labelsOpened an expense report and selected “Waiting for you to add expenses.” The panel title was “Report history”, with “Melvin Tester created report”, “Melvin Tester to submit”, and “Melvin Tester to approve”.
Report history showing the completed creation action and upcoming submit and approve steps.
✅

Fixed Issues

$ #103160
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team November 4, 2026 20:51
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Nov 4, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch because I don't have push access to your fork.

To copy the branch to your fork:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream melvin-docs-reportHistory-103323
git checkout -b melvin-docs-reportHistory-103323 upstream/melvin-docs-reportHistory-103323
git push -u origin melvin-docs-reportHistory-103323

You can then close this PR and open one from your fork.

@MelvinBot MelvinBot mentioned this pull request Nov 4, 2026
54 tasks done
@OSBotify

OSBotify commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://00fd89cf.helpdot.pages.dev ⚡️

Updated articles:

@melvin-bot

melvin-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @dylanexpensify

@melvin-bot
melvin-bot Bot requested review from dylanexpensify and removed request for a team November 10, 2026 23:07
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T23:36:28.226785Z b2cab64 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@stephanieelliott
stephanieelliott merged commit bc5be4b into main Nov 10, 2026
25 of 26 checks passed
@stephanieelliott
stephanieelliott deleted the melvin-docs-reportHistory-103323 branch November 10, 2026 23:11
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a single, small content addition to Understanding-Report-Statuses-and-Actions.md: one paragraph explaining how to view Report history via the next-step message in the report header. It is a focused, non-structural change that adds useful information without altering headings, metadata, or existing content. The change is well-scoped and does not expand the article into a new workflow.

Scores Summary

  • Readability: 8/10 - The added sentence is clear, concise, and benefit-focused. It reads well and is easy to scan.
  • AI Readiness: 7/10 - Uses the full feature name (Report history) and realistic search phrasing. It is a standalone paragraph under an existing section rather than its own task-based heading, so it is not independently retrievable, but a heading is not required for a one-line insertion.
  • Style Compliance: 6/10 - Mostly compliant (correct use of select, bolded feature label), but the navigation phrasing is vague and does not follow the naming conventions.

Key Findings

  • Positive: Uses select correctly (not click/tap), bolds the Report history feature name, and keeps the addition to a single clearly defined concept.
  • Positive: Tone is concise and action-oriented, consistent with the surrounding article.
  • Issue (Style): "open a workspace expense report" is a vague navigation phrase. The naming conventions prohibit non-specific navigation wording and require exact UI labels or a bolded navigation path.
  • Issue (Style): "select the next-step message in the report header" references a UI element by description rather than its exact bolded UI label. Use the exact bolded label if one exists, or name the element by its function.
  • Note: The existing article contains pre-existing deviations (for example, Title Case roles like "Workspace Admins" and "Tap it"). These are outside this PR diff and are not scored here.

Recommendations

  • Priority: Tighten the navigation phrasing to match HELPSITE_NAMING_CONVENTIONS.md. Replace "open a workspace expense report" with a specific action, and reference the next-step element by its exact bolded UI label.
  • Suggestion: If "Report history" is a distinct, searchable workflow, consider a dedicated task-based section (How to view Report history) to improve AI retrieval - optional for a one-line addition.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Understanding-Report-Statuses-and-Actions.md - One paragraph added; clear and useful, with minor navigation-phrasing style issues.

Note: Detailed line-by-line feedback has been provided as inline comments.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants