Skip to content

Prevent restored drafts from keeping the empty composer expanded - #106037

Draft
MelvinBot wants to merge 1 commit into
mainfrom
claude-fixEmptyComposerHeight
Draft

MelvinBot wants to merge 1 commit into
mainfrom
claude-fixEmptyComposerHeight

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Only cache the composer height when its current value is empty, so a restored wrapped draft cannot become the empty baseline. Release the temporary height on the animation frame after the clear render instead of waiting for a content size event that may never fire.

Keep this behavior in a focused hook with frame cleanup. Add seven regression cases covering restored drafts, whitespace, empty measurements, repeated sends, and cancellation.

Fixed Issues

$ #103497
PROPOSAL: #103497 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.

  • Verify that no errors appear in the JS console

AI Tests

  • Passed full Jest suite: 2,219 suites, 37,016 tests, 157 snapshots. One suite and 146 tests were skipped by the existing configuration.
  • Passed targeted composer tests: 14 tests, including all seven new regression cases.
  • Passed lint, lint-changed, typecheck, spell-changed, and Storybook smoke test.
  • Passed React Compiler checks for both changed source files using explicit paths. The check-changed command could not resolve the CI base ref.
  • The required prettier command is unavailable on this checkout because it has no prettier npm script. A separate formatter check was blocked by tool permissions.
  • Code standards review returned no violations.
  • Web verification was blocked: the supplied browser session rendered a blank page. Composer behavior and the expanded-composer cursor-flash regression still need human verification before marking ready for review.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Web verification was blocked before opening a DM; this screenshot is diagnostic evidence, not a passing test.

Blank page blocked composer verification

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team November 4, 2026 23:13
@melvin-bot melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Nov 4, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this draft from an upstream branch because I could not access a contributor fork for situchan.

To move the branch to your fork, run these commands from your local fork checkout:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-fixEmptyComposerHeight
git checkout -b claude-fixEmptyComposerHeight upstream/claude-fixEmptyComposerHeight
git push -u origin claude-fixEmptyComposerHeight

Skip the first command if your upstream remote already exists. You can then close this draft and open a PR from your fork.


view run

@MelvinBot

MelvinBot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Android test steps verification results: ⚠️ partial

Authentication recovered on standalone Android NewDot, but onboarding was blocked by an Android test-keyboard rebind failure. No composer checks were reached; no code was edited.

Onboarding name form and keyboard blocking access to composer testing

Step Status
Open a DM.Blocked during onboarding, before opening a DM.
Onboarding name form and keyboard blocking access to composer testing
❌
Before typing, empty composer shows Write something... at a single-line height.Not reached; onboarding blocked.
❌
Start typing a message; input works normally.Not reached; onboarding blocked.
❌
Type a single line wrapping to two visual lines without explicit newlines.Not reached; onboarding blocked.
❌
Navigate away and back; wrapped draft is restored.Not reached; onboarding blocked.
❌
Send restored draft without editing; empty composer returns to and remains single-line height.Not reached; onboarding blocked.
❌
Send a freshly typed wrapped message; composer returns to single-line height on repeated sends.Not reached; onboarding blocked.
❌
Send an expanded multiline message without cursor/placeholder flash or height regression.Not reached; onboarding blocked.
❌
No JS console errors appear during testing.Not verified: composer testing never began and JS console output was not inspected.
❌

view run · view recording

@MelvinBot

MelvinBot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ⚠️ partial

Verified draft restoration and repeated sending on dev NewDot web using Concierge and its resulting thread. Full PR verification remains incomplete: initial placeholder differs, height metrics and console access are unavailable, and multiline fill dispatched separate sends.

Separate messages produced by multiline fill attempt

Step Status
Open a DM.Opened the existing Concierge conversation; subsequent sending opened its thread.
Concierge conversation with restored draft
✅
Before typing, empty composer shows Write something... at single-line height.Not verified as specified: initial Concierge composer showed “Which expenses are missing a category?” instead. Initial height was not measured.
❌
Start typing a message; input works normally.Snapshot read back the complete 282-character input.
Complete entered message in composer
✅
Type one long line wrapping to two lines, without Enter or Shift+Enter.Entered a newline-free string; snapshot confirmed its complete contents. Screenshot shows natural two-line wrapping.
Single logical line wrapping across two composer rows
✅
Leave the chat and return; wrapped draft is restored.Navigated to Home and back to Inbox. Snapshot read back the identical complete draft.
Wrapped draft restored after navigation
✅
Send restored draft without editing; empty composer returns to and remains single-line height without further typing.Sent unchanged; snapshot confirmed the sent message and empty “Write something...” composer. Sending also navigated into a Concierge thread. Height could not be measured, so the complete assertion remains unverified.
Sent restored message and final compact empty composer
❌
Send freshly typed wrapped messages repeatedly; composer returns to single-line height.Two fresh long messages sent successfully; snapshots showed “Write something...” after each. Final screenshot looks single-line, but repeated height restoration was not measurable.
Repeated long messages sent with final empty composer
❌
Send an expanded multiline message without cursor/placeholder flash or height regression.Unverified: newline-containing fill dispatched separate sends instead of creating one multiline draft. Transient cursor/placeholder behavior could not be checked. This is not an established App defect.
Separate messages produced by multiline fill attempt
❌
No errors appear in JS console.Unverified: console inspection was unavailable through the testing tools.
❌

view run · no recording available

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The failing performance check appears unrelated to your composer changes. I did not push a code change.

Evidence

The failed check reports 29 → 29.7 average renders against a zero-deviation limit. The failing test mounts the money-request list, not the composer. Composer performance measurements did not increase.

Rerun the performance workflow to check for nondeterminism. Independent approval also remains outstanding.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants