Repository navigation
Conversation
Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
|
I created this draft from an upstream branch because I could not access a contributor fork for To move the branch to your fork, run these commands from your local fork checkout: git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-fixEmptyComposerHeight
git checkout -b claude-fixEmptyComposerHeight upstream/claude-fixEmptyComposerHeight
git push -u origin claude-fixEmptyComposerHeightSkip the first command if your |
|
🤖 Android test steps verification results: Authentication recovered on standalone Android NewDot, but onboarding was blocked by an Android test-keyboard rebind failure. No composer checks were reached; no code was edited.
|
|
🤖 Web test steps verification results: Verified draft restoration and repeated sending on dev NewDot web using Concierge and its resulting thread. Full PR verification remains incomplete: initial placeholder differs, height metrics and console access are unavailable, and multiline fill dispatched separate sends. view run · no recording available |
|
The failing performance check appears unrelated to your composer changes. I did not push a code change. EvidenceThe failed check reports 29 → 29.7 average renders against a zero-deviation limit. The failing test mounts the money-request list, not the composer. Composer performance measurements did not increase. Rerun the performance workflow to check for nondeterminism. Independent approval also remains outstanding. |








Explanation of Change
Only cache the composer height when its current value is empty, so a restored wrapped draft cannot become the empty baseline. Release the temporary height on the animation frame after the clear render instead of waiting for a content size event that may never fire.
Keep this behavior in a focused hook with frame cleanup. Add seven regression cases covering restored drafts, whitespace, empty measurements, repeated sends, and cancellation.
Fixed Issues
$ #103497
PROPOSAL: #103497 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.
AI Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Web verification was blocked before opening a DM; this screenshot is diagnostic evidence, not a passing test.