Repository navigation
Conversation
Add a "New roles" badge to the Members item in the workspace menu and a dismissible promo banner on the Members page. Both show only to admins who can assign both roles, and dismissing the banner hides both. Group the role selector into "Admin roles" and "Other roles", order them as in the design, and badge Approve-only and Guest as new. Add header copy linking to the help article and a footer that opens Concierge. The add agent page now picks its default role from the role hierarchy, so the new display order doesn't change it. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
- Use the light success style for the New badge in the role selector - Render the banner subtitle and the role selector feedback note at label size - Add space between the banner and the member count Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
- Use the regular badge size for New roles on the Members menu item - Show the role selector's New badge right after the role name Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…-new-workspace-roles Signed-off-by: krishna2323 <belivethatkg@gmail.com> # Conflicts: # src/CONST/index.ts
|
🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
The new roles page is 🔥 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
JmillsExpensify
left a comment
There was a problem hiding this comment.
The video looks good to me. Defer to C+ for testing.
|
Working on it now |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2026-11-06.at.15.52.15.mov |
|
@JmillsExpensify please help to run the generate workflow here |
|
@Krishna2323 please also resolve conflict |
All set |
This comment has been minimized.
This comment has been minimized.
…page Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@JS00001 @JmillsExpensify Could you re-run the translations workflow on this PR? I split the role selector feedback note into separate text and a Concierge link, so there's a new |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 146977b3..9793d5e2 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -2170,7 +2170,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => `Ändere den Workspace des Berichts für weitere Aktionen.`,
-
[CONST.NEXT_STEP.MESSAGE_KEY.APPROVE_ONLY_SUBMIT_BLOCKED]: (
_actor: string,
_actorType: ValueOf<typeof CONST.NEXT_STEP.ACTOR_TYPE>,
@@ -5476,11 +5475,11 @@ ${amount} für ${merchant} – ${date}`,
noAccessActionPrompt: 'Ihre Arbeitsbereichsrolle hat keinen Zugriff auf diese Einstellungen. Bitten Sie eine/n Admin, falls Sie Zugriff benötigen.',
connections: 'Verknüpfungen',
newRoles: 'Neue Rollen',
- adminRoles: 'Adminrollen',
+ adminRoles: 'Admin-Rollen',
otherRoles: 'Andere Rollen',
- roleSelectorDescription: `Weisen Sie eine Rolle zu, um die Workspace-Berechtigungen eines Mitglieds zu verwalten. <a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">Workspace-Rollen vergleichen</a>.`,
- roleSelectorFeedback:
- '<muted-text-label><centered-text>Sie sehen die benötigte Rolle nicht? <concierge-link>Teilen Sie uns dies mit</concierge-link>.</centered-text></muted-text-label>',
+ roleSelectorDescription: `Weisen Sie eine Rolle zu, um die Arbeitsbereichsberechtigungen eines Mitglieds zu verwalten. <a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">Arbeitsbereichsrollen vergleichen</a>.`,
+ roleSelectorFeedback: 'Sie sehen die benötigte Rolle nicht?',
+ roleSelectorFeedbackLink: 'Lassen Sie es uns wissen',
},
createdForClient: {
title: 'Du hast einen Workspace für deinen Kunden erstellt!',
@@ -7326,8 +7325,8 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
unassignCard: 'Karte zuweisen aufheben',
unassignCards: 'Kartenzuweisung aufheben',
unassign: 'Zuweisung aufheben',
- unassignCardDescription: 'Das Entfernen der Zuweisung dieser Karte wird alle nicht eingereichten Transaktionen löschen.',
- unassignCardsDescription: 'Das Aufheben der Zuweisung löscht alle nicht eingereichten Transaktionen der ausgewählten Karten.',
+ unassignCardDescription: 'Wenn Sie diese Karte zuordnen, werden alle nicht eingereichten Transaktionen gelöscht.',
+ unassignCardsDescription: 'Durch das Aufheben der Zuweisung werden alle nicht eingereichten Transaktionen von den ausgewählten Karten gelöscht.',
removeCard: 'Karte entfernen',
remove: 'Entfernen',
removeCardDescription: 'Wenn Sie diese Karte entfernen, werden alle nicht eingereichten Transaktionen gelöscht.',
@@ -7884,7 +7883,7 @@ Der Control-Tarif beginnt bei 9 $ pro aktivem Mitglied und Monat.`,
newRolesBanner: {
title: 'Neue Rollen verfügbar',
subtitle:
- '<label-text>Geben Sie Mitgliedern genau den Zugriff, den sie benötigen – mit den neuen Rollen <strong>Nur genehmigen</strong> und <strong>Gast</strong>.</label-text>',
+ '<label-text>Geben Sie Mitgliedern genau den Zugang, den sie brauchen, mit den neuen Rollen <strong>Nur-Genehmigung</strong> und <strong>Gast</strong>.</label-text>',
},
},
card: {
diff --git a/src/languages/el.ts b/src/languages/el.ts
index d35f19ec..e84048cf 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -2217,7 +2217,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => `Αλλάξτε τον χώρο εργασίας της αναφοράς για περαιτέρω ενέργειες.`,
-
[CONST.NEXT_STEP.MESSAGE_KEY.APPROVE_ONLY_SUBMIT_BLOCKED]: (
_actor: string,
_actorType: ValueOf<typeof CONST.NEXT_STEP.ACTOR_TYPE>,
@@ -5551,8 +5550,9 @@ ${amount} για ${merchant} - ${date}`,
newRoles: 'Νέοι ρόλοι',
adminRoles: 'Ρόλοι διαχειριστή',
otherRoles: 'Άλλοι ρόλοι',
- roleSelectorDescription: `Αναθέστε έναν ρόλο για τη διαχείριση των δικαιωμάτων χώρου εργασίας ενός μέλους. <a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">Συγκρίνετε ρόλους χώρου εργασίας</a>.`,
- roleSelectorFeedback: '<muted-text-label><centered-text>Δεν βλέπετε τον ρόλο που χρειάζεστε; <concierge-link>Ενημερώστε μας</concierge-link>.</centered-text></muted-text-label>',
+ roleSelectorDescription: `Αναθέστε έναν ρόλο για τη διαχείριση των δικαιωμάτων χώρου εργασίας ενός μέλους. <a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">Σύγκριση ρόλων χώρου εργασίας</a>.`,
+ roleSelectorFeedback: 'Δεν βλέπετε τον ρόλο που χρειάζεστε;',
+ roleSelectorFeedbackLink: 'Ενημερώστε μας',
},
createdForClient: {
title: 'Δημιουργήσατε έναν χώρο εργασίας για τον πελάτη σας!',
@@ -7438,11 +7438,11 @@ _Για πιο αναλυτικές οδηγίες, [επισκεφθείτε τ
unassignCards: 'Αποδέσμευση καρτών',
unassign: 'Κατάργηση ανάθεσης',
unassignCardDescription: 'Η αποδέσμευση αυτής της κάρτας θα διαγράψει όλες τις μη υποβληθείσες συναλλαγές.',
- unassignCardsDescription: 'Η αποδέσμευση θα διαγράψει όλες τις μη υποβληθείσες συναλλαγές από τις επιλεγμένες κάρτες.',
+ unassignCardsDescription: 'Η κατάργηση ανάθεσης θα διαγράψει όλες τις μη υποβληθείσες συναλλαγές από τις επιλεγμένες κάρτες.',
assignCard: 'Ανάθεση κάρτας',
removeCard: 'Αφαίρεση κάρτας',
remove: 'Κατάργηση',
- removeCardDescription: 'Η κατάργηση αυτής της κάρτας θα διαγράψει όλες τις μη υποβληθείσες συναλλαγές.',
+ removeCardDescription: 'Η αφαίρεση αυτής της κάρτας θα διαγράψει όλες τις μη υποβληθείσες συναλλαγές.',
cardFeedName: 'Όνομα ροής κάρτας',
cardFeedNameDescription: 'Δώστε στη ροή κάρτας ένα μοναδικό όνομα ώστε να μπορείτε να τη ξεχωρίζετε από τις άλλες.',
cardFeedTransaction: 'Διαγράψτε συναλλαγές',
@@ -7998,8 +7998,7 @@ _Για πιο αναλυτικές οδηγίες, [επισκεφθείτε τ
changeRole: 'Αλλαγή ρόλου',
newRolesBanner: {
title: 'Διαθέσιμοι νέοι ρόλοι',
- subtitle:
- '<label-text>Δώστε στα μέλη ακριβώς το επίπεδο πρόσβασης που χρειάζονται με τους νέους ρόλους <strong>μόνο έγκρισης</strong> και <strong>επισκέπτη</strong>.</label-text>',
+ subtitle: '<label-text>Δώστε στα μέλη ακριβώς την πρόσβαση που χρειάζονται με τους νέους ρόλους <strong>μόνο έγκρισης</strong> και <strong>επισκέπτη</strong>.</label-text>',
},
},
card: {
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 0986762c..005385a0 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -2127,7 +2127,6 @@ const translations: TranslationDeepObject<typeof en> = {
},
[CONST.NEXT_STEP.MESSAGE_KEY.NO_FURTHER_ACTION]: (_actor, _actorType, _eta, _etaType) => `¡No se requiere ninguna acción adicional!`,
[CONST.NEXT_STEP.MESSAGE_KEY.CHANGE_WORKSPACE]: (_actor, _actorType, _eta, _etaType) => `Cambia el espacio de trabajo del informe para realizar más acciones.`,
-
[CONST.NEXT_STEP.MESSAGE_KEY.APPROVE_ONLY_SUBMIT_BLOCKED]: (
_actor: string,
_actorType: ValueOf<typeof CONST.NEXT_STEP.ACTOR_TYPE>,
@@ -5391,8 +5390,9 @@ ${amount} para ${merchant} - ${date}`,
newRoles: 'Nuevos roles',
adminRoles: 'Roles de administrador',
otherRoles: 'Otros roles',
- roleSelectorDescription: `Asigna un rol para gestionar los permisos de espacio de trabajo de un miembro. <a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">Comparar roles de espacio de trabajo</a>.`,
- roleSelectorFeedback: '<muted-text-label><centered-text>¿No ves el rol que necesitas? <concierge-link>Dínoslo</concierge-link>.</centered-text></muted-text-label>',
+ roleSelectorDescription: `Asigna un rol para gestionar los permisos del espacio de trabajo de un miembro. <a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">Comparar roles del espacio de trabajo</a>.`,
+ roleSelectorFeedback: '¿No ves el rol que necesitas?',
+ roleSelectorFeedbackLink: 'Cuéntanos',
},
createdForClient: {
title: '¡Has creado un espacio de trabajo para tu cliente!',
@@ -7181,11 +7181,11 @@ ${amount} para ${merchant} - ${date}`,
unassignCard: 'Desasignar tarjeta',
unassignCards: 'Desasignar tarjetas',
unassign: 'Desasignar',
- unassignCardDescription: 'Desasignar esta tarjeta eliminará todas las transacciones no enviadas.',
- unassignCardsDescription: 'Desasignar eliminará todas las transacciones no enviadas de las tarjetas seleccionadas.',
+ unassignCardDescription: 'Al desasignar esta tarjeta se eliminarán todas las transacciones no enviadas.',
+ unassignCardsDescription: 'Al desasignar se borrarán todas las transacciones no enviadas de las tarjetas seleccionadas.',
removeCard: 'Eliminar tarjeta',
remove: 'Eliminar',
- removeCardDescription: 'Eliminar esta tarjeta eliminará todas las transacciones no enviadas.',
+ removeCardDescription: 'Al eliminar esta tarjeta se borrarán todas las transacciones no enviadas.',
assignCard: 'Asignar tarjeta',
cardFeedName: 'Nombre del feed de tarjeta',
cardFeedNameDescription: 'Dale al feed de tarjeta un nombre único para que puedas distinguirlo de los demás.',
@@ -7736,7 +7736,7 @@ El plan Controlar empieza en 9 $ por miembro activo al mes.`,
changeWorkArrangement: 'Cambiar modalidad de trabajo',
newRolesBanner: {
title: 'Nuevos roles disponibles',
- subtitle: '<label-text>Da a los miembros solo el acceso que necesitan con los nuevos roles de <strong>Solo aprobación</strong> e <strong>Invitado</strong>.</label-text>',
+ subtitle: '<label-text>Da a los miembros solo el acceso que necesitan con los nuevos roles de <strong>solo aprobación</strong> e <strong>invitado</strong>.</label-text>',
},
},
accounting: {
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index b0c09e67..1994e954 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -2178,7 +2178,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => `Modifiez l’espace de travail de la note de frais pour effectuer d’autres actions.`,
-
[CONST.NEXT_STEP.MESSAGE_KEY.APPROVE_ONLY_SUBMIT_BLOCKED]: (
_actor: string,
_actorType: ValueOf<typeof CONST.NEXT_STEP.ACTOR_TYPE>,
@@ -5486,9 +5485,9 @@ ${amount} pour ${merchant} - ${date}`,
newRoles: 'Nouveaux rôles',
adminRoles: 'Rôles d’administrateur',
otherRoles: 'Autres rôles',
- roleSelectorDescription: `Assignez un rôle pour gérer les autorisations d’espace de travail d’un membre. <a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">Comparer les rôles d’espace de travail</a>.`,
- roleSelectorFeedback:
- '<muted-text-label><centered-text>Vous ne voyez pas le rôle dont vous avez besoin ? <concierge-link>Dites-le-nous</concierge-link>.</centered-text></muted-text-label>',
+ roleSelectorDescription: `Assignez un rôle pour gérer les autorisations d'espace de travail d’un membre. <a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">Comparer les rôles d’espace de travail</a>.`,
+ roleSelectorFeedback: 'Vous ne voyez pas le rôle dont vous avez besoin ?',
+ roleSelectorFeedbackLink: 'Faites-le nous savoir',
},
createdForClient: {
title: 'Vous avez créé un espace de travail pour votre client !',
@@ -7351,10 +7350,10 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
unassignCards: 'Retirer l’assignation des cartes',
unassign: "Retirer l'assignation",
unassignCardDescription: "Retirer l'assignation de cette carte supprimera toutes les transactions non soumises.",
- unassignCardsDescription: "Retirer l'assignation supprimera toutes les transactions non soumises des cartes sélectionnées.",
+ unassignCardsDescription: 'La suppression de l’assignation supprimera toutes les transactions non soumises des cartes sélectionnées.',
removeCard: 'Supprimer la carte',
remove: 'Supprimer',
- removeCardDescription: 'La suppression de cette carte effacera toutes les transactions non soumises.',
+ removeCardDescription: 'La suppression de cette carte entraînera la suppression de toutes les transactions non soumises.',
assignCard: 'Assigner une carte',
cardFeedName: 'Nom du flux de carte',
cardFeedNameDescription: 'Donnez au flux de carte un nom unique afin de pouvoir le distinguer des autres.',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index c3c0566a..7d8446a2 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2165,7 +2165,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => `Cambia lo spazio di lavoro del rendiconto per ulteriori azioni.`,
-
[CONST.NEXT_STEP.MESSAGE_KEY.APPROVE_ONLY_SUBMIT_BLOCKED]: (
_actor: string,
_actorType: ValueOf<typeof CONST.NEXT_STEP.ACTOR_TYPE>,
@@ -5443,8 +5442,9 @@ ${amount} per ${merchant} - ${date}`,
newRoles: 'Nuovi ruoli',
adminRoles: 'Ruoli amministratore',
otherRoles: 'Altri ruoli',
- roleSelectorDescription: `Assegna un ruolo per gestire le autorizzazioni di spazio di lavoro di un membro. <a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">Confronta i ruoli dello spazio di lavoro</a>.`,
- roleSelectorFeedback: '<muted-text-label><centered-text>Non vedi il ruolo che ti serve? <concierge-link>Faccelo sapere</concierge-link>.</centered-text></muted-text-label>',
+ roleSelectorDescription: `Assegna un ruolo per gestire le autorizzazioni allo spazio di lavoro di un membro. <a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">Confronta i ruoli dello spazio di lavoro</a>.`,
+ roleSelectorFeedback: 'Non vedi il ruolo che ti serve?',
+ roleSelectorFeedbackLink: 'Facci sapere',
},
createdForClient: {
title: 'Hai creato uno spazio di lavoro per il tuo cliente!',
@@ -7281,12 +7281,12 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
unassignCard: 'Rimuovi carta',
unassignCards: 'Rimuovi carte',
unassign: 'Rimuovi assegnazione',
- unassignCardDescription: 'La rimozione dell’assegnazione di questa carta eliminerà tutte le transazioni non inviate.',
- unassignCardsDescription: 'La rimozione dell’assegnazione eliminerà tutte le transazioni non inviate dalle carte selezionate.',
+ unassignCardDescription: 'Rimuovendo l’assegnazione di questa carta verranno eliminate tutte le transazioni non inviate.',
+ unassignCardsDescription: 'La riassegnazione eliminerà tutte le transazioni non inviate dalle carte selezionate.',
assignCard: 'Assegna carta',
removeCard: 'Rimuovi carta',
remove: 'Rimuovi',
- removeCardDescription: 'La rimozione di questa carta eliminerà tutte le transazioni non inviate.',
+ removeCardDescription: 'Rimuovendo questa carta verranno eliminate tutte le transazioni non inviate.',
cardFeedName: 'Nome feed carta',
cardFeedNameDescription: 'Dai al feed della carta un nome univoco, così puoi distinguerlo dagli altri.',
cardFeedTransaction: 'Elimina transazioni',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index dbf60bb0..f2a215e3 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -2144,7 +2144,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => `さらに操作を行うには、レポートのワークスペースを変更してください。`,
-
[CONST.NEXT_STEP.MESSAGE_KEY.APPROVE_ONLY_SUBMIT_BLOCKED]: (
_actor: string,
_actorType: ValueOf<typeof CONST.NEXT_STEP.ACTOR_TYPE>,
@@ -5393,8 +5392,9 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
newRoles: '新しいロール',
adminRoles: '管理者ロール',
otherRoles: 'その他の役割',
- roleSelectorDescription: `メンバーのワークスペース権限を管理するロールを割り当ててください。<a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">ワークスペースロールを比較</a>。`,
- roleSelectorFeedback: '<muted-text-label><centered-text>必要なロールが見つかりませんか?<concierge-link>お知らせください</concierge-link>。</centered-text></muted-text-label>',
+ roleSelectorDescription: `メンバーのワークスペース権限を管理する役割を割り当てます。<a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">ワークスペースの役割を比較する</a>。`,
+ roleSelectorFeedback: '必要なロールが見つかりませんか?',
+ roleSelectorFeedbackLink: 'お知らせください',
},
createdForClient: {
title: 'クライアントのワークスペースを作成しました!',
@@ -7167,11 +7167,11 @@ _詳しい手順については、[ヘルプサイトをご覧ください](${CO
unassignCard: 'カードの割り当てを解除',
unassignCards: 'カードの割り当てを解除',
unassign: '割り当てを解除',
- unassignCardDescription: 'このカードの割り当てを解除すると、未送信の取引はすべて削除されます。',
+ unassignCardDescription: 'このカードの割り当てを解除すると、未提出の取引はすべて削除されます。',
unassignCardsDescription: '割り当てを解除すると、選択したカードの未送信の取引はすべて削除されます。',
removeCard: 'カードを削除',
remove: '削除',
- removeCardDescription: 'このカードを削除すると、未送信のすべての取引が削除されます。',
+ removeCardDescription: 'このカードを削除すると、未提出のすべての取引が削除されます。',
assignCard: 'カードを割り当てる',
cardFeedName: 'カードフィード名',
cardFeedNameDescription: '他のカードフィードと区別できるように、一意の名前を付けてください。',
@@ -7718,7 +7718,7 @@ Control プランは、アクティブメンバー1人あたり月額 $9 から
changeRole: 'ロールを変更',
newRolesBanner: {
title: '新しいロールが利用可能です',
- subtitle: '<label-text>新しく追加された<strong>承認のみ</strong>ロールと<strong>ゲスト</strong>ロールで、メンバーに必要なアクセス権だけを付与できます。</label-text>',
+ subtitle: '<label-text>新しい<strong>承認のみ</strong>ロールと<strong>ゲスト</strong>ロールで、メンバーに必要なアクセス権だけを付与できます。</label-text>',
},
},
card: {
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index a96bc193..34ab05ba 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -2160,7 +2160,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => `Wijzig de werkruimte van het rapport voor verdere acties.`,
-
[CONST.NEXT_STEP.MESSAGE_KEY.APPROVE_ONLY_SUBMIT_BLOCKED]: (
_actor: string,
_actorType: ValueOf<typeof CONST.NEXT_STEP.ACTOR_TYPE>,
@@ -5441,9 +5440,9 @@ ${amount} voor ${merchant} - ${date}`,
newRoles: 'Nieuwe rollen',
adminRoles: 'Beheerrollen',
otherRoles: 'Andere rollen',
- roleSelectorDescription: `Wijs een rol toe om de werkruimterechten van een lid te beheren. <a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">Werkruimterollen vergelijken</a>.`,
- roleSelectorFeedback:
- '<muted-text-label><centered-text>Zie je de rol die je nodig hebt niet? <concierge-link>Laat het ons weten</concierge-link>.</centered-text></muted-text-label>',
+ roleSelectorDescription: `Wijs een rol toe om de werkruimterechten van een lid te beheren. <a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">Vergelijk werkruimterollen</a>.`,
+ roleSelectorFeedback: 'Zie je de rol die je nodig hebt niet?',
+ roleSelectorFeedbackLink: 'Laat het ons weten',
},
createdForClient: {
title: 'Je hebt een werkruimte voor je klant aangemaakt!',
@@ -7268,8 +7267,8 @@ _Voor meer gedetailleerde instructies, [bezoek onze help-site](${CONST.NETSUITE_
unassignCard: 'Kaart loskoppelen',
unassignCards: 'Kaarten loskoppelen',
unassign: 'Toewijzen ongedaan maken',
- unassignCardDescription: 'Het loskoppelen van deze kaart verwijdert alle niet-ingediende transacties.',
- unassignCardsDescription: 'Loskoppelen verwijdert alle niet-ingediende transacties van de geselecteerde kaarten.',
+ unassignCardDescription: 'Als je deze kaart ontkoppelt, worden alle niet-ingediende transacties verwijderd.',
+ unassignCardsDescription: 'De toewijzing ongedaan maken verwijdert alle niet-ingediende transacties van de geselecteerde kaarten.',
removeCard: 'Kaart verwijderen',
remove: 'Verwijderen',
removeCardDescription: 'Als je deze kaart verwijdert, worden alle niet-ingediende transacties verwijderd.',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 0324f85a..ff122b33 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -2204,7 +2204,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => `Zmień przestrzeń roboczą raportu, aby wykonać dalsze działania.`,
-
[CONST.NEXT_STEP.MESSAGE_KEY.APPROVE_ONLY_SUBMIT_BLOCKED]: (
_actor: string,
_actorType: ValueOf<typeof CONST.NEXT_STEP.ACTOR_TYPE>,
@@ -5480,8 +5479,9 @@ ${amount} dla ${merchant} - ${date}`,
newRoles: 'Nowe role',
adminRoles: 'Role administratora',
otherRoles: 'Inne role',
- roleSelectorDescription: `Przydziel rolę, aby zarządzać uprawnieniami członka w przestrzeni roboczej. <a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">Porównaj role w przestrzeni roboczej</a>.`,
- roleSelectorFeedback: '<muted-text-label><centered-text>Nie widzisz potrzebnej roli? <concierge-link>Daj nam znać</concierge-link>.</centered-text></muted-text-label>',
+ roleSelectorDescription: `Przypisz rolę, żeby zarządzać uprawnieniami członka w przestrzeni roboczej. <a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">Porównaj role w przestrzeni roboczej</a>.`,
+ roleSelectorFeedback: 'Nie widzisz potrzebnej roli?',
+ roleSelectorFeedbackLink: 'Daj nam znać',
},
createdForClient: {
title: 'Utworzyłeś przestrzeń roboczą dla swojego klienta!',
@@ -7298,11 +7298,11 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
unassignCard: 'Cofnij przypisanie karty',
unassignCards: 'Cofnij przypisanie kart',
unassign: 'Cofnij przypisanie',
- unassignCardDescription: 'Cofnięcie przypisania tej karty spowoduje usunięcie wszystkich niewysłanych transakcji.',
- unassignCardsDescription: 'Cofnięcie przypisania spowoduje usunięcie wszystkich niewysłanych transakcji z wybranych kart.',
+ unassignCardDescription: 'Odłączenie tej karty spowoduje usunięcie wszystkich nierozliczonych transakcji.',
+ unassignCardsDescription: 'Odłączenie spowoduje usunięcie wszystkich niewysłanych transakcji z wybranych kart.',
removeCard: 'Usuń kartę',
remove: 'Usuń',
- removeCardDescription: 'Usunięcie tej karty spowoduje usunięcie wszystkich niewysłanych transakcji.',
+ removeCardDescription: 'Usunięcie tej karty spowoduje skasowanie wszystkich nierozliczonych transakcji.',
assignCard: 'Przypisz kartę',
cardFeedName: 'Nazwa źródła karty',
cardFeedNameDescription: 'Nadaj kanałowi karty unikalną nazwę, aby odróżnić go od pozostałych.',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index a23e467c..dc93dff7 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -2156,7 +2156,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => `Altere o espaço de trabalho do relatório para realizar outras ações.`,
-
[CONST.NEXT_STEP.MESSAGE_KEY.APPROVE_ONLY_SUBMIT_BLOCKED]: (
_actor: string,
_actorType: ValueOf<typeof CONST.NEXT_STEP.ACTOR_TYPE>,
@@ -5445,9 +5444,9 @@ ${amount} para ${merchant} - ${date}`,
newRoles: 'Novos cargos',
adminRoles: 'Funções de administrador',
otherRoles: 'Outros cargos',
- roleSelectorDescription: `Atribua uma função para gerenciar as permissões de área de trabalho de um membro. <a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">Compare funções de área de trabalho</a>.`,
- roleSelectorFeedback:
- '<muted-text-label><centered-text>Não está vendo a função de que precisa? <concierge-link>Avise a gente</concierge-link>.</centered-text></muted-text-label>',
+ roleSelectorDescription: `Atribua um papel para gerenciar as permissões de área de trabalho de um membro. <a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">Compare funções de área de trabalho</a>.`,
+ roleSelectorFeedback: 'Não está vendo a função que você precisa?',
+ roleSelectorFeedbackLink: 'Conte para a gente',
},
createdForClient: {
title: 'Você criou um espaço de trabalho para seu cliente!',
@@ -7281,11 +7280,11 @@ _Para instruções mais detalhadas, [visite nossa central de ajuda](${CONST.NETS
unassignCard: 'Remover cartão',
unassignCards: 'Remover cartões',
unassign: 'Desatribuir',
- unassignCardDescription: 'Desvincular este cartão excluirá todas as transações não enviadas.',
- unassignCardsDescription: 'Remover a atribuição excluirá todas as transações não enviadas dos cartões selecionados.',
+ unassignCardDescription: 'Desatribuir este cartão vai excluir todas as transações não enviadas.',
+ unassignCardsDescription: 'Desatribuir vai excluir todas as transações não enviadas dos cartões selecionados.',
removeCard: 'Remover cartão',
remove: 'Remover',
- removeCardDescription: 'Remover este cartão excluirá todas as transações não enviadas.',
+ removeCardDescription: 'Remover este cartão vai excluir todas as transações não enviadas.',
assignCard: 'Atribuir cartão',
cardFeedName: 'Nome do feed do cartão',
cardFeedNameDescription: 'Dê um nome exclusivo ao feed do cartão para diferenciá-lo dos outros.',
@@ -7829,8 +7828,8 @@ O plano Control começa em US$ 9 por membro ativo por mês.`,
changeWorkArrangement: 'Alterar regime de trabalho',
changeRole: 'Alterar função',
newRolesBanner: {
- title: 'Novos cargos disponíveis',
- subtitle: '<label-text>Dê aos membros apenas o acesso de que precisam com os novos papéis <strong>Apenas aprovar</strong> e <strong>Convidado</strong>.</label-text>',
+ title: 'Novas funções disponíveis',
+ subtitle: '<label-text>Dê aos membros apenas o acesso que eles precisam com as novas funções <strong>Aprovar apenas</strong> e <strong>Convidado</strong>.</label-text>',
},
},
card: {
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index c2b3fe40..9a5fda7f 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -2083,7 +2083,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => `请更改报告的工作区以执行进一步操作。`,
-
[CONST.NEXT_STEP.MESSAGE_KEY.APPROVE_ONLY_SUBMIT_BLOCKED]: (
_actor: string,
_actorType: ValueOf<typeof CONST.NEXT_STEP.ACTOR_TYPE>,
@@ -5272,8 +5271,9 @@ ${amount},商户:${merchant} - 日期:${date}`,
newRoles: '新角色',
adminRoles: '管理员角色',
otherRoles: '其他角色',
- roleSelectorDescription: `为成员分配一个角色以管理其工作区权限。<a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">比较工作区角色</a>。`,
- roleSelectorFeedback: '<muted-text-label><centered-text>没有找到你需要的角色?<concierge-link>告诉我们</concierge-link>。</centered-text></muted-text-label>',
+ roleSelectorDescription: `为成员分配角色以管理其工作区权限。<a href="${CONST.HELP_DOC_LINKS.WORKSPACE_ROLES_AND_PERMISSIONS}">比较工作区角色</a>。`,
+ roleSelectorFeedback: '没有找到你需要的角色?',
+ roleSelectorFeedbackLink: '告诉我们',
},
createdForClient: {
title: '您已为客户创建了工作区!',
@@ -6996,10 +6996,10 @@ _如需更详细的说明,请[访问我们的帮助网站](${CONST.NETSUITE_IM
unassignCards: '取消分配卡片',
unassign: '取消分配',
unassignCardDescription: '取消分配此卡将删除所有未提交的交易。',
- unassignCardsDescription: '取消分配将删除所选卡片中的所有未提交交易。',
+ unassignCardsDescription: '取消分配将删除所选卡片中所有未提交的交易。',
removeCard: '移除卡片',
remove: '移除',
- removeCardDescription: '移除此卡片将删除所有未提交的交易。',
+ removeCardDescription: '移除此卡将删除所有未提交的交易。',
assignCard: '分配卡片',
cardFeedName: '卡片交易源名称',
cardFeedNameDescription: '为该卡片流水命名一个唯一名称,以便与其他区分。',
@@ -7530,7 +7530,7 @@ _如需更详细的说明,请[访问我们的帮助网站](${CONST.NETSUITE_IM
changeOfficeLocation: '更改办公室位置',
changeWorkArrangement: '更改工作安排',
changeRole: '更改角色',
- newRolesBanner: {title: '新角色已可用', subtitle: '<label-text>使用全新的<strong>仅审批</strong>和<strong>来宾</strong>角色,仅授予成员所需的访问权限。</label-text>'},
+ newRolesBanner: {title: '新角色可用', subtitle: '<label-text>使用新的<strong>仅审批</strong>和<strong>访客</strong>角色,只为成员授予所需的访问权限。</label-text>'},
},
card: {
getStartedIssuing: '从发放您的第一张虚拟卡或实体卡开始使用。',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@daledah ready for review. |
…-new-workspace-roles Signed-off-by: krishna2323 <belivethatkg@gmail.com> # Conflicts: # src/CONST/index.ts
|
@JS00001 All yours as soon as you return. |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.36-0 🚀
|
|
No help site update needed — this PR reorganizes and promotes existing workspace roles without changing the documented role-assignment workflow, releasing a gated feature, or making an existing article inaccurate. |
|
Created Update FullStory for E/A#106052 Promote Approve-only and Guest workspace role discovery, labeled Recommended custom elements for the Concierge link, comparison link, announcement, and promoted-role selection. No new events, user properties, masking, or page-view code needed. The announcement and Members-menu badge remain hidden until Approve-only assignment is enabled. |
|
Deploy Blocker #106606 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
Promotes the new
Approve-onlyandGuestroles:New rolesbadge.newWorkspaceRolesBannerthroughDismissProductTrainingand hides both the banner and the badge.Admin rolesandOther roles,Newbadges onApprove-onlyandGuest, aCompare workspace roleshelp link and aLet us knowConcierge link.The badge and banner show only to admins who can assign both new roles (Control workspaces only), and never in Copilot or Supportal sessions.
The add agent page now picks its default role by role rank, so it stays
Workspace admindespite the new order.Note
Approve-onlyassignment is blocked onmain(#104952), so the badge, the banner and theApprove-onlyrow stay hidden until the block is lifted. To test them, temporarily remove theAPPROVE_ONLYearly return incanMemberAssignRoleinsrc/libs/PolicyUtils/permissions.ts.Fixed Issues
$ #105802
PROPOSAL: N/A
Tests
Use an admin on a Control workspace, with the local revert from the note above.
Membersin the workspace menu has aNew rolesbadge.Membersand verify the banner shows. Dismiss it and verify the banner and the badge both disappear.Role. Verify:Admin roles: Card admin, Payments admin, People admin, Workspace adminOther roles: Approve-only, Auditor, Guest, MemberNewbadges onApprove-onlyandGuestCompare workspace rolesopens the help article andLet us knowopens Concierge.Change role, invite and import.Other rolesshows.Workspace admin.Offline tests
QA Steps
Approve-onlyis still blocked on staging, so the badge, the banner and theApprove-onlyrow won't show yet.Role.Newbadge onGuest.Compare workspace rolesopens the help article andLet us knowopens Concierge.Other rolesshows.New rolesbadge or banner.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_hybrid.mp4
Android: mWeb Chrome
android_native.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_mWeb.mp4
MacOS: Chrome / Safari
web_chrome.mp4