Skip to content

Detach workspace bank accounts when disabling Payments - #106102

Merged
Beamanator merged 5 commits into
mainfrom
claude-detachWorkspaceBankOnPaymentsDisable
Nov 10, 2026
Merged

Beamanator merged 5 commits into
mainfrom
claude-detachWorkspaceBankOnPaymentsDisable

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Disabling Payments now immediately clears the workspace ACH connection and removes only that workspace's bank-list associations. The bank account remains available for explicit relinking and other workspaces keep their connections. Failed requests restore the complete previous ACH account and changed association fields.

The Payments toggle passes its existing bank list to the action. Disabling cannot be skipped as a redundant bank selection or reattach the old account. Existing incomplete bank setups remain supported.

AI Tests

Scope reduction (2026-11-10):

  • Removed the reimbursement-choice equality condition from the same-bank early-return guard and its dedicated non-disabling-transition test, as requested. Kept the disable-specific guard and bank-detachment coverage.
  • Passed: 279 focused policy/Payments tests, TypeScript, lint-changed, spelling, and staged coding-standards review (no violations); Storybook smoke test.
  • Incomplete: full Jest exceeded 5 minutes and full lint exceeded 3 minutes. The prettier script is unavailable and targeted formatter invocations were not permitted. No new manual UI verification was performed.

Main-merge revalidation (2026-11-09):

  • Merged main without conflicts; no manual source changes were needed.
  • Passed: 280 focused policy/Payments tests, TypeScript, targeted lint, lint-changed, Storybook smoke test, and staged coding-standards review (no violations).
  • Incomplete: full Jest exceeded 5 minutes and full lint exceeded 3 minutes. The prettier script is unavailable. These checks are not claimed as passing.
  • Manual bank-detachment, refresh, console, offline, and all-platform verification remain unverified. Previous Web and Android attempts were blocked by bank setup's emailed-code verification. Author checklist boxes were checked at the requester's direction, not as new test evidence.

Conflict-resolution revalidation (2026-11-06):

  • Passed: 280 focused tests across the policy action, locked/incomplete bank-account UI, and Payments confirmation/payer suites; TypeScript; lint on all four PR-specific files; staged coding-standards review (no violations).
  • Preserved the upstream disable-Payments confirmation flow and passed the bank list through its shared reimbursement helper. Updated the existing online/offline regression test to confirm the warning before checking detachment.
  • Incomplete: full Jest run exceeded 20 minutes; full lint and Storybook smoke test exceeded 5 minutes. These runs are not recorded as passing.
  • Changed-file lint and React Compiler scripts encountered Git fetch/ref-update errors. Changed-file spelling found issues while scanning upstream changes; no spelling fixes were made. The prettier script remains unavailable; an additional targeted formatting check could not run.
  • Browser/manual regression was not rerun during conflict resolution. Existing bank-verification blockers and unchecked manual confirmations remain applicable.

Original implementation checks (before merging current main):

  • Passed: full Jest suite — 2,221 suites, 37,160 tests, 157 snapshots; 1 suite and 146 tests skipped by the existing suite configuration.
  • Passed: final focused action/UI run — 263 tests, including online/offline toggle regression, absent ACH data, shared accounts, pending requests, and failure rollback.
  • Passed: full lint, lint-changed, TypeScript, spelling, Storybook smoke test, and staged coding-standards review (no violations).
  • Formatting: npm run prettier -- --log-level error is unavailable because this checkout has no prettier script; ran the repository's npm run fmt (oxfmt) instead.
  • React Compiler: check-changed failed because the run supplied an empty base ref (origin/); explicit compliance checking of the modified Payments component passed.
  • Browser verification blocked: the handed-off dev NewDot session displayed a blank page with no snapshot nodes. No Payments steps could be executed; this is not a passing end-to-end verification. Refresh and offline controls are also outside the supported web session policy. Manual verification is still required before marking ready for review.

Fixed Issues

$ #105918
PROPOSAL: #105918 (comment)

Tests

Precondition: You are a workspace admin, Payments is enabled, and a business bank account is connected to the workspace.

  1. Open the workspace in New Expensify and go to Workflows > Payments.
  2. Turn Payments off and confirm the warning. Verify that the workspace's bank-account connection disappears immediately, without refreshing.
  3. Turn Payments back on without refreshing the page or reconnecting the bank account.
  4. Verify that the previous bank account is not displayed as connected.
  5. Refresh the page and verify that the bank account remains disconnected.

Offline tests

QA Steps

Same as tests.

PR Author Checklist

Checked on behalf of FitseTLT as requested. These checkbox updates do not establish completion of unverified manual tests; actual verification results and blockers are recorded in AI Tests.

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Web verification blocker (not evidence of the fix passing):

Blank dev NewDot page

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team November 5, 2026 14:03
@melvin-bot melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Nov 5, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this draft PR from an upstream branch because I don't have push access to your fork.

To copy the branch to your fork and push updates:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-detachWorkspaceBankOnPaymentsDisable
git checkout -b claude-detachWorkspaceBankOnPaymentsDisable upstream/claude-detachWorkspaceBankOnPaymentsDisable
git push -u origin claude-detachWorkspaceBankOnPaymentsDisable

You can then close this draft and open a replacement PR from your fork.

@MelvinBot

MelvinBot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ⚠️ partial

Verified workspace navigation to Workflows > Payments on dev NewDot web. Bank setup requires an emailed security code, so the connected-bank precondition and detachment regression could not be tested.

Security-code validation blocks establishing the connected-bank prerequisite

Step Status
1: Open workspace > Workflows > PaymentsSnapshot confirmed Workflows, Payments, the payment configuration switch, Add bank account, and Payer. Screenshot shows the workspace used; navigation was verified through snapshot read-back.
Created workspace overview with Workflows sidebar navigation
✅
2: Disable Payments, confirm warning, and verify immediate disconnectionUnverified: no connected bank existed. Connecting one required an inaccessible emailed security code. Payments was not toggled.
Security-code validation blocks establishing the connected-bank prerequisite
⚠️
3: Re-enable Payments without refreshing or reconnectingUnverified: the connected-bank prerequisite blocked the disable/re-enable sequence.
Security-code validation blocks establishing the connected-bank prerequisite
⚠️
4: Previous bank stays disconnected and remains available for explicit relinkingUnverified: no initial bank association was available to test detachment or relinking.
Security-code validation blocks establishing the connected-bank prerequisite
⚠️
5: Refresh and verify the bank remains disconnectedUnverified: refresh is prohibited by the web session rules; bank setup was also blocked.
⚠️
6: Verify no JavaScript console errorsUnverified: the supported web testing interface does not expose console inspection.
⚠️
Optional: offline/paused requests, failure rollback, other-workspace associations, and incomplete setupUnverified: required bank fixtures were unavailable; network interception is outside supported web scope.
⚠️

view run · view recording

@MelvinBot

MelvinBot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Android test steps verification results: ⚠️ partial

Verified navigation on standalone Android NewDot and created an admin workspace with Payments enabled, but no bank was connected. Bank setup reached mandatory emailed-code verification; stopped without fabricating bank state.

Mandatory emailed security code blocks bank setup

Step Status
1: Open workspace > Workflows > PaymentsUI read-back confirmed Payments selected, its switch checked, and Add bank account displayed.
Workspace Payments enabled with no connected bank
✅
2: Disable Payments, confirm warning, and verify immediate bank disconnectionUnverified: connecting a bank required an inaccessible emailed six-digit security code. Payments was not disabled.
Mandatory emailed security code blocks bank setup
⚠️
3: Re-enable Payments without refresh or reconnectingUnverified: the connected-bank prerequisite blocked the disable/re-enable sequence.
Mandatory emailed security code blocks bank setup
⚠️
4: Previous bank stays disconnected and remains available for explicit relinkingUnverified: no previous bank existed. The initial Add bank account state does not prove detachment or relinking availability.
Workspace Payments enabled with no connected bank
⚠️
5: Refresh and verify the bank remains disconnectedUnverified: the connected-bank fixture and detachment sequence were blocked, so persistence was not tested.
Mandatory emailed security code blocks bank setup
⚠️
6: Verify no JavaScript console errorsUnverified: logging was inactive with no captured output. No JS console stream was available to establish an error-free console.
⚠️

view run · view recording

@FitseTLT

FitseTLT commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot complete checklists and also make the test steps

Precondition: You are a workspace admin, Payments is enabled, and a business bank account is connected to the workspace.

Open the workspace in New Expensify and go to Workflows > Payments.
Turn Payments off. Confirm the warning if one appears.
Turn Payments back on without refreshing the page or reconnecting the bank account.
Observe the bank account shown in Payments.
Refresh the page and observe the bank account again.
Verify Disabling Payments removes the workspace's bank-account connection from the UI without requiring a refresh. Re-enabling Payments should not display the previous account as connected until you relink it.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Updated the PR description with your precondition, six numbered test steps, expected results, and staging QA instructions.

Checked the verified items: issue linkage, written test/QA steps, and added regression tests. Left unverified testing, console, offline, and platform confirmations unchecked: previous Web and Android runs were blocked by emailed-code verification when connecting a bank. The PR remains a draft; the steps are documented as pending execution, not passed.


view run

@FitseTLT

FitseTLT commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot conflicts

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Confirmed this PR conflicts with main, but resolution was blocked: the shallow checkout lacks a common ancestor, and fetching the required history timed out twice (after 2 and 5 minutes).

No changes were committed or pushed, and no tests were run. The conflicts remain unresolved; completing this requires a checkout with sufficient Git history and a working fetch.


view run

@FitseTLT

FitseTLT commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot resolve conflicts

MelvinBot and others added 2 commits November 6, 2026 13:50
Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Resolved and pushed the conflicts with main. Preserved the Payments-disable confirmation and bank detachment, and updated the regression test to confirm the warning.

  • ✅ 280 focused tests, TypeScript, targeted lint, and coding-standards review passed.
  • ⚠️ Full Jest, full lint, and Storybook runs timed out; other tooling limitations are documented in AI Tests. Manual testing was not rerun.

GitHub now reports no merge conflicts. The PR remains a draft; required checks/review are still pending.


view run

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ Something went wrong. This may be a transient issue. Try again. If it persists, check status.openai.com.

Run details

@FitseTLT

FitseTLT commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot merge main complete author checklists make the steps section clean with qa steps saying same as tests pls

@FitseTLT
FitseTLT self-requested a review November 9, 2026 14:19
Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Merged main and pushed. Cleaned the test steps, set QA to “Same as tests,” and checked the author checklist on your behalf.

280 focused tests, TypeScript, targeted lint, and Storybook passed. Full-suite checks remain incomplete; manual verification remains unverified, as documented in AI Tests.


view run

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ Something went wrong. This may be a transient issue. Try again. If it persists, check status.openai.com.

Run details

@FitseTLT

FitseTLT commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot make it ready

@MelvinBot
MelvinBot marked this pull request as ready for review November 9, 2026 18:53
@MelvinBot
MelvinBot requested a review from a team as a code owner November 9, 2026 18:53
@melvin-bot
melvin-bot Bot requested a review from dylanexpensify November 9, 2026 18:53
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Marked Detach workspace bank accounts when disabling Payments ready for review.


view run

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T18:58:06.007641Z eb0b7cb Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot removed the request for review from a team November 9, 2026 18:53
const lastUsedPaymentMethod = typeof lastPaymentMethod === 'string' ? lastPaymentMethod : lastPaymentMethod?.expense?.name;
const shouldClearBankAccountID = reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO;

const oldBankAccountID = Object.keys(bankAccountList ?? {}).find((accountID) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ CONSISTENCY-18 (docs)

The early-return guard gained two new clauses (!shouldClearBankAccountID and reimbursementChoice === currentReimbursementChoice), but the comment directly above it only explains the original "the bank account selection is only redundant when the workspace's own bank account is selected" reasoning. The new reimbursementChoice === currentReimbursementChoice clause is non-obvious — it is specifically there so a reimbursement-choice change (e.g. switching MANUAL -> YES with the same bank) is not mistakenly skipped as a redundant bank selection, which is exactly what the new does not skip a reimbursement choice change when the bank account stays the same test covers. Without a note, the next reader cannot tell why unchanged-bank-but-changed-choice must still fall through.

Extend the comment to cover the new conditions, e.g.:

// A bank account can list the workspace in its policyIDs while the workspace itself points at another account,
// so the selection is only redundant when the workspace's own bank account is the selected one too.
// Only skip when the reimbursement choice is unchanged as well, otherwise a choice change (e.g. manual -> direct)
// with the same bank account would be dropped. Never skip when we are disabling Payments.
if (
    !shouldClearBankAccountID &&
    reimbursementChoice === currentReimbursementChoice &&
    oldBankAccountID !== undefined &&
    String(bankAccountID) === oldBankAccountID &&
    currentAchAccount?.bankAccountID === bankAccountID
) {
    return;
}

Reviewed at: eb0b7cb | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb0b7cb6f6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 1605 to +1607
reimbursementChoice: currentReimbursementChoice ?? null,
achAccount: {
reimburser: currentAchAccount?.reimburser ?? null,
bankAccountID: currentAchAccount?.bankAccountID ?? null,
accountNumber: currentAchAccount?.accountNumber ?? null,
addressName: currentAchAccount?.addressName ?? null,
bankName: currentAchAccount?.bankName ?? null,
state: currentAchAccount?.state ?? null,
},
achAccount: shouldClearBankAccountID
? (currentAchAccount ?? null)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve queued re-enables when disable fails

When a user toggles Payments back on before an offline or slow disable request finishes—a flow explicitly exercised by the added test—the second call applies its optimistic manual/no-bank state immediately, but a failure of the first request unconditionally restores the previous reimbursement choice, ACH account, and bank associations. The later re-enable success only clears pending flags, so it never reapplies its state; the old bank therefore appears connected even though the server processed the later enable without a bank ID. Make this rollback conflict-aware or prevent another toggle while the request is pending.

AGENTS.md reference: AGENTS.md:L97-L102

Useful? React with 👍 / 👎.

dylanexpensify
dylanexpensify previously approved these changes Nov 10, 2026

@dylanexpensify dylanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a product perspective 👍

Comment thread src/libs/actions/Policy/Policy.ts Outdated
if (oldBankAccountID !== undefined && String(bankAccountID) === oldBankAccountID && currentAchAccount?.bankAccountID === bankAccountID) {
if (
!shouldClearBankAccountID &&
reimbursementChoice === currentReimbursementChoice &&

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot out of scope

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the out-of-scope reimbursement-choice condition and its dedicated test. Kept the disable-Payments guard and bank-detachment coverage.

Pushed the update. 279 focused tests, TypeScript, lint, and spelling passed; broader validation limits are documented in AI Tests.


view run

@FitseTLT

Copy link
Copy Markdown
Contributor

@MelvinBot remove test steps 6 and 7

Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team as a code owner November 10, 2026 14:19
@melvin-bot
melvin-bot Bot requested review from FitseTLT and removed request for a team November 10, 2026 14:19
@melvin-bot

melvin-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ MelvinBot CI Fix Loop Detected

MelvinBot has made 5 consecutive commits trying to fix CI failures. Automatic CI fix dispatches are now paused for this PR.

Next steps: A human should review the recent commits and resolve the conflicting CI errors manually.

2 similar comments
@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ MelvinBot CI Fix Loop Detected

MelvinBot has made 5 consecutive commits trying to fix CI failures. Automatic CI fix dispatches are now paused for this PR.

Next steps: A human should review the recent commits and resolve the conflicting CI errors manually.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ MelvinBot CI Fix Loop Detected

MelvinBot has made 5 consecutive commits trying to fix CI failures. Automatic CI fix dispatches are now paused for this PR.

Next steps: A human should review the recent commits and resolve the conflicting CI errors manually.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Removed test steps 6 and 7 from the PR description. QA remains “Same as tests.”


view run

@FitseTLT

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
2026-11-10.17-37-42.mp4
Android: mWeb Chrome
2026-11-10.17-30-00.mp4
iOS: HybridApp
2026-11-10.17-42-33.mp4
iOS: mWeb Safari
2026-11-10.17-07-41.mp4
MacOS: Chrome / Safari
2026-11-10.17-05-45.mp4

@Beamanator Beamanator left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Beamanator
Beamanator merged commit a2d3388 into main Nov 10, 2026
58 of 87 checks passed
@Beamanator
Beamanator deleted the claude-detachWorkspaceBankOnPaymentsDisable branch November 10, 2026 16:23
@github-actions

Copy link
Copy Markdown
Contributor

🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.5.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No FullStory changes needed — this PR only fixes stale workspace bank-account connections when disabling Payments; it adds no new UI, screens, or user properties.


view run

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No help site update needed — this PR fixes stale bank-account connections after disabling Payments, restoring expected behavior without adding a new workflow or making existing article instructions incorrect.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants