Repository navigation
Conversation
Move the drag, snap, click-reset and live CSS width logic out of RHPResizeHandle into a generic PaneResizeHandle, the persisted width clamping into usePaneWidth, and the CSS variable helpers into createLiveSizeVariable, so other right-docked panes can reuse them. The pane handle constants move from RHP_RESIZE to RESIZE_HANDLE. RHP behavior is unchanged.
Behind the new web-only resizableSidePanel beta, drag the side panel's left edge on wide layouts to resize it, from the default width up to the widest single RHP. Releasing near the default snaps to it and a click resets it. The width is saved per device in the sidePanelWidth Onyx key and clamped to the window at render. Mid-drag the width lives in the --side-panel-width CSS variable. The page beside a docked panel is inset by that width times --side-panel-dock-progress, which a listener on the open/close Animated value writes, so neither the drag nor the open animation renders the page's cards.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@MelvinBot review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Review findings
Validation: Both targeted Jest suites passed: 18 tests total. Findings are based on code tracing; browser behavior was not verified. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7404e60faf
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
- Merge SidePanelWidth and SingleRHPWidth actions into PaneWidth - Share one PaneWidthBounds type across both panes - Let PaneResizeHandle save and reset through an Onyx key, and key its shared drag by the LiveSizeVariable - Expose the side panel width and beta from the side panel context so consumers stop re-checking the beta - Move dock-progress CSS syncing into useSidePanelDockProgress - Let SidePanelResizeHandle gate itself on beta and layout
While a wide or super-wide RHP is open beside a docked panel, cap the panel's width so the RHP card still fits in the window. The cap is applied at render, so the dragged width comes back once the RHP closes. The resize handle reads the same capped bounds from the side panel context.
A width that changed while the panel was hidden, or while it slid out, left the panel waiting off-screen at the old width, so the next open started partly on screen or stayed hidden for part of the animation.
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@ikevin127 I think @Krishna2323 will take this one as he already worked on resizable RHP and table columns, but we're waiting for confirmation. Sorry for the confusion 🙏 |
|
Assigned this PR to Krishna because he's working on the project and I forgot to assign them to the issue. |
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Krishna2323
left a comment
There was a problem hiding this comment.
NAB: Test 1 step 5 says the panel "doesn't go narrower than its default width", but with the 400px default the panel can still be dragged down to 375px (variables.sidePanelWidth), which matches the issue. Could you update the step to say it doesn't go narrower than 375px, so QA doesn't flag that as a bug?
|
At max width, the docked panel leaves almost no room for the chat beside it. The max width reuses the single RHP's limit (885px), but the RHP floats over the page while the docked panel pushes it aside. This means the page has to fit within At a ~1490px window width, the chat is only ~180px wide, and the composer wraps one letter per line. Near the 1300px docking breakpoint, it's even worse. This gets worse as more features roll out. With the cc @Expensify/design: Should the docked panel have a minimum width for the page beside it? Monosnap.screencast.2026-11-10.06-32-07.mp4 |
Yeah good shout. I wouldn't expect the main content to go smaller than 400 or so!? With that we at least ensure that the mobile sizes we design for works, but curious what @Expensify/design thinks too |
|
Yup, totally agree there, and Jon's suggestion sounds reasonable to me. |
|
Sounds great to me too. Let's get it updated. |
|
All suggestions applied, @Krishna2323 PR's all yours |
|
@war-in With the 400px floor, the chat no longer collapses, but the central pane still uses its wide-layout styles at 400px. The duplicate banner wraps one word per line, table columns get cut off.
I think this should be handled in a follow-up issue rather than here. @JS00001 WDYT? cc @Expensify/design: Would it make sense for the central pane to switch to narrow (mobile) styles once it gets this narrow, using the breakpoints we already have?
|
Yes, it would - assuming we can pull it off with a smooth transition. |
Agree with @Krishna2323 that this doesn't belong here. This issue already exists on prod, though a little bit less visible. We can handle it in a followup 😄
|
|
@MelvinBot please create a follow-up issue and assign it to @Krishna2323, @war-in and @JS00001. When the docked side panel (or the LHN) leaves the central pane narrow, the pane continues using its wide-layout styles. For example, at ~400px, the duplicate banner wraps one word per line and the report table columns get cut off.
Expected: The central pane should switch to narrow (mobile) styles once it gets narrow enough, with a smooth transition.
|
|
Created Web - Central pane retains wide-layout styles when narrowed by docked side panel or LHN and assigned it to Included reproduction steps, screenshot, technical context, and the smooth-transition requirement. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safariweb_chrome.mp4 |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #105900 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 pecanoro has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.5.36-0 🚀
|
|
No help site update needed — side-panel resizing remains behind the |
|
Created Update FullStory for E/A#106105 Resizable Concierge side panel drag and reset, labeled Recommended one custom element for the Concierge resize/reset handle (high confidence). No additional events, user properties, masking, or page-view changes are needed. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀
Bundle Size Analysis (Sentry): |


Explanation of Change
With the new web-only
resizableSidePanelbeta on, users can drag the Concierge side panel's left edge on wide layouts. The width goes from the default up to the widest single RHP. It snaps to the default and resets on click, and it's saved per device. The drag updates only CSS variables. The RHP handle logic moves into a sharedPaneResizeHandle.Fixed Issues
$ #105900
PROPOSAL:
Tests
Prerequisite: an account with the
resizableSidePanelbeta, on web.Test 1: Docked panel
col-resizeand a green line shows just outside the panel's left border.Test 2: Panel over the page, and window resizing
Test 3: RHP next to the panel
resizableRHPbeta on, drag the RHP's left edge.Offline tests
Same as tests. The width is stored only on the device, so resizing works offline.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari