Repository navigation
Conversation
melvin-bot
Bot
requested review from
trjExpensify
and removed request for
a team
November 5, 2026 22:56
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
New standalone invoices are now named
Invoice #<short reportID>, for exampleInvoice #R00SK9Qpc9BY, for both the sender and the receiver (context).buildOptimisticInvoiceReportgives a new invoice the sameInvoice #<ID>name that Auth stores. It usesgetBase62ReportIDon the reportID that App sends withSendInvoice, and Auth keeps that reportID. If the sender's policy enforces its report title formula, the formula name replaces it afterSendInvoicereturns.reportNamefor every invoice, including invoices sent from New Expensify. It shows the computed<payer> owes <amount>name only when the stored name is empty. This coverscomputeReportNameand the derived report attributes (Inbox, report header, report preview title) andgetChatListItemReportName(Search). Search rows already showed the stored name.Invoice <date>or the policy's title formula, instead of<payer> owes <amount>.isNewDotInvoicehelper.This depends on Auth https://github.com/Expensify/Auth/pull/26376, which names new invoices
Invoice #<ID>. Without it, the optimistic name changes to the old server name whenSendInvoicereturns. Web https://github.com/Expensify/Web-Expensify/pull/58032 names invoices created in Classic the same way.App #105968 (#105968) shows the stored name only for invoices linked to a bill. Whichever PR merges second must remove that special case, because this PR covers every invoice.
Fixed Issues
For https://github.com/Expensify/Expensify/issues/684654
PROPOSAL:
Tests
Invoice #Rfollowed by 11 characters in the Inbox, the report header and the report preview in the invoice room.Offline tests
Invoice #R...in the Inbox, the report header and the report preview.QA Steps
Invoice #R...in the Inbox, the report header, the report preview and Search.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari