Skip to content

[HOLD Auth#26376] Show the stored name of every invoice and name new invoices Invoice #<ID> - #106155

Open
cead22 wants to merge 1 commit into
mainfrom
carlos-standalone-invoice-name
Open

cead22 wants to merge 1 commit into
mainfrom
carlos-standalone-invoice-name

Conversation

@cead22

@cead22 cead22 commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

New standalone invoices are now named Invoice #<short reportID>, for example Invoice #R00SK9Qpc9BY, for both the sender and the receiver (context).

  • buildOptimisticInvoiceReport gives a new invoice the same Invoice #<ID> name that Auth stores. It uses getBase62ReportID on the reportID that App sends with SendInvoice, and Auth keeps that reportID. If the sender's policy enforces its report title formula, the formula name replaces it after SendInvoice returns.
  • App now shows the stored reportName for every invoice, including invoices sent from New Expensify. It shows the computed <payer> owes <amount> name only when the stored name is empty. This covers computeReportName and the derived report attributes (Inbox, report header, report preview title) and getChatListItemReportName (Search). Search rows already showed the stored name.
  • Existing invoices sent from New Expensify now show their stored name, usually Invoice <date> or the policy's title formula, instead of <payer> owes <amount>.
  • Removes the unused isNewDotInvoice helper.

This depends on Auth https://github.com/Expensify/Auth/pull/26376, which names new invoices Invoice #<ID>. Without it, the optimistic name changes to the old server name when SendInvoice returns. Web https://github.com/Expensify/Web-Expensify/pull/58032 names invoices created in Classic the same way.

App #105968 (#105968) shows the stored name only for invoices linked to a bill. Whichever PR merges second must remove that special case, because this PR covers every invoice.

Fixed Issues

For https://github.com/Expensify/Expensify/issues/684654
PROPOSAL:

Tests

  1. Log in as an admin of a policy that has invoices on and no enforced report title formula.
  2. Send an invoice to another user.
  3. Verify the new invoice is named Invoice #R followed by 11 characters in the Inbox, the report header and the report preview in the invoice room.
  4. Go to Spend and open the invoices list.
  5. Verify the invoice row shows the same name.
  6. Log in as the receiver.
  7. Verify the receiver sees the same name in the Inbox, the report header and Search.
  8. Open an invoice sent before this change.
  9. Verify it shows its stored name.
  10. Enforce the report title formula on the policy.
  11. Send an invoice.
  12. Verify the invoice shows the formula name after it syncs.
  • Verify that no errors appear in the JS console

Offline tests

  1. Turn off your network connection.
  2. Send an invoice.
  3. Verify the new invoice shows Invoice #R... in the Inbox, the report header and the report preview.
  4. Turn on your network connection.
  5. Verify the name stays the same after the invoice syncs.

QA Steps

  1. Log in as an admin of a policy that has invoices on and no enforced report title formula.
  2. Send an invoice to another user.
  3. Verify the new invoice is named Invoice #R... in the Inbox, the report header, the report preview and Search.
  4. Log in as the receiver.
  5. Verify the receiver sees the same name.
  6. Open an invoice sent before this change.
  7. Verify it shows its stored name.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@cead22
cead22 requested review from a team as code owners November 5, 2026 22:56
@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team November 5, 2026 22:56
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T23:00:28.597859Z a259b02 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from mollfpr and removed request for a team November 5, 2026 22:56
@melvin-bot

melvin-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@cead22 cead22 changed the title Show the stored name of every invoice and name new invoices Invoice #<ID> [HOLD Auth#26376] Show the stored name of every invoice and name new invoices Invoice #<ID> Nov 5, 2026
@cead22
cead22 removed the request for review from mollfpr November 6, 2026 02:15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant