Repository navigation
[No QA] Refractor Members pages for help site - #106171
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
HelpDot Documentation ReviewOverall AssessmentThis PR refactors a single large article (Managing-Workspace-Members.md) into three focused articles: Invite Members to a Workspace, Manage Workspace Members and Access, and Understand Workspace Roles and Permissions. The split is a strong structural improvement that aligns with the one-primary-workflow-per-article principle, and the new articles add proper YAML metadata including internalScope. However, the diff contains several blocking defects: a filename with a space that breaks cross-links, inconsistent internal links, multiple typos, malformed bold navigation paths, h3 headings that violate the heading rules, and a malformed table. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
@justinpersaud @joekaufmanexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
A preview of your ExpensifyHelp changes have been deployed to https://259de0b6.helpdot.pages.dev ⚡️ Updated articles: |
@stephanieelliott i noticed in OP of the issue, there is a reference to linking this new article to the existing trans ownership transfer article, but I don't see that in the draft article. Is that intentional? |
|
@joekaufmanexpensify it was intentional, but on second thought I decided may as well add it! Added a new section for this called |
|
@stephanieelliott the PR has conflicts. Could you resolve before I approve/merge? |
# Conflicts: # docs/articles/new-expensify/workspaces/Managing-Workspace-Members.md # docs/redirects.csv
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.5.37-0 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.37-1 🚀
Bundle Size Analysis (Sentry): |
See: https://github.com/Expensify/Expensify/issues/700790