Skip to content

Fix Android crash when a touched view is deleted and created again - #106278

Merged
mountiny merged 4 commits into
Expensify:mainfrom
David-2002065:fix/104743-deferred-touch-delete-APP-7AR
Nov 17, 2026
Merged

mountiny merged 4 commits into
Expensify:mainfrom
David-2002065:fix/104743-deferred-touch-delete-APP-7AR

Conversation

@David-2002065

@David-2002065 David-2002065 commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

When a view is deleted while it's being touched, Android SurfaceMountingManager keeps its ViewState and queues the delete until the finger is lifted. If the same tag is created again before that (the view flattens and unflattens under the finger), createView finds the old ViewState, returns early and leaves the queued delete in place. On finger up the queued delete runs against the live view and wipes its ViewState, so the next insert of that tag is skipped and the sibling inserted after it crashes with addViewAt: failed to insert view [N] into parent [M] at index 1 (index=1 count=0).

This adds react-native patch +050, which makes createView finish the pending delete of the old ViewState first and then create the view normally. The tag stays in viewsWithActiveTouches, so if the new view is deleted while still touched, the delete is deferred like before.

Fixed Issues

$ #104743
PROPOSAL: #104743 (comment)

Tests

Android native:

  1. Temporarily use the repro screen from the proposal as the app entry (under "Reproduction")
  2. Hold a finger on the red box for about 1.5s (adb shell input swipe 540 800 540 800 1500)
  3. Verify the app doesn't crash and the red and green boxes are still shown after release
  4. Quickly tap the red box (adb shell input tap 540 800) and verify the same
  5. Restore the normal entry, press and hold on LHN rows and buttons while switching tabs, and verify press states and navigation work and the app doesn't crash
  • Verify that no errors appear in the JS console

Offline tests

Same as tests, the change is not network related.

QA Steps

The crash has no organic repro, so this is a regression check on Android native:

  1. Press and hold on LHN rows, buttons and list items while switching between Inbox, Reports and Workspaces
  2. Verify press states, scrolling and navigation work as before and the app doesn't crash
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

The crash has no in-app repro, so Before/After use the repro screen from the proposal (holding the red box for about 1.5s). The last video is the real app on the patched build.

Before:

android-before.mp4

After:

android-after.mp4

Real app on the patched build:

android-app.mp4
Android: mWeb Chrome
mweb-chrome.mp4
iOS: Native
ios-native.mp4
iOS: mWeb Safari
mweb.mp4
MacOS: Chrome / Safari
web-chrome.mp4

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@David-2002065

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T06:57:59.793146Z 03a2b86 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 03a2b86963

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@David-2002065
David-2002065 marked this pull request as ready for review November 7, 2026 06:43
@David-2002065
David-2002065 requested a review from a team as a code owner November 7, 2026 06:43
@melvin-bot
melvin-bot Bot requested review from marufsharifi and removed request for a team November 7, 2026 06:43
@melvin-bot

melvin-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown

@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@marufsharifi

Copy link
Copy Markdown
Contributor

@David-2002065, please check the ai comment. thanks.

@David-2002065

David-2002065 commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor Author

@marufsharifi replied in the thread, i don't think it needs a change

@marufsharifi

marufsharifi commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen_Recording_20261107_164055_Expensify.Dev.mp4
Android: mWeb Chrome
Screen_Recording_20261107_164541_Chrome.mp4
iOS: HybridApp
Screen.Recording.2026-11-07.at.5.35.33.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-11-07.at.5.24.18.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-07.at.5.44.54.PM.mov

@mountiny

mountiny commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

how is this looking?

@marufsharifi

Copy link
Copy Markdown
Contributor

how is this looking?

I will finalize this today. thanks.

@marufsharifi

Copy link
Copy Markdown
Contributor

@David-2002065, could you please merge the main. thanks.

@David-2002065

Copy link
Copy Markdown
Contributor Author

merged main, thanks

@marufsharifi marufsharifi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot
melvin-bot Bot requested a review from mountiny November 9, 2026 11:55
Comment thread patches/react-native/details.md Outdated
- Reason: Fixes the fatal `IllegalStateException: addViewAt: failed to insert view [N] into parent [M] at index 1` (`IndexOutOfBoundsException: index=1 count=0`) behind `APP-7AR`. When a view is deleted while it is touched, `SurfaceMountingManager.deleteView` keeps its `ViewState` and queues the tag in `viewsToDeleteAfterTouchFinishes` until the touch ends. If the same tag is mounted again before that (a view flattens and unflattens under the finger), `createView` sees the old `ViewState`, returns early and never clears the queued delete. On finger-up `sweepActiveTouchForTag` runs the stale delete and wipes the `ViewState` of the live view. The next `Insert` of that tag is skipped with `Unable to find viewState for tag`, so its parent is one child short and the next sibling's `Insert` at index 1 throws. `IntBufferBatchMountItem` is not retryable, so the app crashes. The patch makes `createView` finish the pending delete of the old `ViewState` first and then create the view normally, so the queued delete can no longer hit the new view and the `Create` applies its own props. The tag stays in `viewsWithActiveTouches`, so if the new view is deleted again while still touched, the delete is deferred as before. The old view was already detached by the `Remove` that came before its `Delete`, so dropping it does not change what is on screen. It closes one of the "delayed deletes during touches" sources listed for `+045` and `+047`.
- Upstream PR/issue: none yet. `main`, `0.87` and `0.88` have the same code (`viewsToDeleteAfterTouchFinishes` is never cleared in `createView`). The deferred delete itself comes from [react-native#44610](https://github.com/facebook/react-native/issues/44610) / [react-native#45126](https://github.com/facebook/react-native/issues/45126).
- E/App issue: https://github.com/Expensify/App/issues/104743
- PR introducing patch: this PR.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link here please

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the link, also renamed the patch to +050 since main got its own +049 in the meantime

- Upstream PR/issue: none yet. `main`, `0.87` and `0.88` have the same code (`viewsToDeleteAfterTouchFinishes` is never cleared in `createView`). The deferred delete itself comes from [react-native#44610](https://github.com/facebook/react-native/issues/44610) / [react-native#45126](https://github.com/facebook/react-native/issues/45126).
- E/App issue: https://github.com/Expensify/App/issues/104743
- PR introducing patch: this PR.
- 0.86.0 migration note: drop this patch once the adopted React Native release clears the deferred delete when the tag is created again.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thesahindia

Copy link
Copy Markdown
Member

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-11-16.at.3.02.10.PM.mov
Screen.Recording.2026-11-16.at.1.51.02.PM.mov
Android: mWeb Chrome
Screen.Recording.2026-11-16.at.3.16.46.PM.mov
iOS: HybridApp
Screen.Recording.2026-11-16.at.3.44.16.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-11-16.at.3.26.47.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-16.at.3.07.57.PM.mov

@melvin-bot
melvin-bot Bot requested a review from mountiny November 16, 2026 10:15
@thesahindia

Copy link
Copy Markdown
Member

@David-2002065, please resolve conflicts and make the requested change.

…-touch-delete-APP-7AR

# Conflicts:
#	patches/react-native/details.md
@David-2002065
David-2002065 requested a review from a team as a code owner November 16, 2026 16:55
@expensify-chore-bot
expensify-chore-bot Bot requested review from trjExpensify and removed request for a team November 16, 2026 16:55
@David-2002065

Copy link
Copy Markdown
Contributor Author

@thesahindia merged main and fixed the conflict, patch is +050 now. also added the link

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love knocking these down! 👍

@mountiny
mountiny merged commit ea736fc into Expensify:main Nov 17, 2026
28 of 29 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants