Repository navigation
[No QA] Upgrade Oxfmt to 0.78.0 - #106281
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| "openai": "^7.0.0", | ||
| "oxc-transform-react": "0.156.0", | ||
| "oxfmt": "^0.55.0", | ||
| "oxfmt": "^0.75.0", |
There was a problem hiding this comment.
Oxfmt pins tinypol at 2.2.0 but we're using 2.1.2, maybe it should be aligned. NAB though
There was a problem hiding this comment.
Aligned the tinypool override and lockfile to 2.2.0, matching Oxfmt’s declared dependency, in 77fe682. Also upgraded Oxfmt to 0.78.0, the newest version eligible under the unchanged seven-day npm policy. npm ls oxfmt tinypool --all confirms a single tinypool@2.2.0; Oxfmt’s optional peers are not installed, so there are no duplicate peer trees to remove. Clean dependency installation, full-repository formatting, changed-file lint, and spelling checks passed.
Align the tinypool override with Oxfmt's required 2.2.0.\nKeep the existing seven-day npm release-age policy unchanged.
…77.0 # Conflicts: # package-lock.json # package.json # src/components/Search/SearchStaticList.tsx
|
@Julesssss ready for another review |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.40-0 🚀
|
|
No help site update needed — this PR upgrades development formatting tools and reformats code without adding features, changing user workflows, or making existing article instructions incorrect. |
Explanation of Change
Upgrade Oxfmt from 0.55.0 to 0.78.0 and apply its formatting changes so the repository-wide formatter check remains clean.
As of November 16, 2026, version 0.78.0 (published November 9) is the newest release eligible under the existing seven-day npm release-age policy; 0.79.0 (published November 16) is too new. All 19 native bindings are also eligible; no policy exceptions were added.
Align the global
tinypooloverride with Oxfmt's required 2.2.0 instead of forcing 2.1.2. The lockfile retains a single sharedtinypoolentry. Oxfmt's optional peers (@astrojs/compiler-rs,svelte, andvite-plus) are not installed, so there are no duplicate peer trees to deduplicate for this upgrade.Merged
main, preserving its Oxlint 1.92.0 upgrade and search checkbox Sentry label while retaining this PR's Oxfmt/tinypool versions and formatting.Previous benchmark (0.55.0 → 0.75.0, not rerun for 0.78.0): On an Apple M5 Max, Node 26.12.1, 18 threads, seven alternating warm
oxfmt --check .runs against the same 11,527-file base snapshot: median wall time fell from 0.4384 s to 0.2197 s (49.9% faster).Fixed Issues
$ n/a
Tests
None.
Offline tests
None.
QA Steps
None.
AI Tests
npm ci --ignore-scripts --no-audit --no-fundpassed with Node 26.12.1 and npm 11.20.0; initialized Bun and applied the repository's dependency patches afterward.main,oxfmt --check .passed on all 11,795 files with Oxfmt 0.78.0. Three files added/changed onmainneeded formatting-only updates.mainversions, preserving all incoming logic and the new search checkbox Sentry label.npm ls oxfmt tinypool --allpassed with Oxfmt 0.78.0 and a singletinypool@2.2.0.npm run lint-changedandnpm run spell-changedpassed.npm run react-compiler-compliance-check check-changedpassed on 20 changed TypeScript files after finalizing the merge commit. The pre-commit attempt compared against the old merge base and included incomingmainchanges; the post-merge check uses the correct base.tinypoolagainst the unchanged seven-day policy.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari