Skip to content

[No QA] Upgrade Oxfmt to 0.78.0 - #106281

Merged
Julesssss merged 3 commits into
mainfrom
rory/upgrade-oxfmt-0.77.0
Nov 16, 2026
Merged

Julesssss merged 3 commits into
mainfrom
rory/upgrade-oxfmt-0.77.0

Conversation

@roryabraham

@roryabraham roryabraham commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Upgrade Oxfmt from 0.55.0 to 0.78.0 and apply its formatting changes so the repository-wide formatter check remains clean.

As of November 16, 2026, version 0.78.0 (published November 9) is the newest release eligible under the existing seven-day npm release-age policy; 0.79.0 (published November 16) is too new. All 19 native bindings are also eligible; no policy exceptions were added.

Align the global tinypool override with Oxfmt's required 2.2.0 instead of forcing 2.1.2. The lockfile retains a single shared tinypool entry. Oxfmt's optional peers (@astrojs/compiler-rs, svelte, and vite-plus) are not installed, so there are no duplicate peer trees to deduplicate for this upgrade.

Merged main, preserving its Oxlint 1.92.0 upgrade and search checkbox Sentry label while retaining this PR's Oxfmt/tinypool versions and formatting.

Previous benchmark (0.55.0 → 0.75.0, not rerun for 0.78.0): On an Apple M5 Max, Node 26.12.1, 18 threads, seven alternating warm oxfmt --check . runs against the same 11,527-file base snapshot: median wall time fell from 0.4384 s to 0.2197 s (49.9% faster).

Fixed Issues

$ n/a

Tests

None.

  • Verify that no errors appear in the JS console

Offline tests

None.

QA Steps

None.

  • Verify that no errors appear in the JS console

AI Tests

  • npm ci --ignore-scripts --no-audit --no-fund passed with Node 26.12.1 and npm 11.20.0; initialized Bun and applied the repository's dependency patches afterward.
  • After merging main, oxfmt --check . passed on all 11,795 files with Oxfmt 0.78.0. Three files added/changed on main needed formatting-only updates.
  • Verified all 21 changed source/test files exactly match Oxfmt 0.78.0's output for their merged main versions, preserving all incoming logic and the new search checkbox Sentry label.
  • npm ls oxfmt tinypool --all passed with Oxfmt 0.78.0 and a single tinypool@2.2.0.
  • npm run lint-changed and npm run spell-changed passed.
  • npm run react-compiler-compliance-check check-changed passed on 20 changed TypeScript files after finalizing the merge commit. The pre-commit attempt compared against the old merge base and included incoming main changes; the post-merge check uses the correct base.
  • Verified the npm publication dates for Oxfmt, all 19 native bindings, and tinypool against the unchanged seven-day policy.
  • Staged branch-diff coding-standards review returned no violations.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@roryabraham
roryabraham requested a review from a team November 7, 2026 06:15
@melvin-bot

melvin-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@codecov

codecov Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/ImageWithLoading.tsx 90.58% <100.00%> (-0.11%) ⬇️
src/components/Modal/BaseModal.tsx 98.72% <100.00%> (-0.01%) ⬇️
...SearchList/ListItem/WithdrawalIDListItemHeader.tsx 99.03% <100.00%> (-0.01%) ⬇️
src/hooks/useSearchBulkActions.ts 82.40% <100.00%> (-0.02%) ⬇️
src/libs/ReportActionsUtils.ts 86.63% <100.00%> (-0.04%) ⬇️
src/libs/TransactionUtils/index.ts 95.79% <100.00%> (ø)
src/libs/actions/ImportTransactions.ts 98.57% <100.00%> (-0.02%) ⬇️
src/libs/actions/Policy/ReportField.ts 67.85% <100.00%> (+0.79%) ⬆️
...rt/ReportActionCompose/ComposerWithSuggestions.tsx 80.57% <100.00%> (-0.05%) ⬇️
src/components/CategoryPicker/index.tsx 97.59% <0.00%> (+1.16%) ⬆️
... and 4 more
... and 13 files with indirect coverage changes

@roryabraham roryabraham changed the title Upgrade Oxfmt to 0.75.0 [No QA] Upgrade Oxfmt to 0.75.0 Nov 7, 2026
@roryabraham
roryabraham marked this pull request as ready for review November 7, 2026 06:22
@roryabraham
roryabraham requested a review from a team as a code owner November 7, 2026 06:22
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team November 7, 2026 06:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T06:24:33.247641Z bbfb35d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@roryabraham
roryabraham removed the request for review from JmillsExpensify November 7, 2026 06:22
@melvin-bot
melvin-bot Bot requested review from Julesssss and removed request for a team November 7, 2026 06:22
@melvin-bot

melvin-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Comment thread package.json Outdated
"openai": "^7.0.0",
"oxc-transform-react": "0.156.0",
"oxfmt": "^0.55.0",
"oxfmt": "^0.75.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oxfmt pins tinypol at 2.2.0 but we're using 2.1.2, maybe it should be aligned. NAB though

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligned the tinypool override and lockfile to 2.2.0, matching Oxfmt’s declared dependency, in 77fe682. Also upgraded Oxfmt to 0.78.0, the newest version eligible under the unchanged seven-day npm policy. npm ls oxfmt tinypool --all confirms a single tinypool@2.2.0; Oxfmt’s optional peers are not installed, so there are no duplicate peer trees to remove. Clean dependency installation, full-repository formatting, changed-file lint, and spelling checks passed.

Julesssss
Julesssss previously approved these changes Nov 16, 2026

@Julesssss Julesssss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the tinypool override with Oxfmt's required 2.2.0.\nKeep the existing seven-day npm release-age policy unchanged.
@roryabraham
roryabraham requested a review from a team as a code owner November 16, 2026 18:38
@roryabraham roryabraham changed the title [No QA] Upgrade Oxfmt to 0.75.0 [No QA] Upgrade Oxfmt to 0.78.0 Nov 16, 2026
@expensify-chore-bot
expensify-chore-bot Bot requested review from Gonals and removed request for a team November 16, 2026 18:39
@expensify-chore-bot

Copy link
Copy Markdown

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@roryabraham
roryabraham removed the request for review from Gonals November 16, 2026 18:42
…77.0

# Conflicts:
#	package-lock.json
#	package.json
#	src/components/Search/SearchStaticList.tsx
@roryabraham

Copy link
Copy Markdown
Contributor Author

@Julesssss ready for another review

@Julesssss
Julesssss merged commit b4c4f48 into main Nov 16, 2026
54 of 55 checks passed
@Julesssss
Julesssss deleted the rory/upgrade-oxfmt-0.77.0 branch November 16, 2026 19:25
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR upgrades development formatting tools and reformats code without adding features, changing user workflows, or making existing article instructions incorrect.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants