Repository navigation
fix: After unreporting expense, table is shown without expense on group-by:approver view - #106341
Conversation
…up-by:approver view
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b254984406
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
JmillsExpensify
left a comment
There was a problem hiding this comment.
Makes sene to me
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2026-11-10.at.16.15.34.mov |
neil-marcellini
left a comment
There was a problem hiding this comment.
Good to go. It's similar to your other PR but more narrowly scope so I'm good with it. It will be make stronger when we also include a couple missing filters in the function deciding when to refetch for new actions.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.5.36-0 🚀
|
|
No help site update needed — this PR fixes stale grouped expense results after editing or removing an expense from a report, restoring expected behavior without adding a workflow or making existing article instructions incorrect. |
|
No FullStory changes needed — this PR only fixes stale grouped expense results after an expense is edited or removed from a report, without adding new user-facing functionality. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
fix: After unreporting expense, table is shown without expense on group-by:approver view
Fixed Issues
$ #105558
PROPOSAL:
Tests
Offline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-11-09.at.12.05.12.mov
Android: mWeb Chrome
Screen.Recording.2026-11-09.at.12.02.09.mov
iOS: Native
Screen.Recording.2026-11-09.at.12.06.25.mov
iOS: mWeb Safari
Screen.Recording.2026-11-09.at.12.00.26.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-09.at.11.58.59.mov