Repository navigation
fix: expose Send's disabled state to screen readers - #106349
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@twisterdotcom Could you approve the PR so I can merge it? It needs two approvals. |
twisterdotcom
left a comment
There was a problem hiding this comment.
Looks good from a product perspective.
|
🚧 pecanoro has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.5.36-0 🚀
|
|
No FullStory changes needed. This PR only fixes screen-reader announcements of the existing Send button’s disabled state, without adding new interactions, screens, user properties, or sensitive content. |
|
No help site update needed — this accessibility bug fix exposes the existing Send button’s disabled state to screen readers without changing the messaging workflow or making existing article instructions incorrect. |
|
@nyomanjyotisa @pecanoro seems this is a a11y accessibility PR, could this be verified internally? |
|
@kavimuru Verified with Safari/VoiceOver on staging 9.5.36-0 and Android/TalkBack using the official merged-commit build against staging. Send announces disabled when empty or whitespace-only, enables when typing, and disables again after sending. Screen-reader activation also works. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Expose Send’s disabled state to screen readers without changing keyboard focus order.
Fixed Issues
$ #104845 (comment)
PROPOSAL: #104845 (comment)
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
F22-Android-after-verified-Nov9.mp4
Android: mWeb Chrome
F22-Android-Chrome-after-final-Nov9.mp4
iOS: Native
F22-iOS-after-verified-Nov9.mp4
iOS: mWeb Safari
F22-iOS-Safari-after-final-Nov9.mp4
MacOS: Chrome / Safari
F22-Chrome-after-final-Nov9.mp4