Repository navigation
Conversation
1c9aab5 to
9944708
Compare
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…eport attributes on content (Expensify#104504)
9944708 to
e8290b2
Compare
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@abbasifaizan70 Could you shorten the comment? If it's not necessary, we can remove it. |
|
@MelvinBot review this |
|
@codex review this |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
🤖 Web test steps verification results: Verified basic navigation on dev NewDot web, but not the PR's update-loop regression. Required scripting, console access, offline control, and second-account fixtures were unavailable.
|
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-11-11.at.09.48.20.movAndroid: mWeb ChromeScreen.Recording.2026-11-11.at.09.49.58.moviOS: HybridAppScreen.Recording.2026-11-11.at.09.55.08.moviOS: mWeb SafariScreen.Recording.2026-11-11.at.09.57.42.movMacOS: Chrome / SafariScreen.Recording.2026-11-11.at.09.39.29.mov |
|
Nice work! The root cause analysis seems solid. My comments are small and not blocking. The one thing that actually can have the perf impact is Keep in mind I won't be working tomorrow (Independence Day) but I don't there is need for another review from me. |
…ibutes, trim comments
|
@abbasifaizan70 I don't think QA can test this normally, so could you update the QA steps to N/A and add [No QA] to the PR title? |
@mountiny It looks like he has already approved it |
|
I would like to make sure to measure the performance of these changes, @sosek108 could help to measure it on some supportalled big account |
|
I'm starting performance testing right now |
@sosek108 Please let us know if you find any issues. |
|
Sorry, I've had problems running semi automated tests as the app for me today was flaky. In the end I've successfully measured. Tests AB/BA so I tested main -> branch and branch -> main for more data.
Conclusion is that this PR does not decrease and may slightly improve performance Please, keep in mind that I will be on sick leave tomorrow |
mountiny
left a comment
There was a problem hiding this comment.
Perfect, thanks for testing and I hope you will feel better soon
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.38-0 🚀
|
|
No help site update needed — this PR fixes a crash and restores expected chat ordering and unread behavior without adding a feature, changing a workflow, or making existing article text incorrect. |


…eport attributes on content
Explanation of Change
On web,
SidebarOrderedReportsContextProvidercould crash with React #185 during bursts of Onyx writes. React counts commits that leave another update pending and throws after 50 in a row. Every Onyx-driven render of this provider is a synchronous commit whose passive effects run inside the commit, so thesetCurrentReportsToDisplayin the cache effect left an update pending after each one — and the memo returned a new map on every commit whenever an unread/GBR/RBR chat was displayed, even when nothing changed.setStateright after the memo. React re-runs the render before committing, nothing is left pending, and the counter can't grow. (A ref would also work but thereact-hooks/refslint rule disallows reading it during render.)WeakMapnow remembers each copy's source report, and the entry is reused when the report, the three flags andlastVisibleActionCreatedForInboxTabare unchanged, so a no-op recheck returns the same map.getUpdatedReports, the sort and the brick road now read a reference that only advances when the existing value diff reports a change.mainthese were excluded behind an eslint-disable, so switching to #focus with the same chats eligible kept the old order; covered by a test that fails onmain.The
react-hooks/set-state-in-effectseatbelt entry for this file is removed because the effect is gone.Fixed Issues
$ #104504
PROPOSAL: #104504 (comment)
Tests
mainthis shows the "Uh-oh, something went wrong!" page within a second.)Offline tests
Same as tests.
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
Same fix as web; the repro needs the browser console, which isn’t accessible on this platform.
iOS: Native
iOS: mWeb Safari
Same fix as web; the repro needs the browser console, which isn’t accessible on this platform.
MacOS: Chrome / Safari
Screen.Recording.2026-11-10.at.4.29.52.AM.mov