Skip to content

[No QA] Rename anonymous user guard - #106394

Merged
Julesssss merged 4 commits into
mainfrom
arosiclair-call-function-if-action-allowed
Nov 10, 2026
Merged

Julesssss merged 4 commits into
mainfrom
arosiclair-call-function-if-action-allowed

Conversation

@arosiclair

Copy link
Copy Markdown
Contributor

Explanation of Change

While reviewing a PR, it wasn't clear what this function did so I had to check the source to confirm. This rename should make things more obvious. I also removed the isAnonymousAction param since its redundant.

Fixed Issues

$ None

Tests

None

Offline tests

None

QA Steps

None

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@arosiclair arosiclair self-assigned this Nov 9, 2026
@melvin-bot

melvin-bot Bot commented Nov 9, 2026

Copy link
Copy Markdown

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@melvin-bot

melvin-bot Bot commented Nov 9, 2026

Copy link
Copy Markdown

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

@codecov

codecov Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/BookCallButton.tsx 100.00% <100.00%> (ø)
src/components/ChronosTimerHeaderButton.tsx 97.14% <100.00%> (ø)
src/components/ListField.tsx 97.72% <100.00%> (ø)
src/components/MenuItem/MenuItem.tsx 93.69% <100.00%> (ø)
src/components/MenuItem/presets/MenuItemAction.tsx 100.00% <100.00%> (ø)
...ents/MenuItem/presets/MenuItemAvatarNavigation.tsx 100.00% <100.00%> (ø)
src/components/MenuItem/presets/MenuItemField.tsx 100.00% <100.00%> (ø)
.../components/MenuItem/presets/MenuItemFieldHTML.tsx 100.00% <100.00%> (ø)
...components/MenuItem/presets/MenuItemNavigation.tsx 100.00% <100.00%> (ø)
.../components/MenuItem/presets/MenuItemWithLabel.tsx 100.00% <100.00%> (ø)
... and 83 more
... and 6 files with indirect coverage changes

@arosiclair
arosiclair marked this pull request as ready for review November 9, 2026 16:20
@arosiclair
arosiclair requested review from a team as code owners November 9, 2026 16:20
@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team November 9, 2026 16:20
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T16:28:14.001621Z a3447c1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from Julesssss and removed request for a team November 9, 2026 16:21
@melvin-bot

melvin-bot Bot commented Nov 9, 2026

Copy link
Copy Markdown

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

This doesn't seem like a PR that needs a product review, so removing mine. Please ping me if there's anything that I should review here, though.

@joekaufmanexpensify
joekaufmanexpensify removed their request for review November 9, 2026 22:21
Julesssss
Julesssss previously approved these changes Nov 10, 2026
@Julesssss

Copy link
Copy Markdown
Contributor

@arosiclair conflicts :/

@Julesssss
Julesssss merged commit 25a484d into main Nov 10, 2026
47 of 48 checks passed
@Julesssss
Julesssss deleted the arosiclair-call-function-if-action-allowed branch November 10, 2026 16:44
@github-actions

Copy link
Copy Markdown
Contributor

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No FullStory changes needed — this PR only renames the authentication guard and removes a redundant parameter, without adding user-facing functionality or changing tracking requirements.


view run

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR only renames an internal authentication helper and removes a redundant parameter, preserving existing user-facing behavior and leaving existing articles accurate.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants