Repository navigation
[No QA] Replace Strict API deep imports and removed type exports with public types - #106402
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3ad1f48be
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
dylanexpensify
left a comment
There was a problem hiding this comment.
Product input not required for this PR.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.40-0 🚀
|
|
No help site update needed — this PR updates internal React Native type compatibility without introducing a user-facing feature, changing a workflow or label, or making existing help instructions incorrect. |
Explanation of Change
RN 0.87+ makes the Strict TypeScript API the default and blocks
react-native/Libraries/*type imports. This replaces those deep imports, and the type names the Strict API removed, with publicreact-nativeexports orReactNativeCompataliases that typecheck on 0.86 and 0.88. Only type positions change: the emitted JS of every file is identical.Fixed Issues
$ #101439
PROPOSAL: N/A
Tests
This PR only changes types, so there is nothing to click through. The steps check the type graph.
Test 1: The app still typechecks on the current React Native types
npm run typecheckType checking passed.Test 2: No type deep imports into
react-native/Librariesremaingrep -rnE "from ['\"]react-native/(Libraries|src)" src tests --include='*.ts' --include='*.tsx'src/components/AlwaysPaintedView/index.native.tsx(it has its own module declaration and is out of scope here) and a string fixture intests/tooling/RepackBabelAllowlist.test.tsOffline tests
N/A
QA Steps
None. Type-only change: the emitted JavaScript of every changed file is byte-identical before and after, so nothing changes for the user.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari